From mboxrd@z Thu Jan 1 00:00:00 1970 From: Axel Lin Subject: [RESEND][PATCH 1/3] PM / devfreq: exynos4_bus: Fix missing mutex_unlock if opp_find_freq_floor fails Date: Fri, 12 Apr 2013 13:54:18 +0800 Message-ID: <1365746058.4025.1.camel@phoenix> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-da0-f51.google.com ([209.85.210.51]:47264 "EHLO mail-da0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750817Ab3DLFyZ (ORCPT ); Fri, 12 Apr 2013 01:54:25 -0400 Received: by mail-da0-f51.google.com with SMTP id g27so994161dan.10 for ; Thu, 11 Apr 2013 22:54:24 -0700 (PDT) Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: "Rafael J. Wysocki" , MyungJoo Ham Cc: Kyungmin Park , Kukjin Kim , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org We need to call mutex_unlock() in the error path. Signed-off-by: Axel Lin --- drivers/devfreq/exynos4_bus.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/devfreq/exynos4_bus.c b/drivers/devfreq/exynos4_bus.c index 1deee09..54b9615 100644 --- a/drivers/devfreq/exynos4_bus.c +++ b/drivers/devfreq/exynos4_bus.c @@ -974,7 +974,8 @@ static int exynos4_busfreq_pm_notifier_event(struct notifier_block *this, rcu_read_unlock(); dev_err(data->dev, "%s: unable to find a min freq\n", __func__); - return PTR_ERR(opp); + err = PTR_ERR(opp); + goto unlock; } new_oppinfo.rate = opp_get_freq(opp); new_oppinfo.volt = opp_get_voltage(opp); -- 1.7.9.5