linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: rjw@sisk.pl
Cc: andrew@lunn.ch, khilman@deeprootsystems.com, nsekhar@ti.com,
	josephl@nvidia.com, kgene.kim@samsung.com, patches@linaro.org,
	magnus.damm@gmail.com, tony@atomide.com, plagnioj@jcrosoft.com,
	linaro-kernel@lists.linaro.org, jason@lakedaemon.net,
	swarren@wwwdotorg.org, rob.herring@calxeda.com,
	horms@verge.net.au, linux@maxim.org.za,
	linux-arm-kernel@lists.infradead.org, deepthi@linux.vnet.ibm.com,
	jkosina@suse.cz, linux-pm@vger.kernel.org, lethal@linux-sh.org,
	kernel@pengutronix.de
Subject: [V4 patch 09/15] ARM: OMAP4: cpuidle: use init/exit common routine
Date: Tue, 23 Apr 2013 10:54:39 +0200	[thread overview]
Message-ID: <1366707285-12179-10-git-send-email-daniel.lezcano@linaro.org> (raw)
In-Reply-To: <1366707285-12179-1-git-send-email-daniel.lezcano@linaro.org>

Remove the duplicated code and use the cpuidle common code for initialization.

Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
Reviewed-by: Kevin Hilman <khilman@linaro.org>
Tested-by: Kevin Hilman <khilman@linaro.org>
---
 arch/arm/mach-omap2/cpuidle44xx.c |   26 ++------------------------
 1 file changed, 2 insertions(+), 24 deletions(-)

diff --git a/arch/arm/mach-omap2/cpuidle44xx.c b/arch/arm/mach-omap2/cpuidle44xx.c
index d1bfb21..5a286b5 100644
--- a/arch/arm/mach-omap2/cpuidle44xx.c
+++ b/arch/arm/mach-omap2/cpuidle44xx.c
@@ -15,6 +15,7 @@
 #include <linux/cpu_pm.h>
 #include <linux/export.h>
 
+#include <asm/cpuidle.h>
 #include <asm/proc-fns.h>
 
 #include "common.h"
@@ -159,8 +160,6 @@ fail:
 	return index;
 }
 
-static DEFINE_PER_CPU(struct cpuidle_device, omap_idle_dev);
-
 static struct cpuidle_driver omap4_idle_driver = {
 	.name				= "omap4_idle",
 	.owner				= THIS_MODULE,
@@ -209,9 +208,6 @@ static struct cpuidle_driver omap4_idle_driver = {
  */
 int __init omap4_idle_init(void)
 {
-	struct cpuidle_device *dev;
-	unsigned int cpu_id = 0;
-
 	mpu_pd = pwrdm_lookup("mpu_pwrdm");
 	cpu_pd[0] = pwrdm_lookup("cpu0_pwrdm");
 	cpu_pd[1] = pwrdm_lookup("cpu1_pwrdm");
@@ -223,23 +219,5 @@ int __init omap4_idle_init(void)
 	if (!cpu_clkdm[0] || !cpu_clkdm[1])
 		return -ENODEV;
 
-	if (cpuidle_register_driver(&omap4_idle_driver)) {
-		pr_err("%s: CPUidle driver register failed\n", __func__);
-		return -EIO;
-	}
-
-	for_each_cpu(cpu_id, cpu_online_mask) {
-		dev = &per_cpu(omap_idle_dev, cpu_id);
-		dev->cpu = cpu_id;
-#ifdef CONFIG_ARCH_NEEDS_CPU_IDLE_COUPLED
-		dev->coupled_cpus = *cpu_online_mask;
-#endif
-		if (cpuidle_register_device(dev)) {
-			pr_err("%s: CPUidle register failed\n", __func__);
-			cpuidle_unregister_driver(&omap4_idle_driver);
-			return -EIO;
-		}
-	}
-
-	return 0;
+	return cpuidle_register(&omap4_idle_driver, cpu_online_mask);
 }
-- 
1.7.9.5


  parent reply	other threads:[~2013-04-23  8:55 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-23  8:54 [V4 patch 00/15] cpuidle: code consolidation Daniel Lezcano
2013-04-23  8:54 ` [V4 patch 01/15] cpuidle: remove en_core_tk_irqen flag Daniel Lezcano
2013-04-23  8:54 ` [V4 patch 02/15] ARM: ux500: cpuidle: replace for_each_online_cpu by for_each_possible_cpu Daniel Lezcano
2013-04-30  9:16   ` Chander Kashyap
2013-04-23  8:54 ` [V4 patch 03/15] cpuidle: make a single register function for all Daniel Lezcano
2013-04-23 12:19   ` Rob Herring
2013-04-23 12:32   ` Santosh Shilimkar
2013-04-23 12:51     ` Daniel Lezcano
2013-04-23 13:04       ` Santosh Shilimkar
2013-04-23  8:54 ` [V4 patch 04/15] ARM: ux500: cpuidle: use init/exit common routine Daniel Lezcano
2013-04-23  8:54 ` [V4 patch 05/15] ARM: at91: " Daniel Lezcano
2013-04-23  8:54 ` [V4 patch 06/15] ARM: OMAP3: " Daniel Lezcano
2013-04-23  8:54 ` [V4 patch 07/15] ARM: tegra: " Daniel Lezcano
2013-04-23  8:54 ` [V4 patch 08/15] ARM: shmobile: " Daniel Lezcano
2013-04-23  8:54 ` Daniel Lezcano [this message]
2013-04-23  8:54 ` [V4 patch 10/15] ARM: tegra: cpuidle: use init/exit common routine for tegra2 Daniel Lezcano
2013-04-23  8:54 ` [V4 patch 11/15] ARM: tegra: cpuidle: use init/exit common routine for tegra3 Daniel Lezcano
2013-04-23  8:54 ` [V4 patch 12/15] ARM: calxeda: cpuidle: use init/exit common routine Daniel Lezcano
2013-04-23  8:54 ` [V4 patch 13/15] ARM: kirkwood: " Daniel Lezcano
2013-04-23  8:54 ` [V4 patch 14/15] ARM: davinci: " Daniel Lezcano
2013-04-23  8:54 ` [V4 patch 15/15] ARM: imx: " Daniel Lezcano
2013-04-23 12:00 ` [V4 patch 00/15] cpuidle: code consolidation Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1366707285-12179-10-git-send-email-daniel.lezcano@linaro.org \
    --to=daniel.lezcano@linaro.org \
    --cc=andrew@lunn.ch \
    --cc=deepthi@linux.vnet.ibm.com \
    --cc=horms@verge.net.au \
    --cc=jason@lakedaemon.net \
    --cc=jkosina@suse.cz \
    --cc=josephl@nvidia.com \
    --cc=kernel@pengutronix.de \
    --cc=kgene.kim@samsung.com \
    --cc=khilman@deeprootsystems.com \
    --cc=lethal@linux-sh.org \
    --cc=linaro-kernel@lists.linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux@maxim.org.za \
    --cc=magnus.damm@gmail.com \
    --cc=nsekhar@ti.com \
    --cc=patches@linaro.org \
    --cc=plagnioj@jcrosoft.com \
    --cc=rjw@sisk.pl \
    --cc=rob.herring@calxeda.com \
    --cc=swarren@wwwdotorg.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).