From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: rjw@sisk.pl
Cc: andrew@lunn.ch, khilman@deeprootsystems.com, nsekhar@ti.com,
josephl@nvidia.com, kgene.kim@samsung.com, patches@linaro.org,
magnus.damm@gmail.com, tony@atomide.com, plagnioj@jcrosoft.com,
linaro-kernel@lists.linaro.org, jason@lakedaemon.net,
swarren@wwwdotorg.org, rob.herring@calxeda.com,
horms@verge.net.au, linux@maxim.org.za,
linux-arm-kernel@lists.infradead.org, deepthi@linux.vnet.ibm.com,
jkosina@suse.cz, linux-pm@vger.kernel.org, lethal@linux-sh.org,
kernel@pengutronix.de
Subject: [V4 patch 04/15] ARM: ux500: cpuidle: use init/exit common routine
Date: Tue, 23 Apr 2013 10:54:34 +0200 [thread overview]
Message-ID: <1366707285-12179-5-git-send-email-daniel.lezcano@linaro.org> (raw)
In-Reply-To: <1366707285-12179-1-git-send-email-daniel.lezcano@linaro.org>
Remove the duplicate code and use the cpuidle common code for initialization.
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
---
arch/arm/mach-ux500/cpuidle.c | 32 +-------------------------------
1 file changed, 1 insertion(+), 31 deletions(-)
diff --git a/arch/arm/mach-ux500/cpuidle.c b/arch/arm/mach-ux500/cpuidle.c
index 5657d4a..488e074 100644
--- a/arch/arm/mach-ux500/cpuidle.c
+++ b/arch/arm/mach-ux500/cpuidle.c
@@ -21,7 +21,6 @@
static atomic_t master = ATOMIC_INIT(0);
static DEFINE_SPINLOCK(master_lock);
-static DEFINE_PER_CPU(struct cpuidle_device, ux500_cpuidle_device);
static inline int ux500_enter_idle(struct cpuidle_device *dev,
struct cpuidle_driver *drv, int index)
@@ -112,40 +111,11 @@ static struct cpuidle_driver ux500_idle_driver = {
int __init ux500_idle_init(void)
{
- int ret, cpu;
- struct cpuidle_device *device;
-
/* Configure wake up reasons */
prcmu_enable_wakeups(PRCMU_WAKEUP(ARM) | PRCMU_WAKEUP(RTC) |
PRCMU_WAKEUP(ABB));
- ret = cpuidle_register_driver(&ux500_idle_driver);
- if (ret) {
- printk(KERN_ERR "failed to register ux500 idle driver\n");
- return ret;
- }
-
- for_each_possible(cpu) {
- device = &per_cpu(ux500_cpuidle_device, cpu);
- device->cpu = cpu;
- ret = cpuidle_register_device(device);
- if (ret) {
- printk(KERN_ERR "Failed to register cpuidle "
- "device for cpu%d\n", cpu);
- goto out_unregister;
- }
- }
-out:
- return ret;
-
-out_unregister:
- for_each_possible_cpu(cpu) {
- device = &per_cpu(ux500_cpuidle_device, cpu);
- cpuidle_unregister_device(device);
- }
-
- cpuidle_unregister_driver(&ux500_idle_driver);
- goto out;
+ return cpuidle_register(&ux500_idle_driver, NULL);
}
device_initcall(ux500_idle_init);
--
1.7.9.5
next prev parent reply other threads:[~2013-04-23 8:55 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-23 8:54 [V4 patch 00/15] cpuidle: code consolidation Daniel Lezcano
2013-04-23 8:54 ` [V4 patch 01/15] cpuidle: remove en_core_tk_irqen flag Daniel Lezcano
2013-04-23 8:54 ` [V4 patch 02/15] ARM: ux500: cpuidle: replace for_each_online_cpu by for_each_possible_cpu Daniel Lezcano
2013-04-30 9:16 ` Chander Kashyap
2013-04-23 8:54 ` [V4 patch 03/15] cpuidle: make a single register function for all Daniel Lezcano
2013-04-23 12:19 ` Rob Herring
2013-04-23 12:32 ` Santosh Shilimkar
2013-04-23 12:51 ` Daniel Lezcano
2013-04-23 13:04 ` Santosh Shilimkar
2013-04-23 8:54 ` Daniel Lezcano [this message]
2013-04-23 8:54 ` [V4 patch 05/15] ARM: at91: cpuidle: use init/exit common routine Daniel Lezcano
2013-04-23 8:54 ` [V4 patch 06/15] ARM: OMAP3: " Daniel Lezcano
2013-04-23 8:54 ` [V4 patch 07/15] ARM: tegra: " Daniel Lezcano
2013-04-23 8:54 ` [V4 patch 08/15] ARM: shmobile: " Daniel Lezcano
2013-04-23 8:54 ` [V4 patch 09/15] ARM: OMAP4: " Daniel Lezcano
2013-04-23 8:54 ` [V4 patch 10/15] ARM: tegra: cpuidle: use init/exit common routine for tegra2 Daniel Lezcano
2013-04-23 8:54 ` [V4 patch 11/15] ARM: tegra: cpuidle: use init/exit common routine for tegra3 Daniel Lezcano
2013-04-23 8:54 ` [V4 patch 12/15] ARM: calxeda: cpuidle: use init/exit common routine Daniel Lezcano
2013-04-23 8:54 ` [V4 patch 13/15] ARM: kirkwood: " Daniel Lezcano
2013-04-23 8:54 ` [V4 patch 14/15] ARM: davinci: " Daniel Lezcano
2013-04-23 8:54 ` [V4 patch 15/15] ARM: imx: " Daniel Lezcano
2013-04-23 12:00 ` [V4 patch 00/15] cpuidle: code consolidation Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1366707285-12179-5-git-send-email-daniel.lezcano@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=andrew@lunn.ch \
--cc=deepthi@linux.vnet.ibm.com \
--cc=horms@verge.net.au \
--cc=jason@lakedaemon.net \
--cc=jkosina@suse.cz \
--cc=josephl@nvidia.com \
--cc=kernel@pengutronix.de \
--cc=kgene.kim@samsung.com \
--cc=khilman@deeprootsystems.com \
--cc=lethal@linux-sh.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@maxim.org.za \
--cc=magnus.damm@gmail.com \
--cc=nsekhar@ti.com \
--cc=patches@linaro.org \
--cc=plagnioj@jcrosoft.com \
--cc=rjw@sisk.pl \
--cc=rob.herring@calxeda.com \
--cc=swarren@wwwdotorg.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).