From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zhang Rui Subject: [PATCH] ACPI thermal: do not always return THERMAL_TREND_RAISING for active trip points Date: Fri, 26 Apr 2013 17:19:53 +0800 Message-ID: <1366967993-3812-1-git-send-email-rui.zhang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mga03.intel.com ([143.182.124.21]:56632 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759216Ab3DZJUF (ORCPT ); Fri, 26 Apr 2013 05:20:05 -0400 Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-acpi@vger.kernel.org Cc: rjw@sisk.pl, lenb@kernel.org, eduardo.valentin@ti.com, Zhang Rui Commit 4ae46befb49d4173122e0afa995c4e93d01948a2 introduces a regression that the fan is always on even if the system is in idle state. My original idea in that commit is that: when the current temperature is above the trip point, keep the fan on, even if the temperature is dropping. when the current temperature is below the trip point, turn on the fan when the temperature is raising, turn off the fan when the temperature is dropping. But this is what the code actually does: when the current temperature is above the trip point, the fan keeps on. when the current temperature is below the trip point, the fan is always on because thermal_get_trend() in driver/acpi/thermal.c returns THERMAL_TREND_RAISING. Thus the fan keeps running even if the system is idle. =46ix this in drivers/acpi/thermal.c. https://bugzilla.kernel.org/show_bug.cgi?id=3D56591 https://bugzilla.kernel.org/show_bug.cgi?id=3D56601 https://bugzilla.kernel.org/show_bug.cgi?id=3D50041#c45 Patch should be applied to 3.7 stable kernel and later. Signed-off-by: Zhang Rui Tested-by: Matthias Tested-by: Ville Syrj=C3=A4l=C3=A4 Cc: # v3.7+ --- drivers/acpi/thermal.c | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/drivers/acpi/thermal.c b/drivers/acpi/thermal.c index 8470771..a33821c 100644 --- a/drivers/acpi/thermal.c +++ b/drivers/acpi/thermal.c @@ -723,9 +723,19 @@ static int thermal_get_trend(struct thermal_zone_d= evice *thermal, return -EINVAL; =20 if (type =3D=3D THERMAL_TRIP_ACTIVE) { - /* aggressive active cooling */ - *trend =3D THERMAL_TREND_RAISING; - return 0; + unsigned long trip_temp; + unsigned long temp =3D KELVIN_TO_MILLICELSIUS(tz->temperature, + tz->kelvin_offset); + if (thermal_get_trip_temp(thermal, trip, &trip_temp)) + return -EINVAL; + + if (temp > trip_temp) { + *trend =3D THERMAL_TREND_RAISING; + return 0; + } else { + /* Fall back on default trend */ + return -EINVAL; + } } =20 /* --=20 1.7.9.5