From: Amit Daniel Kachhap <amit.daniel@samsung.com>
To: linux-pm@vger.kernel.org
Cc: Zhang Rui <rui.zhang@intel.com>,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
amit.kachhap@gmail.com, Kukjin Kim <kgene.kim@samsung.com>,
Eduardo Valentin <eduardo.valentin@ti.com>
Subject: [PATCH V2 10/20] thermal: exynos: Fix to clear only the generated interrupts
Date: Fri, 26 Apr 2013 16:07:41 +0530 [thread overview]
Message-ID: <1366972671-9227-11-git-send-email-amit.daniel@samsung.com> (raw)
In-Reply-To: <1366972671-9227-1-git-send-email-amit.daniel@samsung.com>
This patch uses the TMU status register to know the generated interrupts
and only clear them in the interrupt handler.
Acked-by: Kukjin Kim <kgene.kim@samsung.com>
Signed-off-by: Amit Daniel Kachhap <amit.daniel@samsung.com>
---
drivers/thermal/samsung/exynos_tmu.c | 10 ++++------
drivers/thermal/samsung/exynos_tmu_data.c | 2 ++
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c
index 97b87aa..082d5a2 100644
--- a/drivers/thermal/samsung/exynos_tmu.c
+++ b/drivers/thermal/samsung/exynos_tmu.c
@@ -325,17 +325,15 @@ static void exynos_tmu_work(struct work_struct *work)
struct exynos_tmu_data, irq_work);
struct exynos_tmu_platform_data *pdata = data->pdata;
struct exynos_tmu_registers *reg = pdata->registers;
+ unsigned int val_irq;
exynos_report_trigger();
mutex_lock(&data->lock);
clk_enable(data->clk);
- if (data->soc == SOC_ARCH_EXYNOS)
- writel((reg->inten_rise_mask << reg->inten_rise_shift) |
- (reg->inten_fall_mask << reg->inten_fall_shift),
- data->base + reg->tmu_intclear);
- else
- writel(reg->inten_rise_mask, data->base + reg->tmu_intclear);
+ val_irq = readl(data->base + reg->tmu_intstat);
+ /* clear the interrupts */
+ writel(val_irq, data->base + reg->tmu_intclear);
clk_disable(data->clk);
mutex_unlock(&data->lock);
diff --git a/drivers/thermal/samsung/exynos_tmu_data.c b/drivers/thermal/samsung/exynos_tmu_data.c
index 3a1ded1..7322597 100644
--- a/drivers/thermal/samsung/exynos_tmu_data.c
+++ b/drivers/thermal/samsung/exynos_tmu_data.c
@@ -45,6 +45,7 @@ static struct exynos_tmu_registers exynos4210_tmu_registers = {
.inten_rise1_shift = EXYNOS_TMU_INTEN_RISE1_SHIFT,
.inten_rise2_shift = EXYNOS_TMU_INTEN_RISE2_SHIFT,
.inten_rise3_shift = EXYNOS_TMU_INTEN_RISE3_SHIFT,
+ .tmu_intstat = EXYNOS_TMU_REG_INTSTAT,
.tmu_intclear = EXYNOS_TMU_REG_INTCLEAR,
};
struct exynos_tmu_platform_data const exynos4210_default_tmu_data = {
@@ -111,6 +112,7 @@ static struct exynos_tmu_registers exynos5250_tmu_registers = {
.inten_rise2_shift = EXYNOS_TMU_INTEN_RISE2_SHIFT,
.inten_rise3_shift = EXYNOS_TMU_INTEN_RISE3_SHIFT,
.inten_fall0_shift = EXYNOS_TMU_INTEN_FALL0_SHIFT,
+ .tmu_intstat = EXYNOS_TMU_REG_INTSTAT,
.tmu_intclear = EXYNOS_TMU_REG_INTCLEAR,
.emul_con = EXYNOS_EMUL_CON,
.emul_temp_shift = EXYNOS_EMUL_DATA_SHIFT,
--
1.7.1
next prev parent reply other threads:[~2013-04-26 10:37 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-26 10:37 [PATCH V2 0/20] thermal: exynos: Add thermal driver for exynos5440 Amit Daniel Kachhap
2013-04-26 10:37 ` [PATCH V2 01/20] thermal: exynos: Moving exynos thermal files into samsung directory Amit Daniel Kachhap
2013-05-06 15:05 ` Zhang Rui
2013-05-07 10:21 ` Tomasz Figa
2013-05-07 13:18 ` amit daniel kachhap
2013-05-07 13:36 ` Tomasz Figa
2013-05-07 13:12 ` amit daniel kachhap
2013-04-26 10:37 ` [PATCH V2 02/20] thermal: exynos: Bifurcate exynos thermal common and tmu controller code Amit Daniel Kachhap
2013-05-06 15:16 ` Zhang Rui
2013-05-07 13:32 ` amit daniel kachhap
2013-04-26 10:37 ` [PATCH V2 03/20] thermal: exynos: Rename exynos_thermal.c to exynos_tmu.c Amit Daniel Kachhap
2013-05-06 15:18 ` Zhang Rui
2013-04-26 10:37 ` [PATCH V2 04/20] thermal: exynos: Move exynos_thermal.h from include/* to driver/* folder Amit Daniel Kachhap
2013-05-06 15:19 ` Zhang Rui
2013-04-26 10:37 ` [PATCH V2 05/20] thermal: exynos: Bifurcate exynos tmu driver and configuration data Amit Daniel Kachhap
2013-05-06 15:28 ` Zhang Rui
2013-04-26 10:37 ` [PATCH V2 06/20] thermal: exynos: Add missing definations and code cleanup Amit Daniel Kachhap
2013-04-26 10:37 ` [PATCH V2 07/20] thermal: exynos: Add extra entries in the tmu platform data Amit Daniel Kachhap
2013-04-26 10:37 ` [PATCH V2 08/20] thermal: exynos: Support thermal tripping Amit Daniel Kachhap
2013-04-26 10:37 ` [PATCH V2 09/20] thermal: exynos: Move register definitions from driver file to data file Amit Daniel Kachhap
2013-04-26 10:37 ` Amit Daniel Kachhap [this message]
2013-04-26 10:37 ` [PATCH V2 11/20] thermal: exynos: Add support for instance based register/unregister Amit Daniel Kachhap
2013-04-26 10:37 ` [PATCH V2 12/20] thermal: exynos: Modify private_data to appropriate name driver_data Amit Daniel Kachhap
2013-04-26 10:37 ` [PATCH V2 13/20] thermal: exynos: Return success even if no cooling data supplied Amit Daniel Kachhap
2013-04-26 10:37 ` [PATCH V2 14/20] thermal: exynos: Make the zone handling dependent on trip count Amit Daniel Kachhap
2013-04-26 10:37 ` [PATCH V2 15/20] thermal: exynos: Add support to handle many instances of TMU Amit Daniel Kachhap
2013-04-26 10:37 ` [PATCH V2 16/20] thermal: exynos: Add features to check instead of SOC type Amit Daniel Kachhap
2013-04-26 10:37 ` [PATCH V2 17/20] ARM: dts: thermal: exynos4: Add documentation for Exynos SoC thermal bindings Amit Daniel Kachhap
2013-04-26 10:37 ` [PATCH V2 18/20] thermal: exynos: Add support for exynos5440 TMU sensor Amit Daniel Kachhap
2013-04-26 10:37 ` [PATCH V2 19/20] Documentation: thermal: Explain the exynos thermal driver model Amit Daniel Kachhap
2013-04-26 10:37 ` [PATCH V2 20/20] ARM: dts: Add device tree node for exynos5440 TMU controller Amit Daniel Kachhap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1366972671-9227-11-git-send-email-amit.daniel@samsung.com \
--to=amit.daniel@samsung.com \
--cc=amit.kachhap@gmail.com \
--cc=eduardo.valentin@ti.com \
--cc=kgene.kim@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).