From: Colin Cross <ccross@android.com>
To: linux-pm@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, "Rafael J. Wysocki" <rjw@sisk.pl>,
arve@android.com, Colin Cross <ccross@android.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Al Viro <viro@zeniv.linux.org.uk>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Sachin Kamat <sachin.kamat@linaro.org>,
devel@driverdev.osuosl.org
Subject: [PATCH 04/10] binder: use freezable blocking calls
Date: Mon, 29 Apr 2013 14:45:40 -0700 [thread overview]
Message-ID: <1367271946-7239-5-git-send-email-ccross@android.com> (raw)
In-Reply-To: <1367271946-7239-1-git-send-email-ccross@android.com>
Avoid waking up every thread sleeping in a binder call during
suspend and resume by calling a freezable blocking call.
Signed-off-by: Colin Cross <ccross@android.com>
---
drivers/staging/android/binder.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c
index 24456a0..af8fba4 100644
--- a/drivers/staging/android/binder.c
+++ b/drivers/staging/android/binder.c
@@ -20,6 +20,7 @@
#include <asm/cacheflush.h>
#include <linux/fdtable.h>
#include <linux/file.h>
+#include <linux/freezer.h>
#include <linux/fs.h>
#include <linux/list.h>
#include <linux/miscdevice.h>
@@ -2140,13 +2141,13 @@ retry:
if (!binder_has_proc_work(proc, thread))
ret = -EAGAIN;
} else
- ret = wait_event_interruptible_exclusive(proc->wait, binder_has_proc_work(proc, thread));
+ ret = wait_event_freezable_exclusive(proc->wait, binder_has_proc_work(proc, thread));
} else {
if (non_block) {
if (!binder_has_thread_work(thread))
ret = -EAGAIN;
} else
- ret = wait_event_interruptible(thread->wait, binder_has_thread_work(thread));
+ ret = wait_event_freezable(thread->wait, binder_has_thread_work(thread));
}
binder_lock(__func__);
--
1.8.2.1
next prev parent reply other threads:[~2013-04-29 21:45 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-29 21:45 [PATCH 00/10] optimize freezing tasks by reducing task wakeups Colin Cross
2013-04-29 21:45 ` [PATCH 01/10] freezer: shorten freezer sleep time using exponential backoff Colin Cross
2013-05-02 12:28 ` Pavel Machek
[not found] ` <1367271946-7239-1-git-send-email-ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org>
2013-04-29 21:45 ` [PATCH 02/10] freezer: skip waking up tasks with PF_FREEZER_SKIP set Colin Cross
[not found] ` <1367271946-7239-3-git-send-email-ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org>
2013-04-29 21:51 ` Tejun Heo
[not found] ` <20130429215157.GA2395-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2013-04-29 21:57 ` Tejun Heo
2013-04-29 22:02 ` Colin Cross
[not found] ` <CAMbhsRQHkm=XTYtummEZq1h4sa-tRGwLpk8Uyhpj9D3+jQF3dg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-04-29 22:08 ` Tejun Heo
[not found] ` <20130429220831.GC2395-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2013-04-29 22:16 ` Tejun Heo
2013-04-30 11:48 ` Rafael J. Wysocki
2013-04-30 17:10 ` Oleg Nesterov
2013-04-30 17:15 ` Oleg Nesterov
2013-04-29 21:45 ` [PATCH 03/10] freezer: add new freezable helpers using freezer_do_not_count() Colin Cross
2013-05-02 12:48 ` Pavel Machek
2013-05-02 13:05 ` Oliver Neukum
2013-05-02 13:46 ` Pavel Machek
2013-05-02 17:05 ` Colin Cross
2013-05-03 14:00 ` Pavel Machek
2013-04-29 21:45 ` Colin Cross [this message]
2013-04-29 21:45 ` [PATCH 05/10] epoll: use freezable blocking call Colin Cross
2013-04-29 21:45 ` [PATCH 06/10] select: " Colin Cross
2013-04-29 21:45 ` [PATCH 07/10] futex: " Colin Cross
2013-04-29 22:52 ` Darren Hart
2013-04-29 23:46 ` Colin Cross
2013-05-02 19:52 ` Matt Helsley
2013-04-29 21:45 ` [PATCH 08/10] nanosleep: " Colin Cross
2013-04-29 21:45 ` [PATCH 09/10] sigtimedwait: " Colin Cross
2013-04-30 16:38 ` Oleg Nesterov
2013-04-30 16:56 ` Oleg Nesterov
2013-04-30 16:58 ` Colin Cross
2013-04-30 17:00 ` Oleg Nesterov
2013-04-29 21:45 ` [PATCH 10/10] af_unix: use freezable blocking calls in read Colin Cross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1367271946-7239-5-git-send-email-ccross@android.com \
--to=ccross@android.com \
--cc=arve@android.com \
--cc=devel@driverdev.osuosl.org \
--cc=ebiederm@xmission.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=sachin.kamat@linaro.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).