From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
rjw@sisk.pl, pavel@ucw.cz, tglx@linutronix.de, mingo@redhat.com,
hpa@zytor.com, x86@kernel.org
Subject: [RFC] Fix restore from hibernate with different kernel versions.
Date: Wed, 1 May 2013 21:53:29 -0400 [thread overview]
Message-ID: <1367459610-9656-1-git-send-email-konrad.wilk@oracle.com> (raw)
This patch is intended for v3.10 and it should be considered RFC as I had
only tested it under QEMU and not real hardware (that to be done on Friday).
The patch addresses a shortcomming of the git commite
7a5cd063c7b4c58417f674821d63f5eb6747e37 ("x86-64, gdt: Store/load GDT for
ACPI S3 or hibernate/resume path is not needed.") where its assumption
about restoring a kernel was incorrect. Specifically it assumed that a resumed
kernel MUST be the same as the one booted. That is only true for 32-bit
kernels but not for 64-bit.
And as such it introduces a regression which the attached patch is
fixing.
The patch goes further and also lays the groundwork to make this work under
a 32-bit kernel - even though it is not neccessary. This is done to unify
the 32 and 64-bit code and make it easier in the future to unify the
respective code closer.
arch/x86/include/asm/suspend_32.h | 1 +
arch/x86/include/asm/suspend_64.h | 2 ++
arch/x86/kernel/asm-offsets_32.c | 3 +++
arch/x86/kernel/asm-offsets_64.c | 1 +
arch/x86/power/cpu.c | 15 ++++++++++-----
arch/x86/power/hibernate_asm_32.S | 4 ++++
arch/x86/power/hibernate_asm_64.S | 3 +++
7 files changed, 24 insertions(+), 5 deletions(-)
Konrad Rzeszutek Wilk (1):
x86, x86-64, gdt, hibernate: Store/load GDT for hibernate path.
next reply other threads:[~2013-05-02 1:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-02 1:53 Konrad Rzeszutek Wilk [this message]
2013-05-02 1:53 ` [PATCH] x86, x86-64, gdt, hibernate: Store/load GDT for hibernate path Konrad Rzeszutek Wilk
2013-05-02 12:00 ` Rafael J. Wysocki
2013-05-02 12:34 ` Pavel Machek
2013-05-02 12:50 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1367459610-9656-1-git-send-email-konrad.wilk@oracle.com \
--to=konrad.wilk@oracle.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pavel@ucw.cz \
--cc=rjw@sisk.pl \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).