Re: [PATCH] thermal: cut the spaces when user sets policy

[Andy Shevchenko <andriy.shevchenko@linux.intel.com>]

On Fri, 2013-05-03 at 11:33 -0400, Eduardo Valentin wrote: 
> On 03-05-2013 09:52, Andy Shevchenko wrote:
> > Setting policy results in invalid value error.
> > 	% echo "step_wise" > policy
> > 	% echo: write error: Invalid argument
> > 
> > Need clean up of the buffer which "echo" may add based on the arguments, before
> > comparing aganist list of governor names.

> > @@ -716,7 +717,7 @@ policy_store(struct device *dev, struct device_attribute *attr,
> >  
> >  	mutex_lock(&thermal_governor_lock);
> >  
> > -	gov = __find_governor(buf);
> > +	gov = __find_governor(strim(buf));
> 
> I am much happier with this approach, much cleaner and does the job. On
> the other hand, this patch introduces a compilation warning that we want
> to avoid:
> drivers/thermal/thermal_sys.c: In function 'policy_store':
> drivers/thermal/thermal_sys.c:708: warning: passing argument 1 of
> 'strim' discards qualifiers from pointer target type
> include/linux/string.h:63: note: expected 'char *' but argument is of
> type 'const char *'
> 

Oops.
What about introduce temporary variable and pass it as a parameter?
It seems explicit casting looks not good, though it makes the job.


-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy