From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zhang Rui Subject: Re: [PATCH V2 01/20] thermal: exynos: Moving exynos thermal files into samsung directory Date: Mon, 06 May 2013 23:05:06 +0800 Message-ID: <1367852706.2079.57.camel@rzhang1-mobl4> References: <1366972671-9227-1-git-send-email-amit.daniel@samsung.com> <1366972671-9227-2-git-send-email-amit.daniel@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from mga02.intel.com ([134.134.136.20]:28225 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753997Ab3EFPFm (ORCPT ); Mon, 6 May 2013 11:05:42 -0400 In-Reply-To: <1366972671-9227-2-git-send-email-amit.daniel@samsung.com> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Amit Daniel Kachhap Cc: linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, amit.kachhap@gmail.com, Kukjin Kim , Eduardo Valentin On Fri, 2013-04-26 at 16:07 +0530, Amit Daniel Kachhap wrote: > This movement of files is done for easy maintenance and adding more > new sensor's support for exynos platform easily . This will also help in > bifurcating exynos common, sensor driver and sensor data related parts. > > Acked-by: Kukjin Kim > Signed-off-by: Amit Daniel Kachhap > --- > drivers/thermal/Kconfig | 13 +++++-------- > drivers/thermal/Makefile | 2 +- > drivers/thermal/samsung/Kconfig | 9 +++++++++ > drivers/thermal/samsung/Makefile | 4 ++++ > drivers/thermal/{ => samsung}/exynos_thermal.c | 0 > 5 files changed, 19 insertions(+), 9 deletions(-) > create mode 100644 drivers/thermal/samsung/Kconfig > create mode 100644 drivers/thermal/samsung/Makefile > rename drivers/thermal/{ => samsung}/exynos_thermal.c (100%) > > diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig > index 5e3c025..081ddc5 100644 > --- a/drivers/thermal/Kconfig > +++ b/drivers/thermal/Kconfig > @@ -114,14 +114,6 @@ config KIRKWOOD_THERMAL > Support for the Kirkwood thermal sensor driver into the Linux thermal > framework. Only kirkwood 88F6282 and 88F6283 have this sensor. > > -config EXYNOS_THERMAL > - tristate "Temperature sensor on Samsung EXYNOS" > - depends on (ARCH_EXYNOS4 || ARCH_EXYNOS5) > - depends on CPU_THERMAL > - help > - If you say yes here you get support for TMU (Thermal Management > - Unit) on SAMSUNG EXYNOS series of SoC. > - > config DOVE_THERMAL > tristate "Temperature sensor on Marvell Dove SoCs" > depends on ARCH_DOVE > @@ -169,4 +161,9 @@ config INTEL_POWERCLAMP > enforce idle time which results in more package C-state residency. The > user interface is exposed via generic thermal framework. > > +menu "Exynos thermal drivers" would it be more proper to use "Samsung thermal drivers" or "Samsung Exynos thermal drivers" instead? > +depends on PLAT_SAMSUNG > +source "drivers/thermal/samsung/Kconfig" > +endmenu > + sorry I know few about arm, could you tell me the difference between CONFIG_ARCH_EXYNOS4/CONFIG_ARCH_EXYNOS5 and CONFIG_PLAT_SAMSUNG please, I do not see the dependency between these in Kconfig file? thanks, rui > endif > diff --git a/drivers/thermal/Makefile b/drivers/thermal/Makefile > index c054d41..b3063a9 100644 > --- a/drivers/thermal/Makefile > +++ b/drivers/thermal/Makefile > @@ -17,7 +17,7 @@ thermal_sys-$(CONFIG_CPU_THERMAL) += cpu_cooling.o > obj-$(CONFIG_SPEAR_THERMAL) += spear_thermal.o > obj-$(CONFIG_RCAR_THERMAL) += rcar_thermal.o > obj-$(CONFIG_KIRKWOOD_THERMAL) += kirkwood_thermal.o > -obj-$(CONFIG_EXYNOS_THERMAL) += exynos_thermal.o > +obj-y += samsung/ > obj-$(CONFIG_DOVE_THERMAL) += dove_thermal.o > obj-$(CONFIG_DB8500_THERMAL) += db8500_thermal.o > obj-$(CONFIG_ARMADA_THERMAL) += armada_thermal.o > diff --git a/drivers/thermal/samsung/Kconfig b/drivers/thermal/samsung/Kconfig > new file mode 100644 > index 0000000..2d3d9dc > --- /dev/null > +++ b/drivers/thermal/samsung/Kconfig > @@ -0,0 +1,9 @@ > +config EXYNOS_THERMAL > + tristate "Temperature sensor on Samsung EXYNOS" > + depends on (ARCH_EXYNOS4 || ARCH_EXYNOS5) > + depends on CPU_THERMAL > + help > + If you say yes here you get support for TMU (Thermal Management > + Unit) on SAMSUNG EXYNOS series of SoC. This helps in registering > + the exynos thermal driver with the core thermal layer and cpu > + cooling API's. > diff --git a/drivers/thermal/samsung/Makefile b/drivers/thermal/samsung/Makefile > new file mode 100644 > index 0000000..1fe6d93 > --- /dev/null > +++ b/drivers/thermal/samsung/Makefile > @@ -0,0 +1,4 @@ > +# > +# Samsung thermal specific Makefile > +# > +obj-$(CONFIG_EXYNOS_THERMAL) += exynos_thermal.o > diff --git a/drivers/thermal/exynos_thermal.c b/drivers/thermal/samsung/exynos_thermal.c > similarity index 100% > rename from drivers/thermal/exynos_thermal.c > rename to drivers/thermal/samsung/exynos_thermal.c