* [PATCH 1/2] thermal: introduce TI SoC thermal driver
2013-05-15 15:45 [PATCH 0/2] staging -> thermal: move ti-soc-thermal to drivers/thermal Eduardo Valentin
@ 2013-05-15 15:46 ` Eduardo Valentin
2013-05-15 15:46 ` [PATCH 2/2] MAINTAINERS: update TI SoC thermal driver entry Eduardo Valentin
` (2 subsequent siblings)
3 siblings, 0 replies; 7+ messages in thread
From: Eduardo Valentin @ 2013-05-15 15:46 UTC (permalink / raw)
To: gregkh, rui.zhang
Cc: linux-pm, linux-kernel, devel, Eduardo Valentin, Grant Likely,
Rob Herring, Rob Landley, J Keerthy, Radhesh Fadnis,
Cyril Roelandt, devicetree-discuss, linux-doc
This patch moves the ti-soc-thermal driver out of
the staging tree to the thermal tree.
Cc: Grant Likely <grant.likely@linaro.org>
Cc: Rob Herring <rob.herring@calxeda.com>
Cc: Rob Landley <rob@landley.net>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Zhang Rui <rui.zhang@intel.com>
Cc: Eduardo Valentin <eduardo.valentin@ti.com>
Cc: J Keerthy <j-keerthy@ti.com>
Cc: Radhesh Fadnis <radhesh.fadnis@ti.com>
Cc: Cyril Roelandt <tipecaml@gmail.com>
Cc: devicetree-discuss@lists.ozlabs.org
Cc: linux-doc@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: devel@driverdev.osuosl.org
Cc: linux-pm@vger.kernel.org
Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com>
---
.../devicetree/bindings/thermal}/ti_soc_thermal.txt | 0
drivers/staging/Kconfig | 2 --
drivers/staging/Makefile | 1 -
drivers/thermal/Kconfig | 3 +++
drivers/thermal/Makefile | 2 +-
drivers/{staging => thermal}/ti-soc-thermal/Kconfig | 0
drivers/{staging => thermal}/ti-soc-thermal/Makefile | 0
drivers/{staging => thermal}/ti-soc-thermal/TODO | 0
drivers/{staging => thermal}/ti-soc-thermal/omap4-thermal-data.c | 0
drivers/{staging => thermal}/ti-soc-thermal/omap4xxx-bandgap.h | 0
drivers/{staging => thermal}/ti-soc-thermal/omap5-thermal-data.c | 0
drivers/{staging => thermal}/ti-soc-thermal/omap5xxx-bandgap.h | 0
drivers/{staging => thermal}/ti-soc-thermal/ti-bandgap.c | 0
drivers/{staging => thermal}/ti-soc-thermal/ti-bandgap.h | 0
drivers/{staging => thermal}/ti-soc-thermal/ti-thermal-common.c | 0
drivers/{staging => thermal}/ti-soc-thermal/ti-thermal.h | 0
16 files changed, 4 insertions(+), 4 deletions(-)
rename {drivers/staging/ti-soc-thermal => Documentation/devicetree/bindings/thermal}/ti_soc_thermal.txt (100%)
rename drivers/{staging => thermal}/ti-soc-thermal/Kconfig (100%)
rename drivers/{staging => thermal}/ti-soc-thermal/Makefile (100%)
rename drivers/{staging => thermal}/ti-soc-thermal/TODO (100%)
rename drivers/{staging => thermal}/ti-soc-thermal/omap4-thermal-data.c (100%)
rename drivers/{staging => thermal}/ti-soc-thermal/omap4xxx-bandgap.h (100%)
rename drivers/{staging => thermal}/ti-soc-thermal/omap5-thermal-data.c (100%)
rename drivers/{staging => thermal}/ti-soc-thermal/omap5xxx-bandgap.h (100%)
rename drivers/{staging => thermal}/ti-soc-thermal/ti-bandgap.c (100%)
rename drivers/{staging => thermal}/ti-soc-thermal/ti-bandgap.h (100%)
rename drivers/{staging => thermal}/ti-soc-thermal/ti-thermal-common.c (100%)
rename drivers/{staging => thermal}/ti-soc-thermal/ti-thermal.h (100%)
diff --git a/drivers/staging/ti-soc-thermal/ti_soc_thermal.txt b/Documentation/devicetree/bindings/thermal/ti_soc_thermal.txt
similarity index 100%
rename from drivers/staging/ti-soc-thermal/ti_soc_thermal.txt
rename to Documentation/devicetree/bindings/thermal/ti_soc_thermal.txt
diff --git a/drivers/staging/Kconfig b/drivers/staging/Kconfig
index c39fe78..e0b3495 100644
--- a/drivers/staging/Kconfig
+++ b/drivers/staging/Kconfig
@@ -118,8 +118,6 @@ source "drivers/staging/gdm72xx/Kconfig"
source "drivers/staging/csr/Kconfig"
-source "drivers/staging/ti-soc-thermal/Kconfig"
-
source "drivers/staging/silicom/Kconfig"
source "drivers/staging/ced1401/Kconfig"
diff --git a/drivers/staging/Makefile b/drivers/staging/Makefile
index 110c597..8b3d86e 100644
--- a/drivers/staging/Makefile
+++ b/drivers/staging/Makefile
@@ -52,7 +52,6 @@ obj-$(CONFIG_ANDROID) += android/
obj-$(CONFIG_USB_WPAN_HCD) += ozwpan/
obj-$(CONFIG_WIMAX_GDM72XX) += gdm72xx/
obj-$(CONFIG_CSR_WIFI) += csr/
-obj-$(CONFIG_TI_SOC_THERMAL) += ti-soc-thermal/
obj-$(CONFIG_NET_VENDOR_SILICOM) += silicom/
obj-$(CONFIG_CED1401) += ced1401/
obj-$(CONFIG_DRM_IMX) += imx-drm/
diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
index 5e3c025..7205c70 100644
--- a/drivers/thermal/Kconfig
+++ b/drivers/thermal/Kconfig
@@ -169,4 +169,7 @@ config INTEL_POWERCLAMP
enforce idle time which results in more package C-state residency. The
user interface is exposed via generic thermal framework.
+menu "Texas Instruments thermal drivers"
+source "drivers/thermal/ti-soc-thermal/Kconfig"
+endmenu
endif
diff --git a/drivers/thermal/Makefile b/drivers/thermal/Makefile
index c054d41..8569394 100644
--- a/drivers/thermal/Makefile
+++ b/drivers/thermal/Makefile
@@ -23,4 +23,4 @@ obj-$(CONFIG_DB8500_THERMAL) += db8500_thermal.o
obj-$(CONFIG_ARMADA_THERMAL) += armada_thermal.o
obj-$(CONFIG_DB8500_CPUFREQ_COOLING) += db8500_cpufreq_cooling.o
obj-$(CONFIG_INTEL_POWERCLAMP) += intel_powerclamp.o
-
+obj-$(CONFIG_TI_SOC_THERMAL) += ti-soc-thermal/
diff --git a/drivers/staging/ti-soc-thermal/Kconfig b/drivers/thermal/ti-soc-thermal/Kconfig
similarity index 100%
rename from drivers/staging/ti-soc-thermal/Kconfig
rename to drivers/thermal/ti-soc-thermal/Kconfig
diff --git a/drivers/staging/ti-soc-thermal/Makefile b/drivers/thermal/ti-soc-thermal/Makefile
similarity index 100%
rename from drivers/staging/ti-soc-thermal/Makefile
rename to drivers/thermal/ti-soc-thermal/Makefile
diff --git a/drivers/staging/ti-soc-thermal/TODO b/drivers/thermal/ti-soc-thermal/TODO
similarity index 100%
rename from drivers/staging/ti-soc-thermal/TODO
rename to drivers/thermal/ti-soc-thermal/TODO
diff --git a/drivers/staging/ti-soc-thermal/omap4-thermal-data.c b/drivers/thermal/ti-soc-thermal/omap4-thermal-data.c
similarity index 100%
rename from drivers/staging/ti-soc-thermal/omap4-thermal-data.c
rename to drivers/thermal/ti-soc-thermal/omap4-thermal-data.c
diff --git a/drivers/staging/ti-soc-thermal/omap4xxx-bandgap.h b/drivers/thermal/ti-soc-thermal/omap4xxx-bandgap.h
similarity index 100%
rename from drivers/staging/ti-soc-thermal/omap4xxx-bandgap.h
rename to drivers/thermal/ti-soc-thermal/omap4xxx-bandgap.h
diff --git a/drivers/staging/ti-soc-thermal/omap5-thermal-data.c b/drivers/thermal/ti-soc-thermal/omap5-thermal-data.c
similarity index 100%
rename from drivers/staging/ti-soc-thermal/omap5-thermal-data.c
rename to drivers/thermal/ti-soc-thermal/omap5-thermal-data.c
diff --git a/drivers/staging/ti-soc-thermal/omap5xxx-bandgap.h b/drivers/thermal/ti-soc-thermal/omap5xxx-bandgap.h
similarity index 100%
rename from drivers/staging/ti-soc-thermal/omap5xxx-bandgap.h
rename to drivers/thermal/ti-soc-thermal/omap5xxx-bandgap.h
diff --git a/drivers/staging/ti-soc-thermal/ti-bandgap.c b/drivers/thermal/ti-soc-thermal/ti-bandgap.c
similarity index 100%
rename from drivers/staging/ti-soc-thermal/ti-bandgap.c
rename to drivers/thermal/ti-soc-thermal/ti-bandgap.c
diff --git a/drivers/staging/ti-soc-thermal/ti-bandgap.h b/drivers/thermal/ti-soc-thermal/ti-bandgap.h
similarity index 100%
rename from drivers/staging/ti-soc-thermal/ti-bandgap.h
rename to drivers/thermal/ti-soc-thermal/ti-bandgap.h
diff --git a/drivers/staging/ti-soc-thermal/ti-thermal-common.c b/drivers/thermal/ti-soc-thermal/ti-thermal-common.c
similarity index 100%
rename from drivers/staging/ti-soc-thermal/ti-thermal-common.c
rename to drivers/thermal/ti-soc-thermal/ti-thermal-common.c
diff --git a/drivers/staging/ti-soc-thermal/ti-thermal.h b/drivers/thermal/ti-soc-thermal/ti-thermal.h
similarity index 100%
rename from drivers/staging/ti-soc-thermal/ti-thermal.h
rename to drivers/thermal/ti-soc-thermal/ti-thermal.h
--
1.8.2.1.342.gfa7285d
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH 2/2] MAINTAINERS: update TI SoC thermal driver entry
2013-05-15 15:45 [PATCH 0/2] staging -> thermal: move ti-soc-thermal to drivers/thermal Eduardo Valentin
2013-05-15 15:46 ` [PATCH 1/2] thermal: introduce TI SoC thermal driver Eduardo Valentin
@ 2013-05-15 15:46 ` Eduardo Valentin
2013-05-21 17:03 ` [PATCH 0/2] staging -> thermal: move ti-soc-thermal to drivers/thermal Greg KH
2013-05-28 2:41 ` Zhang Rui
3 siblings, 0 replies; 7+ messages in thread
From: Eduardo Valentin @ 2013-05-15 15:46 UTC (permalink / raw)
To: gregkh, rui.zhang; +Cc: linux-pm, linux-kernel, devel, Eduardo Valentin
Update driver path and status for TI SoC thermal drivers
on MAINTAINERS file.
Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com>
---
MAINTAINERS | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index bc3d340..2b8a7c5 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -8056,8 +8056,8 @@ F: drivers/platform/x86/thinkpad_acpi.c
TI BANDGAP AND THERMAL DRIVER
M: Eduardo Valentin <eduardo.valentin@ti.com>
L: linux-pm@vger.kernel.org
-S: Maintained
-F: drivers/staging/omap-thermal/
+S: Supported
+F: drivers/thermal/ti-soc-thermal/
TI FLASH MEDIA INTERFACE DRIVER
M: Alex Dubov <oakad@yahoo.com>
--
1.8.2.1.342.gfa7285d
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 0/2] staging -> thermal: move ti-soc-thermal to drivers/thermal
2013-05-15 15:45 [PATCH 0/2] staging -> thermal: move ti-soc-thermal to drivers/thermal Eduardo Valentin
2013-05-15 15:46 ` [PATCH 1/2] thermal: introduce TI SoC thermal driver Eduardo Valentin
2013-05-15 15:46 ` [PATCH 2/2] MAINTAINERS: update TI SoC thermal driver entry Eduardo Valentin
@ 2013-05-21 17:03 ` Greg KH
2013-05-21 18:16 ` Eduardo Valentin
2013-05-28 2:41 ` Zhang Rui
3 siblings, 1 reply; 7+ messages in thread
From: Greg KH @ 2013-05-21 17:03 UTC (permalink / raw)
To: Eduardo Valentin; +Cc: rui.zhang, devel, linux-kernel, linux-pm
On Wed, May 15, 2013 at 11:45:59AM -0400, Eduardo Valentin wrote:
>
> Hello Greg and Rui,
>
> I am proposing to move the ti-soc-thermal driver from drivers/stating/
> to drivers/thermal. It has been some time that we have been fixing and
> improving the code under staging tree.
This is up to review from the thermal maintainer and developers to
accept this.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 0/2] staging -> thermal: move ti-soc-thermal to drivers/thermal
2013-05-21 17:03 ` [PATCH 0/2] staging -> thermal: move ti-soc-thermal to drivers/thermal Greg KH
@ 2013-05-21 18:16 ` Eduardo Valentin
0 siblings, 0 replies; 7+ messages in thread
From: Eduardo Valentin @ 2013-05-21 18:16 UTC (permalink / raw)
To: Greg KH; +Cc: Eduardo Valentin, rui.zhang, devel, linux-kernel, linux-pm
[-- Attachment #1: Type: text/plain, Size: 518 bytes --]
Hello Greg,
On 21-05-2013 13:03, Greg KH wrote:
> On Wed, May 15, 2013 at 11:45:59AM -0400, Eduardo Valentin wrote:
>>
>> Hello Greg and Rui,
>>
>> I am proposing to move the ti-soc-thermal driver from drivers/stating/
>> to drivers/thermal. It has been some time that we have been fixing and
>> improving the code under staging tree.
>
> This is up to review from the thermal maintainer and developers to
> accept this.
Thanks for your feedback.
Rui?
>
> thanks,
>
> greg k-h
>
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 295 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 0/2] staging -> thermal: move ti-soc-thermal to drivers/thermal
2013-05-15 15:45 [PATCH 0/2] staging -> thermal: move ti-soc-thermal to drivers/thermal Eduardo Valentin
` (2 preceding siblings ...)
2013-05-21 17:03 ` [PATCH 0/2] staging -> thermal: move ti-soc-thermal to drivers/thermal Greg KH
@ 2013-05-28 2:41 ` Zhang Rui
2013-05-28 14:30 ` Eduardo Valentin
3 siblings, 1 reply; 7+ messages in thread
From: Zhang Rui @ 2013-05-28 2:41 UTC (permalink / raw)
To: Eduardo Valentin; +Cc: gregkh, linux-pm, linux-kernel, devel
On Wed, 2013-05-15 at 11:45 -0400, Eduardo Valentin wrote:
> Hello Greg and Rui,
>
> I am proposing to move the ti-soc-thermal driver from drivers/stating/
> to drivers/thermal. It has been some time that we have been fixing and
> improving the code under staging tree.
>
> I believe it is time to move on. The driver now has a better code
> organization (split between code and data), DT support, better coding
> style, it supports TI OMAP chips 4430, 4460, 4470 and 5430, and it is
> ready for easy addition of other SoC chips containing the bandgap IP.
> Besides, this driver required some major changes in the thermal framework,
> before it could provide basic functionality using the device capability.
> These changes have been already merged in previous merge windows,
> so there is no pending dependencies.
>
> The remaining items in the TODO list are actually not a blocker for this
> move, IMO. The PM support is not fully completed on all supported OMAP chips.
> The locking so far has not caused any issues, and I believe that most of
> the interesting data is protected by the thermal framework.
>
> I am sending this patch for your appreciation and also to get wider review.
>
patch applied to thermal -next tree and targeted for 3.11.
thanks,
rui
> All best,
>
> Eduardo Valentin (2):
> thermal: introduce TI SoC thermal driver
> MAINTAINERS: update TI SoC thermal driver entry
>
> .../devicetree/bindings/thermal}/ti_soc_thermal.txt | 0
> MAINTAINERS | 4 ++--
> drivers/staging/Kconfig | 2 --
> drivers/staging/Makefile | 1 -
> drivers/thermal/Kconfig | 3 +++
> drivers/thermal/Makefile | 2 +-
> drivers/{staging => thermal}/ti-soc-thermal/Kconfig | 0
> drivers/{staging => thermal}/ti-soc-thermal/Makefile | 0
> drivers/{staging => thermal}/ti-soc-thermal/TODO | 0
> drivers/{staging => thermal}/ti-soc-thermal/omap4-thermal-data.c | 0
> drivers/{staging => thermal}/ti-soc-thermal/omap4xxx-bandgap.h | 0
> drivers/{staging => thermal}/ti-soc-thermal/omap5-thermal-data.c | 0
> drivers/{staging => thermal}/ti-soc-thermal/omap5xxx-bandgap.h | 0
> drivers/{staging => thermal}/ti-soc-thermal/ti-bandgap.c | 0
> drivers/{staging => thermal}/ti-soc-thermal/ti-bandgap.h | 0
> drivers/{staging => thermal}/ti-soc-thermal/ti-thermal-common.c | 0
> drivers/{staging => thermal}/ti-soc-thermal/ti-thermal.h | 0
> 17 files changed, 6 insertions(+), 6 deletions(-)
> rename {drivers/staging/ti-soc-thermal => Documentation/devicetree/bindings/thermal}/ti_soc_thermal.txt (100%)
> rename drivers/{staging => thermal}/ti-soc-thermal/Kconfig (100%)
> rename drivers/{staging => thermal}/ti-soc-thermal/Makefile (100%)
> rename drivers/{staging => thermal}/ti-soc-thermal/TODO (100%)
> rename drivers/{staging => thermal}/ti-soc-thermal/omap4-thermal-data.c (100%)
> rename drivers/{staging => thermal}/ti-soc-thermal/omap4xxx-bandgap.h (100%)
> rename drivers/{staging => thermal}/ti-soc-thermal/omap5-thermal-data.c (100%)
> rename drivers/{staging => thermal}/ti-soc-thermal/omap5xxx-bandgap.h (100%)
> rename drivers/{staging => thermal}/ti-soc-thermal/ti-bandgap.c (100%)
> rename drivers/{staging => thermal}/ti-soc-thermal/ti-bandgap.h (100%)
> rename drivers/{staging => thermal}/ti-soc-thermal/ti-thermal-common.c (100%)
> rename drivers/{staging => thermal}/ti-soc-thermal/ti-thermal.h (100%)
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH 0/2] staging -> thermal: move ti-soc-thermal to drivers/thermal
2013-05-28 2:41 ` Zhang Rui
@ 2013-05-28 14:30 ` Eduardo Valentin
0 siblings, 0 replies; 7+ messages in thread
From: Eduardo Valentin @ 2013-05-28 14:30 UTC (permalink / raw)
To: Zhang Rui; +Cc: Eduardo Valentin, gregkh, linux-pm, linux-kernel, devel
[-- Attachment #1: Type: text/plain, Size: 4279 bytes --]
On 27-05-2013 22:41, Zhang Rui wrote:
> On Wed, 2013-05-15 at 11:45 -0400, Eduardo Valentin wrote:
>> Hello Greg and Rui,
>>
>> I am proposing to move the ti-soc-thermal driver from drivers/stating/
>> to drivers/thermal. It has been some time that we have been fixing and
>> improving the code under staging tree.
>>
>> I believe it is time to move on. The driver now has a better code
>> organization (split between code and data), DT support, better coding
>> style, it supports TI OMAP chips 4430, 4460, 4470 and 5430, and it is
>> ready for easy addition of other SoC chips containing the bandgap IP.
>> Besides, this driver required some major changes in the thermal framework,
>> before it could provide basic functionality using the device capability.
>> These changes have been already merged in previous merge windows,
>> so there is no pending dependencies.
>>
>> The remaining items in the TODO list are actually not a blocker for this
>> move, IMO. The PM support is not fully completed on all supported OMAP chips.
>> The locking so far has not caused any issues, and I believe that most of
>> the interesting data is protected by the thermal framework.
>>
>> I am sending this patch for your appreciation and also to get wider review.
>>
>
> patch applied to thermal -next tree and targeted for 3.11.
Thanks Rui,
I am going to send the usual ti soc thermal fixes patch set to you now.
I ve been sending it anyway to linux-pm. Only thing is that it should go
via your tree now.
Next set should contain some fixes identified during internal testing.
>
> thanks,
> rui
>> All best,
>>
>> Eduardo Valentin (2):
>> thermal: introduce TI SoC thermal driver
>> MAINTAINERS: update TI SoC thermal driver entry
>>
>> .../devicetree/bindings/thermal}/ti_soc_thermal.txt | 0
>> MAINTAINERS | 4 ++--
>> drivers/staging/Kconfig | 2 --
>> drivers/staging/Makefile | 1 -
>> drivers/thermal/Kconfig | 3 +++
>> drivers/thermal/Makefile | 2 +-
>> drivers/{staging => thermal}/ti-soc-thermal/Kconfig | 0
>> drivers/{staging => thermal}/ti-soc-thermal/Makefile | 0
>> drivers/{staging => thermal}/ti-soc-thermal/TODO | 0
>> drivers/{staging => thermal}/ti-soc-thermal/omap4-thermal-data.c | 0
>> drivers/{staging => thermal}/ti-soc-thermal/omap4xxx-bandgap.h | 0
>> drivers/{staging => thermal}/ti-soc-thermal/omap5-thermal-data.c | 0
>> drivers/{staging => thermal}/ti-soc-thermal/omap5xxx-bandgap.h | 0
>> drivers/{staging => thermal}/ti-soc-thermal/ti-bandgap.c | 0
>> drivers/{staging => thermal}/ti-soc-thermal/ti-bandgap.h | 0
>> drivers/{staging => thermal}/ti-soc-thermal/ti-thermal-common.c | 0
>> drivers/{staging => thermal}/ti-soc-thermal/ti-thermal.h | 0
>> 17 files changed, 6 insertions(+), 6 deletions(-)
>> rename {drivers/staging/ti-soc-thermal => Documentation/devicetree/bindings/thermal}/ti_soc_thermal.txt (100%)
>> rename drivers/{staging => thermal}/ti-soc-thermal/Kconfig (100%)
>> rename drivers/{staging => thermal}/ti-soc-thermal/Makefile (100%)
>> rename drivers/{staging => thermal}/ti-soc-thermal/TODO (100%)
>> rename drivers/{staging => thermal}/ti-soc-thermal/omap4-thermal-data.c (100%)
>> rename drivers/{staging => thermal}/ti-soc-thermal/omap4xxx-bandgap.h (100%)
>> rename drivers/{staging => thermal}/ti-soc-thermal/omap5-thermal-data.c (100%)
>> rename drivers/{staging => thermal}/ti-soc-thermal/omap5xxx-bandgap.h (100%)
>> rename drivers/{staging => thermal}/ti-soc-thermal/ti-bandgap.c (100%)
>> rename drivers/{staging => thermal}/ti-soc-thermal/ti-bandgap.h (100%)
>> rename drivers/{staging => thermal}/ti-soc-thermal/ti-thermal-common.c (100%)
>> rename drivers/{staging => thermal}/ti-soc-thermal/ti-thermal.h (100%)
>>
>
>
>
>
--
You have got to be excited about what you are doing. (L. Lamport)
Eduardo Valentin
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 295 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread