From: Yanmin Zhang <yanmin_zhang@linux.intel.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: shuox.liu@intel.com, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, pavel@ucw.cz, rjw@sisk.pl,
len.brown@intel.com, Zhang Yanmin <yanmin.zhang@intel.com>
Subject: Re: [PATCH 1/2] PM: use dpm_run_callback in device_prepare
Date: Sat, 08 Jun 2013 09:21:52 +0800 [thread overview]
Message-ID: <1370654512.4432.79.camel@ymzhang.sh.intel.com> (raw)
In-Reply-To: <20130608011518.GA2819@kroah.com>
On Fri, 2013-06-07 at 18:15 -0700, Greg KH wrote:
> On Sat, Jun 08, 2013 at 08:43:55AM +0800, Yanmin Zhang wrote:
> > On Fri, 2013-06-07 at 10:37 -0700, Greg KH wrote:
> > > On Fri, Jun 07, 2013 at 04:20:31PM +0800, shuox.liu@intel.com wrote:
> > > > From: ShuoX Liu <shuox.liu@intel.com>
> > > >
> > > > dpm_run_callback could show more debug info around prepare stage.
> > >
> > > Why? Who needs this? What problem does it solve?
> > >
> > > Without answers to this, why would you expect us to accept such a
> > > change?
> > It's to provide more debug info and developers can quickly find what
> > prepare/complete callback consumes too much time.
>
> What exact debug info is this providing, and why wouldn't you say all of
> this in the original changelog information?
Thanks for the reminder.
Below are examples, after applying the patches. We can see clearly
how much time every device prepare callback consumes.
[ 600.384779] sr 1:0:0:0: preparing bus suspend
[ 600.384780] call 1:0:0:0+ returned 0 after 2 usecs
[ 600.384785] calling 2-1+ @ 2556, parent: usb2
[ 600.384788] usb 2-1: preparing type suspend
[ 600.384789] call 2-1+ returned 0 after 2 usecs
[ 600.384794] calling 1-1.1+ @ 2556, parent: 1-1
[ 600.384797] usb 1-1.1: preparing type suspend
[ 600.384799] call 1-1.1+ returned 0 after 2 usecs
[ 600.384802] calling 1-1.3+ @ 2556, parent: 1-1
[ 600.384804] usb 1-1.3: preparing type suspend
[ 600.384805] call 1-1.3+ returned 0 after 2 usecs
[ 600.384809] calling 1-1.4+ @ 2556, parent: 1-1
[ 600.384811] usb 1-1.4: preparing type suspend
[ 600.384813] call 1-1.4+ returned 0 after 2 usecs
[ 600.384816] calling 1-1.5+ @ 2556, parent: 1-1
[ 600.384819] usb 1-1.5: preparing type suspend, may wakeup
[ 600.384820] call 1-1.5+ returned 0 after 2 usecs
[ 600.384823] calling 1-1.4.1+ @ 2556, parent: 1-1.4
[ 600.384825] usb 1-1.4.1: preparing type suspend
[ 600.384827] call 1-1.4.1+ returned 0 after 2 usecs
[ 600.384829] calling 1-1.4.2+ @ 2556, parent: 1-1.4
[ 600.384831] usb 1-1.4.2: preparing type suspend
[ 600.384833] call 1-1.4.2+ returned 0 after 2 usecs
[ 600.384865] PM: prepare suspend of devices complete after 0.471 msecs
next prev parent reply other threads:[~2013-06-08 1:19 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-07 8:20 [PATCH 0/2] Run callback of device_prepare/complete consistently shuox.liu
2013-06-07 8:20 ` [PATCH 1/2] PM: use dpm_run_callback in device_prepare shuox.liu
2013-06-07 17:37 ` Greg KH
2013-06-08 0:43 ` Yanmin Zhang
2013-06-08 1:15 ` Greg KH
2013-06-08 1:21 ` Yanmin Zhang [this message]
2013-06-07 8:20 ` [PATCH 2/2] PM: add dpm_run_callback_void and use it in device_complete shuox.liu
2013-06-07 17:38 ` Greg KH
2013-06-07 10:36 ` [PATCH 0/2] Run callback of device_prepare/complete consistently Rafael J. Wysocki
2013-06-08 0:42 ` Yanmin Zhang
2013-06-08 0:54 ` Rafael J. Wysocki
2013-06-08 1:17 ` Yanmin Zhang
2013-06-08 1:25 ` Rafael J. Wysocki
2013-06-08 1:16 ` Greg KH
2013-06-08 1:30 ` Rafael J. Wysocki
2013-06-08 1:36 ` Yanmin Zhang
2013-06-08 1:52 ` Rafael J. Wysocki
2013-06-08 2:37 ` Yanmin Zhang
2013-06-08 10:54 ` Rafael J. Wysocki
2013-06-09 8:11 ` ShuoX Liu
2013-06-08 1:30 ` Yanmin Zhang
2013-06-10 11:50 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1370654512.4432.79.camel@ymzhang.sh.intel.com \
--to=yanmin_zhang@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rjw@sisk.pl \
--cc=shuox.liu@intel.com \
--cc=yanmin.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).