linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Zhang Rui <rui.zhang@intel.com>
To: linux-pm@vger.kernel.org
Cc: eduardo.valentin@ti.com, durgadoss.r@intel.com,
	shawn.guo@linaro.org, ruslan.ruslichenko@ti.com,
	Zhang Rui <rui.zhang@intel.com>
Subject: [RFC PATCH 4/6] Thermal: fix step_wise handling of THERMAL_TREND_DROP_EFULL
Date: Mon, 17 Jun 2013 21:24:26 +0800	[thread overview]
Message-ID: <1371475468-5351-5-git-send-email-rui.zhang@intel.com> (raw)
In-Reply-To: <1371475468-5351-1-git-send-email-rui.zhang@intel.com>

Change the step_wise cooling algorithm to handle
THERMAL_TREND_DROP_FULL a bit differently.

When the temperature is higher than the trip point,
we should always use the instance->lower as the next target state.
When the temperature is lower than the trip point,
we should always deactive the thermal instance.

Signed-off-by: Zhang Rui <rui.zhang@intel.com>
---
 drivers/thermal/step_wise.c |   12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/drivers/thermal/step_wise.c b/drivers/thermal/step_wise.c
index f0cc5e5..84d6e90 100644
--- a/drivers/thermal/step_wise.c
+++ b/drivers/thermal/step_wise.c
@@ -42,9 +42,8 @@
  *       state for this trip point, if the cooling state already
  *       equals lower limit, deactivate the thermal instance
  *    c. if the trend is THERMAL_TREND_RAISE_FULL, do nothing
- *    d. if the trend is THERMAL_TREND_DROP_FULL, use lower limit,
- *       if the cooling state already equals lower limit,
- *       deactive the thermal instance
+ *    d. if the trend is THERMAL_TREND_DROP_FULL, deactive
+ *	 the thermal instance
  */
 static unsigned long get_target_state(struct thermal_instance *instance,
 				enum thermal_trend trend, bool throttle)
@@ -91,11 +90,10 @@ static unsigned long get_target_state(struct thermal_instance *instance,
 		}
 		break;
 	case THERMAL_TREND_DROP_FULL:
-		if (cur_state == instance->lower) {
-			if (!throttle)
-				next_target = THERMAL_NO_TARGET;
-		} else
+		if (throttle)
 			next_target = instance->lower;
+		else
+			next_target = THERMAL_NO_TARGET;
 		break;
 	default:
 		break;
-- 
1.7.9.5


  parent reply	other threads:[~2013-06-17 13:24 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-17 13:24 [RFC PATCH 0/6] Thermal: step_wise governor fixes Zhang Rui
2013-06-17 13:24 ` [RFC PATCH 1/6] thermal: step_wise: cdev only needs update on a new target state Zhang Rui
2013-06-17 13:24 ` [RFC PATCH 2/6] thermal: step_wise: return instance->target by default Zhang Rui
2013-06-17 13:24 ` [RFC PATCH 3/6] Thermal: fix step_wise handling of THERMAL_TREND_DROPPING Zhang Rui
2013-07-02 20:57   ` Eduardo Valentin
2013-07-08  2:32     ` Zhang Rui
2013-06-17 13:24 ` Zhang Rui [this message]
2013-07-02 21:11   ` [RFC PATCH 4/6] Thermal: fix step_wise handling of THERMAL_TREND_DROP_EFULL Eduardo Valentin
2013-07-08  2:35     ` Zhang Rui
2013-06-17 13:24 ` [RFC PATCH 5/6] Thermal: step_wise handle THERMAL_TREND_STABLE explicitly Zhang Rui
2013-06-17 13:24 ` [RFC PATCH 6/6] Thermal: step_wise: set next cooling target explicitly Zhang Rui
2013-07-02 21:03   ` Eduardo Valentin
2013-07-08  2:34     ` Zhang Rui
2013-07-02 21:05   ` Eduardo Valentin
2013-06-18  3:45 ` [RFC PATCH 0/6] Thermal: step_wise governor fixes Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1371475468-5351-5-git-send-email-rui.zhang@intel.com \
    --to=rui.zhang@intel.com \
    --cc=durgadoss.r@intel.com \
    --cc=eduardo.valentin@ti.com \
    --cc=linux-pm@vger.kernel.org \
    --cc=ruslan.ruslichenko@ti.com \
    --cc=shawn.guo@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).