linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Zhang Rui <rui.zhang@intel.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Randy Dunlap <rdunlap@infradead.org>,
	Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
	Linux PM list <linux-pm@vger.kernel.org>
Subject: Re: [PATCH -next v3] thermal:  fix x86_pkg_temp_thermal.c build and Kconfig
Date: Tue, 18 Jun 2013 07:28:44 +0800	[thread overview]
Message-ID: <1371511724.22538.1.camel@rzhang1-mobl4> (raw)
In-Reply-To: <20130617194524.GD8197@pd.tnic>

On Mon, 2013-06-17 at 21:45 +0200, Borislav Petkov wrote:
> On Mon, Jun 17, 2013 at 12:27:17PM -0700, Randy Dunlap wrote:
> > From: Randy Dunlap <rdunlap@infradead.org>
> > 
> > Fix build error in x86_pkg_temp_thermal.c.  It requires that
> > X86_MCE & X86_THERMAL_VECTOR be enabled, so depend on the latter symbol,
> > since it depends on X86_MCE (indirectly).
> > 
> > Also, X86_PKG_TEMP_THERMAL is already inside an "if THERMAL" block,
> > so remove that duplicated dependency.
> > 
> > ERROR: "platform_thermal_package_rate_control" [drivers/thermal/x86_pkg_temp_thermal.ko] undefined!
> > ERROR: "platform_thermal_package_notify" [drivers/thermal/x86_pkg_temp_thermal.ko] undefined!
> > 
> > Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> > ---
> >  drivers/thermal/Kconfig |    3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > --- linux-next-20130617.orig/drivers/thermal/Kconfig
> > +++ linux-next-20130617/drivers/thermal/Kconfig
> > @@ -171,8 +171,7 @@ config INTEL_POWERCLAMP
> >  
> >  config X86_PKG_TEMP_THERMAL
> >  	tristate "X86 package temperature thermal driver"
> > -	depends on THERMAL
> > -	depends on X86
> > +	depends on X86_THERMAL_VECTOR
> >  	select THERMAL_GOV_USER_SPACE
> >  	default m
> >  	help
> 
> Acked-by: Borislav Petkov <bp@suse.de>
> 
applied to thermal -next.

thanks,
rui

      reply	other threads:[~2013-06-17 23:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20130617185106.5950ffbf4b96acd9b2b2c834@canb.auug.org.au>
     [not found] ` <51BF4159.1000004@infradead.org>
     [not found]   ` <51BF46C3.3090900@linux.intel.com>
2013-06-17 17:55     ` [PATCH -next] thermal: fix x86_pkg_temp_thermal.c build and Kconfig Randy Dunlap
2013-06-17 18:09       ` Srinivas Pandruvada
2013-06-17 18:12         ` [PATCH -next v2] " Randy Dunlap
2013-06-17 18:17           ` Borislav Petkov
2013-06-17 18:31             ` Srinivas Pandruvada
2013-06-17 19:27             ` [PATCH -next v3] " Randy Dunlap
2013-06-17 19:45               ` Borislav Petkov
2013-06-17 23:28                 ` Zhang Rui [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1371511724.22538.1.camel@rzhang1-mobl4 \
    --to=rui.zhang@intel.com \
    --cc=bp@alien8.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=sfr@canb.auug.org.au \
    --cc=srinivas.pandruvada@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).