Re: [regression,bisected] restore of disks after suspend-to-disk broken in 3.9.x

[Zhang Rui <rui.zhang@intel.com>]

On Fri, 2013-06-21 at 11:51 +0200, Giacomo Perale wrote:
> 2013/6/21 Zhang Rui <rui.zhang@intel.com>:
> > On Wed, 2013-06-05 at 13:23 +0000, Zhang, Rui wrote:
> >>
> >> > -----Original Message-----
> >> > From: Giacomo Perale [mailto:giacomo.perale@gmail.com]
> >> > Sent: Wednesday, June 05, 2013 5:09 PM
> >> > To: Zhang, Rui
> >> > Cc: linux-acpi@vger.kernel.org; linux-pm@vger.kernel.org; Rafael J.
> >> > Wysocki
> >> > Subject: Re: [regression,bisected] restore of disks after suspend-to-
> >> > disk broken in 3.9.x
> >> > Importance: High
> >> >
> >> > 2013/5/30 Giacomo Perale <giacomo.perale@gmail.com>:
> >> > > 2013/5/30 Zhang Rui <rui.zhang@intel.com>:
> >> > >> On Thu, 2013-05-30 at 10:04 +0200, Giacomo Perale wrote:
> >> > >>> 2013/5/30 Zhang Rui <rui.zhang@intel.com>:
> >> > >>> > On Mon, 2013-05-27 at 22:07 +0200, Giacomo Perale wrote:
> >> > >>> >> 2013/5/27 Zhang Rui <rui.zhang@intel.com>:
> >> > >>> >> > On Sun, 2013-05-26 at 15:51 +0200, Giacomo Perale wrote:
> >> > >>> >> >> Hello,
> >> > >>> >> >>
> >> > >>> >> >> after upgrading from 3.8.7 to 3.9.x I noticed some slightly
> >> > >>> >> >> longer delays when resuming from suspend-to-disk and a few
> >> > new
> >> > >>> >> >> error messages in the logs:
> >> > >>> >> >>
> >> > >>> >> >>
> >> > >>> >> >> Not having connected the issue with the previous error
> >> > >>> >> >> messages I initially blamed the disk and replaced it with a
> >> > >>> >> >> new one thinking it was broken, but the problem persisted so
> >> > I
> >> > >>> >> >> started a bisection run that pointed to this commit:
> >> > >>> >> >>
> >> > >>> >> >>
> >> > >>> >> > I do not see how this would affect the sata hibernation/resume.
> >> > >>> >> > but anyway, would you please try the four patches in comment
> >> > >>> >> > #10, #11,
> >> > >>> >> > #12 and #13 in
> >> > >>> >> > https://bugzilla.kernel.org/show_bug.cgi?id=58301
> >> > >>> >> > and check if they help?
> >> > >>> >> >
> >> > >>> >> > thanks,
> >> > >>> >> > rui
> >> > >>> >> >
> >> > >>> >>
> >> > >>> >> No luck, with git head and those four patches hibernation is
> >> > >>> >> completely broken, the system doesn't even shut down, it just
> >> > >>> >> loses the disks (I'm attaching what I could get from /proc/kmsg
> >> > >>> >> to this email).
> >> > >>> >>
> >> > >>> > then can you please try the patch at
> >> > >>> > https://patchwork.kernel.org/patch/2633071/
> >> > >>> > on top of the four patches and see if it helps?
> >> > >>> >
> >> > >>> > thanks,
> >> > >>> > rui
> >> > >>> >
> >> > >>>
> >> > >>> Do you mean without Rafael's patch?
> >> > >>>
> >> > >> right.
> >> > >>
> >> > >> thanks,
> >> > >> rui
> >> > >
> >> > > [cc-ing list]
> >> > >
> >> > > No difference, system doesn't shut down and disks become unavailable.
> >> > >
> >> > > Giacomo
> >> >
> >> > Any news about this?
> >> >
> >>
> >> I'm proposing a new patch set based on the problem found by Rafael's patch.
> >> And I'll send them out in a day or two, please wait for the update. :)
> >>
> > sorry for the late response.
> >
> > can you please check if the patch series at
> > https://patchwork.kernel.org/patch/2733361/
> > https://patchwork.kernel.org/patch/2733371/
> > https://patchwork.kernel.org/patch/2733391/
> > https://patchwork.kernel.org/patch/2733401/
> > https://patchwork.kernel.org/patch/2733411/
> > https://patchwork.kernel.org/patch/2733421/
> > helps or not?
> >
> > thanks,
> > rui
> >
> >> Thanks,
> >> rui
> >>
> >>
> >> > Thanks.
> 
> Are those patches already in git head or do I need to apply them separately?
> 
you need to apply them manually on top of clean linus' git tree.

thanks,
rui
> Thanks
> 
> Giacomo