[PATCH] thermal: exynos_tmu: fix wrong error check for mapped memory

[PATCH] thermal: exynos_tmu: fix wrong error check for mapped memory

[Naveen Krishna Chatradhi]

The error check is checking for a "base" mapped memory base
instead of "base_common". Fixing the same.

Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
---
 drivers/thermal/samsung/exynos_tmu.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c
index ec01dfe..a033dbb 100644
--- a/drivers/thermal/samsung/exynos_tmu.c
+++ b/drivers/thermal/samsung/exynos_tmu.c
@@ -592,7 +592,7 @@ static int exynos_map_dt_data(struct platform_device *pdev)
 
 	data->base_common = devm_ioremap(&pdev->dev, res.start,
 					resource_size(&res));
-	if (!data->base) {
+	if (!data->base_common) {
 		dev_err(&pdev->dev, "Failed to ioremap memory\n");
 		return -ENOMEM;
 	}
-- 
1.7.9.5

Re: [PATCH] thermal: exynos_tmu: fix wrong error check for mapped memory

[Zhang Rui]

On 三, 2013-08-07 at 14:01 +0530, Naveen Krishna Chatradhi wrote:
> The error check is checking for a "base" mapped memory base
> instead of "base_common". Fixing the same.
> 
> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>

applied. Thanks!
BTW, can you rebase the other three exynos patches you submitted?

thanks,
rui
> ---
>  drivers/thermal/samsung/exynos_tmu.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c
> index ec01dfe..a033dbb 100644
> --- a/drivers/thermal/samsung/exynos_tmu.c
> +++ b/drivers/thermal/samsung/exynos_tmu.c
> @@ -592,7 +592,7 @@ static int exynos_map_dt_data(struct platform_device *pdev)
>  
>  	data->base_common = devm_ioremap(&pdev->dev, res.start,
>  					resource_size(&res));
> -	if (!data->base) {
> +	if (!data->base_common) {
>  		dev_err(&pdev->dev, "Failed to ioremap memory\n");
>  		return -ENOMEM;
>  	}

Re: [PATCH] thermal: exynos_tmu: fix wrong error check for mapped memory

[Naveen Krishna Ch]

On 15 August 2013 12:32, Zhang Rui <rui.zhang@intel.com> wrote:
>
> On 三, 2013-08-07 at 14:01 +0530, Naveen Krishna Chatradhi wrote:
> > The error check is checking for a "base" mapped memory base
> > instead of "base_common". Fixing the same.
> >
> > Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
>
> applied. Thanks!
> BTW, can you rebase the other three exynos patches you submitted?
I mistakenly rebased on the master branch.
Later found the code base is a lot different in the for-next branch.
I've it in my pipe line, Will submit at the soon.

Thanks Rui,

>
> thanks,
> rui
> > ---
> >  drivers/thermal/samsung/exynos_tmu.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c
> > index ec01dfe..a033dbb 100644
> > --- a/drivers/thermal/samsung/exynos_tmu.c
> > +++ b/drivers/thermal/samsung/exynos_tmu.c
> > @@ -592,7 +592,7 @@ static int exynos_map_dt_data(struct platform_device *pdev)
> >
> >       data->base_common = devm_ioremap(&pdev->dev, res.start,
> >                                       resource_size(&res));
> > -     if (!data->base) {
> > +     if (!data->base_common) {
> >               dev_err(&pdev->dev, "Failed to ioremap memory\n");
> >               return -ENOMEM;
> >       }
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/




-- 
Shine bright,
(: Nav :)