From: Zhang Rui <rui.zhang@intel.com>
To: rjw@sisk.pl
Cc: linux-pm@vger.kernel.org, Zhang Rui <rui.zhang@intel.com>
Subject: [PATCH 10/27] pcc_freq: convert acpi_get_handle() to acpi_has_method()
Date: Tue, 3 Sep 2013 08:31:58 +0800 [thread overview]
Message-ID: <1378168335-22556-11-git-send-email-rui.zhang@intel.com> (raw)
In-Reply-To: <1378168335-22556-1-git-send-email-rui.zhang@intel.com>
acpi_has_method() is a new ACPI API introduced to check
the existence of an ACPI control method.
It can be used to replace acpi_get_handle() in the case that
1. the calling function doesn't need the ACPI handle of the control method.
and
2. the calling function doesn't care the reason why the method is unavailable.
Convert acpi_get_handle() to acpi_has_method()
in drivers/cpufreq/pcc_freq.c in this patch.
Signed-off-by: Zhang Rui <rui.zhang@intel.com>
CC: linux-pm@vger.kernel.org
---
drivers/cpufreq/pcc-cpufreq.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/cpufreq/pcc-cpufreq.c b/drivers/cpufreq/pcc-cpufreq.c
index d81c4e5..70438de 100644
--- a/drivers/cpufreq/pcc-cpufreq.c
+++ b/drivers/cpufreq/pcc-cpufreq.c
@@ -396,15 +396,14 @@ static int __init pcc_cpufreq_probe(void)
struct pcc_memory_resource *mem_resource;
struct pcc_register_resource *reg_resource;
union acpi_object *out_obj, *member;
- acpi_handle handle, osc_handle, pcch_handle;
+ acpi_handle handle, osc_handle;
int ret = 0;
status = acpi_get_handle(NULL, "\\_SB", &handle);
if (ACPI_FAILURE(status))
return -ENODEV;
- status = acpi_get_handle(handle, "PCCH", &pcch_handle);
- if (ACPI_FAILURE(status))
+ if (!acpi_has_method(handle, "PCCH"))
return -ENODEV;
status = acpi_get_handle(handle, "_OSC", &osc_handle);
--
1.8.1.2
next prev parent reply other threads:[~2013-09-03 0:31 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-03 0:31 [PATCH 00/27] ACPI AML helper conversion Zhang Rui
2013-09-03 0:31 ` [PATCH 01/27] olpc_xo15_sci: convert acpi_evaluate_object() to acpi_execute_simple_method() Zhang Rui
2013-09-03 0:31 ` [PATCH 02/27] gpiolib-acpi: " Zhang Rui
2013-09-03 7:17 ` Mika Westerberg
2013-09-03 7:42 ` Mathias Nyman
2013-09-17 12:55 ` Linus Walleij
2013-09-03 0:31 ` [PATCH 03/27] eeepc-laptop: " Zhang Rui
2013-09-03 0:31 ` [PATCH 04/27] fujitsu-laptop: " Zhang Rui
2013-09-03 13:11 ` Jonathan Woithe
2013-09-03 0:31 ` [PATCH 05/27] intel-rst: " Zhang Rui
2013-09-03 0:31 ` [PATCH 06/27] intel-smartconnect: " Zhang Rui
2013-09-03 0:31 ` [PATCH 07/27] topstar-laptop: " Zhang Rui
2013-09-03 0:31 ` [PATCH 08/27] toshiba_acpi: " Zhang Rui
2013-09-03 0:31 ` [PATCH 09/27] wmi: " Zhang Rui
2013-09-03 0:31 ` Zhang Rui [this message]
2013-09-03 0:31 ` [PATCH 11/27] i915: intel_acpi: convert acpi_get_handle() to acpi_has_method() Zhang Rui
2013-09-09 8:57 ` Daniel Vetter
2013-09-03 0:32 ` [PATCH 12/27] nouveau_acpi: " Zhang Rui
2013-09-03 0:32 ` [PATCH 13/27] acpi_pcihp: " Zhang Rui
2013-09-03 0:32 ` [PATCH 14/27] pci-acpi: " Zhang Rui
2013-09-03 0:32 ` [PATCH 15/27] fujitsu-laptop: " Zhang Rui
2013-09-03 13:11 ` Jonathan Woithe
2013-09-03 0:32 ` [PATCH 16/27] intel_menlow: " Zhang Rui
2013-09-03 0:32 ` [PATCH 17/27] sony-laptop: " Zhang Rui
2013-09-03 0:32 ` [PATCH 18/27] toshiba_acpi: " Zhang Rui
2013-09-03 0:32 ` [PATCH 19/27] wmi: " Zhang Rui
2013-09-03 0:32 ` [PATCH 20/27] pnpacpi: " Zhang Rui
2013-09-03 0:32 ` [PATCH 21/27] acpi_processor: convert acpi_evaluate_object() to acpi_evaluate_integer() Zhang Rui
2013-09-03 0:32 ` [PATCH 22/27] ACPI: dock: " Zhang Rui
2013-09-03 0:32 ` [PATCH 23/27] i2c-hid: " Zhang Rui
2013-09-04 10:14 ` Jiri Kosina
2013-09-06 8:17 ` Benjamin Tissoires
2013-09-03 0:32 ` [PATCH 24/27] fujitsu-laptop: " Zhang Rui
2013-09-03 13:12 ` Jonathan Woithe
2013-09-03 0:32 ` [PATCH 25/27] intel-rst: " Zhang Rui
2013-09-03 0:32 ` [PATCH 26/27] intel-smartconnect: " Zhang Rui
2013-09-03 0:32 ` [PATCH 27/27] toshiba_acpi: " Zhang Rui
2013-09-03 11:24 ` [PATCH 00/27] ACPI AML helper conversion Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1378168335-22556-11-git-send-email-rui.zhang@intel.com \
--to=rui.zhang@intel.com \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).