From: Bill Huang <bilhuang@nvidia.com>
To: Peter De Schrijver <pdeschrijver@nvidia.com>
Cc: "rjw@sisk.pl" <rjw@sisk.pl>,
"viresh.kumar@linaro.org" <viresh.kumar@linaro.org>,
"swarren@wwwdotorg.org" <swarren@wwwdotorg.org>,
"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"cpufreq@vger.kernel.org" <cpufreq@vger.kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>
Subject: Re: [PATCH 2/2] cpufreq: tegra: Re-model Tegra cpufreq driver
Date: Thu, 12 Sep 2013 03:35:08 -0700 [thread overview]
Message-ID: <1378982108.2475.3.camel@bilhuang-vm1> (raw)
In-Reply-To: <20130912101459.GG30013@tbergstrom-lnx.Nvidia.com>
On Thu, 2013-09-12 at 18:14 +0800, Peter De Schrijver wrote:
> On Wed, Sep 11, 2013 at 01:19:14PM +0200, Bill Huang wrote:
>
> > +static inline int tegra_cpufreq_init(void)
> > +{
> > + retrun EOPNOTSUPP;
>
> This should be -EOPNOTSUPP at least. I think -EINVAL might be better.
Yeah thanks, I'll also fix the TYPO of return.
>
> Cheers,
>
> Peter.
prev parent reply other threads:[~2013-09-12 10:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-11 11:19 [PATCH 0/2] Remodel Tegra cpufreq driver to support Tegra series SoCs Bill Huang
2013-09-11 11:19 ` [PATCH 1/2] cpufreq: tegra: Remove not used header and clean up codes Bill Huang
[not found] ` <1378898355-31290-2-git-send-email-bilhuang-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-09-11 19:19 ` Stephen Warren
2013-09-11 11:19 ` [PATCH 2/2] cpufreq: tegra: Re-model Tegra cpufreq driver Bill Huang
2013-09-11 19:33 ` Stephen Warren
2013-09-12 2:03 ` Bill Huang
2013-09-12 10:14 ` Peter De Schrijver
2013-09-12 10:35 ` Bill Huang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1378982108.2475.3.camel@bilhuang-vm1 \
--to=bilhuang@nvidia.com \
--cc=cpufreq@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=pdeschrijver@nvidia.com \
--cc=rjw@sisk.pl \
--cc=swarren@wwwdotorg.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).