From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bill Huang Subject: Re: [PATCH 2/2] cpufreq: tegra: Re-model Tegra cpufreq driver Date: Thu, 12 Sep 2013 03:35:08 -0700 Message-ID: <1378982108.2475.3.camel@bilhuang-vm1> References: <1378898355-31290-1-git-send-email-bilhuang@nvidia.com> <1378898355-31290-3-git-send-email-bilhuang@nvidia.com> <20130912101459.GG30013@tbergstrom-lnx.Nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-9" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20130912101459.GG30013@tbergstrom-lnx.Nvidia.com> Sender: cpufreq-owner@vger.kernel.org To: Peter De Schrijver Cc: "rjw@sisk.pl" , "viresh.kumar@linaro.org" , "swarren@wwwdotorg.org" , "linux@arm.linux.org.uk" , "linux-arm-kernel@lists.infradead.org" , "linux-tegra@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "cpufreq@vger.kernel.org" , "linux-pm@vger.kernel.org" List-Id: linux-pm@vger.kernel.org On Thu, 2013-09-12 at 18:14 +0800, Peter De Schrijver wrote: > On Wed, Sep 11, 2013 at 01:19:14PM +0200, Bill Huang wrote: > > > +static inline int tegra_cpufreq_init(void) > > +{ > > + retrun EOPNOTSUPP; > > This should be -EOPNOTSUPP at least. I think -EINVAL might be better. Yeah thanks, I'll also fix the TYPO of return. > > Cheers, > > Peter.