Re: [PATCH V2] Cpufreq: Make governor data on nonboot cpus across system suspend/resume

Rafael J. Wysocki
2013-11-21T21:31:04Z

On Thursday, November 21, 2013 09:24:02 PM Viresh Kumar wrote:
> On 21 November 2013 20:13, Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
> >> - if (((event == CPUFREQ_GOV_POLICY_INIT) && ret) ||
> >
> > The inner parens are not necessary.
> >
> >> - ((event == CPUFREQ_GOV_POLICY_EXIT) && !ret))
> >> + if ((event == CPUFREQ_GOV_POLICY_INIT) && ret) {
> >
> > Same here.
> >
> >> + module_put(policy->governor->owner);
> >> + if (ret == -EALREADY)
> >> + return 0;
> >> + } else if ((event == CPUFREQ_GOV_POLICY_EXIT) && !ret) {
> >
> > Same here.
>
> Logically, yes you are correct. But probably its better for readability to
> get these even if you know precedence is going to take care of our
> expression..

Are you serious?

--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.