* [PATCH 1/1] cpufreq: exynos: Fix line over 80 characters warning
@ 2013-11-19 5:07 Sachin Kamat
2013-11-19 5:11 ` Viresh Kumar
2013-11-21 0:54 ` Rafael J. Wysocki
0 siblings, 2 replies; 4+ messages in thread
From: Sachin Kamat @ 2013-11-19 5:07 UTC (permalink / raw)
To: linux-pm; +Cc: cpufreq, rjw, viresh.kumar, sachin.kamat, Jonghwan Choi
Silences the checkpatch warning introduced by
commit 94aa44090eda ("cpufreq: exynos: Add missing static").
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Jonghwan Choi <jhbird.choi@samsung.com>
---
drivers/cpufreq/exynos5250-cpufreq.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/cpufreq/exynos5250-cpufreq.c b/drivers/cpufreq/exynos5250-cpufreq.c
index 8feda86fe42c..ebbcbb7e1926 100644
--- a/drivers/cpufreq/exynos5250-cpufreq.c
+++ b/drivers/cpufreq/exynos5250-cpufreq.c
@@ -144,7 +144,8 @@ static void set_apll(unsigned int new_index,
}
-static bool exynos5250_pms_change(unsigned int old_index, unsigned int new_index)
+static bool exynos5250_pms_change(unsigned int old_index,
+ unsigned int new_index)
{
unsigned int old_pm = apll_freq_5250[old_index].mps >> 8;
unsigned int new_pm = apll_freq_5250[new_index].mps >> 8;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 1/1] cpufreq: exynos: Fix line over 80 characters warning
2013-11-19 5:07 [PATCH 1/1] cpufreq: exynos: Fix line over 80 characters warning Sachin Kamat
@ 2013-11-19 5:11 ` Viresh Kumar
2013-11-21 0:54 ` Rafael J. Wysocki
1 sibling, 0 replies; 4+ messages in thread
From: Viresh Kumar @ 2013-11-19 5:11 UTC (permalink / raw)
To: Sachin Kamat
Cc: linux-pm@vger.kernel.org, cpufreq@vger.kernel.org,
Rafael J. Wysocki, Jonghwan Choi
On 19 November 2013 10:37, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> Silences the checkpatch warning introduced by
> commit 94aa44090eda ("cpufreq: exynos: Add missing static").
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Jonghwan Choi <jhbird.choi@samsung.com>
> ---
> drivers/cpufreq/exynos5250-cpufreq.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 1/1] cpufreq: exynos: Fix line over 80 characters warning
2013-11-19 5:07 [PATCH 1/1] cpufreq: exynos: Fix line over 80 characters warning Sachin Kamat
2013-11-19 5:11 ` Viresh Kumar
@ 2013-11-21 0:54 ` Rafael J. Wysocki
2013-11-21 2:58 ` Sachin Kamat
1 sibling, 1 reply; 4+ messages in thread
From: Rafael J. Wysocki @ 2013-11-21 0:54 UTC (permalink / raw)
To: Sachin Kamat; +Cc: linux-pm, cpufreq, viresh.kumar, Jonghwan Choi
On Tuesday, November 19, 2013 10:37:19 AM Sachin Kamat wrote:
> Silences the checkpatch warning introduced by
> commit 94aa44090eda ("cpufreq: exynos: Add missing static").
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Jonghwan Choi <jhbird.choi@samsung.com>
I'm not going to apply this and seriously if you care, please modify
checkpatch.pl to stop emitting that warning. It is silly and useless in
my opinion, so I won't take any patches "fixing" it.
Thanks!
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 1/1] cpufreq: exynos: Fix line over 80 characters warning
2013-11-21 0:54 ` Rafael J. Wysocki
@ 2013-11-21 2:58 ` Sachin Kamat
0 siblings, 0 replies; 4+ messages in thread
From: Sachin Kamat @ 2013-11-21 2:58 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: linux-pm@vger.kernel.org, cpufreq@vger.kernel.org, Viresh Kumar,
Jonghwan Choi
On 21 November 2013 06:24, Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
> On Tuesday, November 19, 2013 10:37:19 AM Sachin Kamat wrote:
>> Silences the checkpatch warning introduced by
>> commit 94aa44090eda ("cpufreq: exynos: Add missing static").
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>> Cc: Jonghwan Choi <jhbird.choi@samsung.com>
>
> I'm not going to apply this and seriously if you care, please modify
> checkpatch.pl to stop emitting that warning. It is silly and useless in
> my opinion, so I won't take any patches "fixing" it.
Agreed. However, the cpufreq drivers are pretty clean already and
this one just stands out. That was the only reason for doing this.
--
With warm regards,
Sachin
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-11-21 2:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-19 5:07 [PATCH 1/1] cpufreq: exynos: Fix line over 80 characters warning Sachin Kamat
2013-11-19 5:11 ` Viresh Kumar
2013-11-21 0:54 ` Rafael J. Wysocki
2013-11-21 2:58 ` Sachin Kamat
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).