From: Joe Perches <joe@perches.com>
To: Shuah Khan <shuah.kh@samsung.com>
Cc: len.brown@intel.com, pavel@ucw.cz, gregkh@linuxfoundation.org,
rjw@rjwysocki.net, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, shuahkhan@gmail.com
Subject: Re: [PATCH v2] power: Replace printks with dev_* and pr_* routines
Date: Tue, 19 Nov 2013 10:53:25 -0800 [thread overview]
Message-ID: <1384887205.17783.40.camel@joe-AO722> (raw)
In-Reply-To: <1384886818-11861-1-git-send-email-shuah.kh@samsung.com>
On Tue, 2013-11-19 at 11:46 -0700, Shuah Khan wrote:
> Replaced printks with dev_* and pr_* routines. Replacing printk in
> __suspend_report_result() will require passing in struct device *
> pointer from calling routines and this will require changes to
> external interface suspend_report_result() which is used by several
> drivers. Hence, this one instance is replaced by pr_err().
[]
> diff --git a/drivers/base/power/main.c b/drivers/base/power/main.c
[]
> @@ -1308,9 +1308,8 @@ int dpm_prepare(pm_message_t state)
> error = 0;
> continue;
> }
> - printk(KERN_INFO "PM: Device %s not prepared "
> - "for power transition: code %d\n",
> - dev_name(dev), error);
> + dev_info("PM: not prepared for power transition: ",
> + "code %d\n", error);
Shuah, you have to make sure the files modified by
your patches compile successfully before sending
patches like this.
next prev parent reply other threads:[~2013-11-19 18:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-19 18:46 [PATCH v2] power: Replace printks with dev_* and pr_* routines Shuah Khan
2013-11-19 18:53 ` Joe Perches [this message]
2013-11-19 18:57 ` Shuah Khan
2013-11-19 19:07 ` Joe Perches
2013-11-19 20:00 ` Shuah Khan
2013-11-19 22:59 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1384887205.17783.40.camel@joe-AO722 \
--to=joe@perches.com \
--cc=gregkh@linuxfoundation.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=shuah.kh@samsung.com \
--cc=shuahkhan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).