* Re: A question about the patch: [PATCH] PCI/PM: Keep runtime PM enabled for unbound PCI devices [not found] <52837A10.3040301@linux.vnet.ibm.com> @ 2013-11-13 16:47 ` Bjorn Helgaas 2013-11-13 19:20 ` Alan Stern 0 siblings, 1 reply; 15+ messages in thread From: Bjorn Helgaas @ 2013-11-13 16:47 UTC (permalink / raw) To: mike Cc: Huang Ying, Alan Stern, linux-pci@vger.kernel.org, Rafael J. Wysocki, Linux PM list [+cc Rafael, linux-pm] On Wed, Nov 13, 2013 at 6:09 AM, mike <qiudayu@linux.vnet.ibm.com> wrote: > Hi Huang Ying, > > I see you are the author of this patch, commit id is: > 967577b062417b4e4b8e27b711220f4124f5153a > > I have a question while I try to understand this patch, > So I would very grateful if you or others can give me some reply..... > > ............ > - rc = ddi->drv->probe(ddi->dev, ddi->id); > + pm_runtime_get_sync(dev); > + pci_dev->driver = pci_drv; > ^^^^^^^^^^^^^^^^^^^^^^^^^^ > I see here you make the driver to initialize before probe, > But I have no idea of why you do this change..... > > and I look inside the code, it may be pm_runtime relate?? > > Thanks > Mike > + rc = pci_drv->probe(pci_dev, ddi->id); > if (rc) { > - pm_runtime_disable(dev); > - pm_runtime_set_suspended(dev); > - pm_runtime_put_noidle(dev); > + pci_dev->driver = NULL; > + pm_runtime_put_sync(dev); > } > - if (parent) > - pm_runtime_put(parent); > return rc; > } > > @@ -330,10 +325,8 @@ __pci_device_probe(struct pci_driver *drv, struct > pci_dev *pci_dev) > id = pci_match_device(drv, pci_dev); > if (id) > error = pci_call_probe(drv, pci_dev, id); > - if (error >= 0) { > - pci_dev->driver = drv; > + if (error >= 0) > error = 0; > - } > } > return error; > } > ....................... > ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: A question about the patch: [PATCH] PCI/PM: Keep runtime PM enabled for unbound PCI devices 2013-11-13 16:47 ` A question about the patch: [PATCH] PCI/PM: Keep runtime PM enabled for unbound PCI devices Bjorn Helgaas @ 2013-11-13 19:20 ` Alan Stern 2013-11-14 3:23 ` mike 0 siblings, 1 reply; 15+ messages in thread From: Alan Stern @ 2013-11-13 19:20 UTC (permalink / raw) To: Bjorn Helgaas Cc: mike, Huang Ying, linux-pci@vger.kernel.org, Rafael J. Wysocki, Linux PM list On Wed, 13 Nov 2013, Bjorn Helgaas wrote: > [+cc Rafael, linux-pm] > > On Wed, Nov 13, 2013 at 6:09 AM, mike <qiudayu@linux.vnet.ibm.com> wrote: > > Hi Huang Ying, > > > > I see you are the author of this patch, commit id is: > > 967577b062417b4e4b8e27b711220f4124f5153a > > > > I have a question while I try to understand this patch, > > So I would very grateful if you or others can give me some reply..... > > > > ............ > > - rc = ddi->drv->probe(ddi->dev, ddi->id); > > + pm_runtime_get_sync(dev); > > + pci_dev->driver = pci_drv; > > ^^^^^^^^^^^^^^^^^^^^^^^^^^ > > I see here you make the driver to initialize before probe, > > But I have no idea of why you do this change..... > > > > and I look inside the code, it may be pm_runtime relate?? Yes, it is related to runtime PM. In the PCI subsystem, runtime PM doesn't do anything unless pci_dev->driver is set. You can see this at the start of pci_pm_runtime_suspend(). Since we want the driver's probe routine to be able to carry out runtime PM operations, we have to set pci_dev->driver before the probe routine runs. Alan Stern ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: A question about the patch: [PATCH] PCI/PM: Keep runtime PM enabled for unbound PCI devices 2013-11-13 19:20 ` Alan Stern @ 2013-11-14 3:23 ` mike 2013-11-14 5:59 ` Huang Ying 0 siblings, 1 reply; 15+ messages in thread From: mike @ 2013-11-14 3:23 UTC (permalink / raw) To: Alan Stern Cc: Bjorn Helgaas, Huang Ying, linux-pci@vger.kernel.org, linux-pm, rjw On 11/14/2013 03:20 AM, Alan Stern wrote: > On Wed, 13 Nov 2013, Bjorn Helgaas wrote: > >> [+cc Rafael, linux-pm] >> >> On Wed, Nov 13, 2013 at 6:09 AM, mike<qiudayu@linux.vnet.ibm.com> wrote: >>> Hi Huang Ying, >>> >>> I see you are the author of this patch, commit id is: >>> 967577b062417b4e4b8e27b711220f4124f5153a >>> >>> I have a question while I try to understand this patch, >>> So I would very grateful if you or others can give me some reply..... >>> >>> ............ >>> - rc = ddi->drv->probe(ddi->dev, ddi->id); >>> + pm_runtime_get_sync(dev); >>> + pci_dev->driver = pci_drv; >>> ^^^^^^^^^^^^^^^^^^^^^^^^^^ >>> I see here you make the driver to initialize before probe, >>> But I have no idea of why you do this change..... >>> >>> and I look inside the code, it may be pm_runtime relate?? > Yes, it is related to runtime PM. In the PCI subsystem, runtime PM > doesn't do anything unless pci_dev->driver is set. You can see this at > the start of pci_pm_runtime_suspend(). > > Since we want the driver's probe routine to be able to carry out > runtime PM operations, we have to set pci_dev->driver before the probe > routine runs. Is there any situations , like in probe state, pci_dev->driver has been set. the pci_pm_runtime_xxx() has passed pci_dev->driver NULL check, but at this point, probe fail occurs, and pci_dev->driver to be set to NULL. What will happen ? Or this situation will never happen? I'm confuse about this. Because it may be dangerous to call the functions in driver to do some actions in the device which probe failed. Even if it will at last probe success, the driver itself must be very strong, because may be a lot critical data structs haven't be created or initialized, if we call driver function in probe state may be lead a invalid access to some pointer. So I think this logic may have some issue, am I right? If I am right, I have a *patch to fix this issue*, but I'm not sure it is safe enough to do PM ops in probe state. Actually, I face a *bug report* to this issue, access the driver function in probe state, even though it can be fixed in driver ( Make the driver more stronger), but the root cause is this issue. Pray for your reply, and I really want to know. Thanks Mike > Alan Stern > ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: A question about the patch: [PATCH] PCI/PM: Keep runtime PM enabled for unbound PCI devices 2013-11-14 3:23 ` mike @ 2013-11-14 5:59 ` Huang Ying 2013-11-14 7:19 ` mike 0 siblings, 1 reply; 15+ messages in thread From: Huang Ying @ 2013-11-14 5:59 UTC (permalink / raw) To: mike; +Cc: Alan Stern, Bjorn Helgaas, linux-pci@vger.kernel.org, linux-pm, rjw On Thu, 2013-11-14 at 11:23 +0800, mike wrote: > On 11/14/2013 03:20 AM, Alan Stern wrote: > > On Wed, 13 Nov 2013, Bjorn Helgaas wrote: > > > >> [+cc Rafael, linux-pm] > >> > >> On Wed, Nov 13, 2013 at 6:09 AM, mike<qiudayu@linux.vnet.ibm.com> wrote: > >>> Hi Huang Ying, > >>> > >>> I see you are the author of this patch, commit id is: > >>> 967577b062417b4e4b8e27b711220f4124f5153a > >>> > >>> I have a question while I try to understand this patch, > >>> So I would very grateful if you or others can give me some reply..... > >>> > >>> ............ > >>> - rc = ddi->drv->probe(ddi->dev, ddi->id); > >>> + pm_runtime_get_sync(dev); > >>> + pci_dev->driver = pci_drv; > >>> ^^^^^^^^^^^^^^^^^^^^^^^^^^ > >>> I see here you make the driver to initialize before probe, > >>> But I have no idea of why you do this change..... > >>> > >>> and I look inside the code, it may be pm_runtime relate?? > > Yes, it is related to runtime PM. In the PCI subsystem, runtime PM > > doesn't do anything unless pci_dev->driver is set. You can see this at > > the start of pci_pm_runtime_suspend(). > > > > Since we want the driver's probe routine to be able to carry out > > runtime PM operations, we have to set pci_dev->driver before the probe > > routine runs. > Is there any situations , like in probe state, pci_dev->driver > has been set. the pci_pm_runtime_xxx() has passed > pci_dev->driver NULL check, but at this point, probe fail > occurs, and pci_dev->driver to be set to NULL. > > What will happen ? Or this situation will never happen? > I'm confuse about this. I think that will never happen. Before ->probe(), pm_runtime_get_sync() is called, so pci_pm_runtime_xxx() will not be called until pm_runtime_put_noidle() is called in ->probe(). And pm_runtime_put_noidle() should be done as one of the latest actions in ->probe(), after the normal probe actions succeeded. Best Regards, Huang Ying ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: A question about the patch: [PATCH] PCI/PM: Keep runtime PM enabled for unbound PCI devices 2013-11-14 5:59 ` Huang Ying @ 2013-11-14 7:19 ` mike 2013-11-14 7:53 ` Huang Ying 0 siblings, 1 reply; 15+ messages in thread From: mike @ 2013-11-14 7:19 UTC (permalink / raw) To: Huang Ying Cc: Alan Stern, Bjorn Helgaas, linux-pci@vger.kernel.org, linux-pm, rjw On 11/14/2013 01:59 PM, Huang Ying wrote: > On Thu, 2013-11-14 at 11:23 +0800, mike wrote: >> On 11/14/2013 03:20 AM, Alan Stern wrote: >>> On Wed, 13 Nov 2013, Bjorn Helgaas wrote: >>> >>>> [+cc Rafael, linux-pm] >>>> >>>> On Wed, Nov 13, 2013 at 6:09 AM, mike<qiudayu@linux.vnet.ibm.com> wrote: >>>>> Hi Huang Ying, >>>>> >>>>> I see you are the author of this patch, commit id is: >>>>> 967577b062417b4e4b8e27b711220f4124f5153a >>>>> >>>>> I have a question while I try to understand this patch, >>>>> So I would very grateful if you or others can give me some reply..... >>>>> >>>>> ............ >>>>> - rc = ddi->drv->probe(ddi->dev, ddi->id); >>>>> + pm_runtime_get_sync(dev); >>>>> + pci_dev->driver = pci_drv; >>>>> ^^^^^^^^^^^^^^^^^^^^^^^^^^ >>>>> I see here you make the driver to initialize before probe, >>>>> But I have no idea of why you do this change..... >>>>> >>>>> and I look inside the code, it may be pm_runtime relate?? >>> Yes, it is related to runtime PM. In the PCI subsystem, runtime PM >>> doesn't do anything unless pci_dev->driver is set. You can see this at >>> the start of pci_pm_runtime_suspend(). >>> >>> Since we want the driver's probe routine to be able to carry out >>> runtime PM operations, we have to set pci_dev->driver before the probe >>> routine runs. >> Is there any situations , like in probe state, pci_dev->driver >> has been set. the pci_pm_runtime_xxx() has passed >> pci_dev->driver NULL check, but at this point, probe fail >> occurs, and pci_dev->driver to be set to NULL. >> >> What will happen ? Or this situation will never happen? >> I'm confuse about this. > I think that will never happen. Before ->probe(), pm_runtime_get_sync() > is called, so pci_pm_runtime_xxx() will not be called until > pm_runtime_put_noidle() is called in ->probe(). And > should be done as one of the latest actions in > ->probe(), after the normal probe actions succeeded. OK, just as your description, it seems OK. But this is really a issue as I explained in last email. So I want to know if there are any side-effect of changing the code in pci_pm_runtime_xxx() if (!pci_dev->driver) return 0; to if (!dev->driver) return 0; I check the code and find out that, the case dev->driver is set but pci_dev->driver is not set just in remove state (__device_release_driver()), and after that state, all be set to NULL. My understand is: dev->driver = NULL, also means unbound, am I right? Thanks Mike > Best Regards, > Huang Ying > > ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: A question about the patch: [PATCH] PCI/PM: Keep runtime PM enabled for unbound PCI devices 2013-11-14 7:19 ` mike @ 2013-11-14 7:53 ` Huang Ying 2013-11-14 8:12 ` mike 0 siblings, 1 reply; 15+ messages in thread From: Huang Ying @ 2013-11-14 7:53 UTC (permalink / raw) To: mike; +Cc: Alan Stern, Bjorn Helgaas, linux-pci@vger.kernel.org, linux-pm, rjw On Thu, 2013-11-14 at 15:19 +0800, mike wrote: > On 11/14/2013 01:59 PM, Huang Ying wrote: > > On Thu, 2013-11-14 at 11:23 +0800, mike wrote: > >> On 11/14/2013 03:20 AM, Alan Stern wrote: > >>> On Wed, 13 Nov 2013, Bjorn Helgaas wrote: > >>> > >>>> [+cc Rafael, linux-pm] > >>>> > >>>> On Wed, Nov 13, 2013 at 6:09 AM, mike<qiudayu@linux.vnet.ibm.com> wrote: > >>>>> Hi Huang Ying, > >>>>> > >>>>> I see you are the author of this patch, commit id is: > >>>>> 967577b062417b4e4b8e27b711220f4124f5153a > >>>>> > >>>>> I have a question while I try to understand this patch, > >>>>> So I would very grateful if you or others can give me some reply..... > >>>>> > >>>>> ............ > >>>>> - rc = ddi->drv->probe(ddi->dev, ddi->id); > >>>>> + pm_runtime_get_sync(dev); > >>>>> + pci_dev->driver = pci_drv; > >>>>> ^^^^^^^^^^^^^^^^^^^^^^^^^^ > >>>>> I see here you make the driver to initialize before probe, > >>>>> But I have no idea of why you do this change..... > >>>>> > >>>>> and I look inside the code, it may be pm_runtime relate?? > >>> Yes, it is related to runtime PM. In the PCI subsystem, runtime PM > >>> doesn't do anything unless pci_dev->driver is set. You can see this at > >>> the start of pci_pm_runtime_suspend(). > >>> > >>> Since we want the driver's probe routine to be able to carry out > >>> runtime PM operations, we have to set pci_dev->driver before the probe > >>> routine runs. > >> Is there any situations , like in probe state, pci_dev->driver > >> has been set. the pci_pm_runtime_xxx() has passed > >> pci_dev->driver NULL check, but at this point, probe fail > >> occurs, and pci_dev->driver to be set to NULL. > >> > >> What will happen ? Or this situation will never happen? > >> I'm confuse about this. > > I think that will never happen. Before ->probe(), pm_runtime_get_sync() > > is called, so pci_pm_runtime_xxx() will not be called until > > pm_runtime_put_noidle() is called in ->probe(). And > > should be done as one of the latest actions in > > ->probe(), after the normal probe actions succeeded. > OK, just as your description, it seems OK. > But this is really a issue as I explained in last email. > > So I want to know if there are any side-effect of changing the code > in pci_pm_runtime_xxx() > > if (!pci_dev->driver) > return 0; > to > > if (!dev->driver) > return 0; > If you make this change, we can not put devices into low power state (runtime suspend the device) in ->probe(). That is expected in some circumstance. Best Regards, Huang Ying ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: A question about the patch: [PATCH] PCI/PM: Keep runtime PM enabled for unbound PCI devices 2013-11-14 7:53 ` Huang Ying @ 2013-11-14 8:12 ` mike 2013-11-14 8:25 ` Huang Ying 0 siblings, 1 reply; 15+ messages in thread From: mike @ 2013-11-14 8:12 UTC (permalink / raw) To: Huang Ying Cc: Alan Stern, Bjorn Helgaas, linux-pci@vger.kernel.org, linux-pm, rjw On 11/14/2013 03:53 PM, Huang Ying wrote: > On Thu, 2013-11-14 at 15:19 +0800, mike wrote: >> On 11/14/2013 01:59 PM, Huang Ying wrote: >>> On Thu, 2013-11-14 at 11:23 +0800, mike wrote: >>>> On 11/14/2013 03:20 AM, Alan Stern wrote: >>>>> On Wed, 13 Nov 2013, Bjorn Helgaas wrote: >>>>> >>>>>> [+cc Rafael, linux-pm] >>>>>> >>>>>> On Wed, Nov 13, 2013 at 6:09 AM, mike<qiudayu@linux.vnet.ibm.com> wrote: >>>>>>> Hi Huang Ying, >>>>>>> >>>>>>> I see you are the author of this patch, commit id is: >>>>>>> 967577b062417b4e4b8e27b711220f4124f5153a >>>>>>> >>>>>>> I have a question while I try to understand this patch, >>>>>>> So I would very grateful if you or others can give me some reply..... >>>>>>> >>>>>>> ............ >>>>>>> - rc = ddi->drv->probe(ddi->dev, ddi->id); >>>>>>> + pm_runtime_get_sync(dev); >>>>>>> + pci_dev->driver = pci_drv; >>>>>>> ^^^^^^^^^^^^^^^^^^^^^^^^^^ >>>>>>> I see here you make the driver to initialize before probe, >>>>>>> But I have no idea of why you do this change..... >>>>>>> >>>>>>> and I look inside the code, it may be pm_runtime relate?? >>>>> Yes, it is related to runtime PM. In the PCI subsystem, runtime PM >>>>> doesn't do anything unless pci_dev->driver is set. You can see this at >>>>> the start of pci_pm_runtime_suspend(). >>>>> >>>>> Since we want the driver's probe routine to be able to carry out >>>>> runtime PM operations, we have to set pci_dev->driver before the probe >>>>> routine runs. >>>> Is there any situations , like in probe state, pci_dev->driver >>>> has been set. the pci_pm_runtime_xxx() has passed >>>> pci_dev->driver NULL check, but at this point, probe fail >>>> occurs, and pci_dev->driver to be set to NULL. >>>> >>>> What will happen ? Or this situation will never happen? >>>> I'm confuse about this. >>> I think that will never happen. Before ->probe(), pm_runtime_get_sync() >>> is called, so pci_pm_runtime_xxx() will not be called until >>> pm_runtime_put_noidle() is called in ->probe(). And >>> should be done as one of the latest actions in >>> ->probe(), after the normal probe actions succeeded. >> OK, just as your description, it seems OK. >> But this is really a issue as I explained in last email. >> >> So I want to know if there are any side-effect of changing the code >> in pci_pm_runtime_xxx() >> >> if (!pci_dev->driver) >> return 0; >> to >> >> if (!dev->driver) >> return 0; >> > If you make this change, we can not put devices into low power state > (runtime suspend the device) in ->probe(). That is expected in some ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ This means dev->driver is NULL ?? but pci_dev->driver is set??? Because if use pci_dev->driver can put into low power state, means pci_dev->driver is set, but in the situation, use dev->driver will can't, means dev->driver = null, but I have not find any case that dev->driver = null, but pci_dev->driver != null; I know I always been a question guy, i apologize for spend a lot time to reply this mail, but I really want to understand it, Thanks Mike > circumstance. > > Best Regards, > Huang Ying > > ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: A question about the patch: [PATCH] PCI/PM: Keep runtime PM enabled for unbound PCI devices 2013-11-14 8:12 ` mike @ 2013-11-14 8:25 ` Huang Ying 2013-11-14 8:37 ` mike 0 siblings, 1 reply; 15+ messages in thread From: Huang Ying @ 2013-11-14 8:25 UTC (permalink / raw) To: mike; +Cc: Alan Stern, Bjorn Helgaas, linux-pci@vger.kernel.org, linux-pm, rjw On Thu, 2013-11-14 at 16:12 +0800, mike wrote: > On 11/14/2013 03:53 PM, Huang Ying wrote: > > On Thu, 2013-11-14 at 15:19 +0800, mike wrote: > >> On 11/14/2013 01:59 PM, Huang Ying wrote: > >>> On Thu, 2013-11-14 at 11:23 +0800, mike wrote: > >>>> On 11/14/2013 03:20 AM, Alan Stern wrote: > >>>>> On Wed, 13 Nov 2013, Bjorn Helgaas wrote: > >>>>> > >>>>>> [+cc Rafael, linux-pm] > >>>>>> > >>>>>> On Wed, Nov 13, 2013 at 6:09 AM, mike<qiudayu@linux.vnet.ibm.com> wrote: > >>>>>>> Hi Huang Ying, > >>>>>>> > >>>>>>> I see you are the author of this patch, commit id is: > >>>>>>> 967577b062417b4e4b8e27b711220f4124f5153a > >>>>>>> > >>>>>>> I have a question while I try to understand this patch, > >>>>>>> So I would very grateful if you or others can give me some reply..... > >>>>>>> > >>>>>>> ............ > >>>>>>> - rc = ddi->drv->probe(ddi->dev, ddi->id); > >>>>>>> + pm_runtime_get_sync(dev); > >>>>>>> + pci_dev->driver = pci_drv; > >>>>>>> ^^^^^^^^^^^^^^^^^^^^^^^^^^ > >>>>>>> I see here you make the driver to initialize before probe, > >>>>>>> But I have no idea of why you do this change..... > >>>>>>> > >>>>>>> and I look inside the code, it may be pm_runtime relate?? > >>>>> Yes, it is related to runtime PM. In the PCI subsystem, runtime PM > >>>>> doesn't do anything unless pci_dev->driver is set. You can see this at > >>>>> the start of pci_pm_runtime_suspend(). > >>>>> > >>>>> Since we want the driver's probe routine to be able to carry out > >>>>> runtime PM operations, we have to set pci_dev->driver before the probe > >>>>> routine runs. > >>>> Is there any situations , like in probe state, pci_dev->driver > >>>> has been set. the pci_pm_runtime_xxx() has passed > >>>> pci_dev->driver NULL check, but at this point, probe fail > >>>> occurs, and pci_dev->driver to be set to NULL. > >>>> > >>>> What will happen ? Or this situation will never happen? > >>>> I'm confuse about this. > >>> I think that will never happen. Before ->probe(), pm_runtime_get_sync() > >>> is called, so pci_pm_runtime_xxx() will not be called until > >>> pm_runtime_put_noidle() is called in ->probe(). And > >>> should be done as one of the latest actions in > >>> ->probe(), after the normal probe actions succeeded. > >> OK, just as your description, it seems OK. > >> But this is really a issue as I explained in last email. > >> > >> So I want to know if there are any side-effect of changing the code > >> in pci_pm_runtime_xxx() > >> > >> if (!pci_dev->driver) > >> return 0; > >> to > >> > >> if (!dev->driver) > >> return 0; > >> > > If you make this change, we can not put devices into low power state > > (runtime suspend the device) in ->probe(). That is expected in some > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > This means dev->driver is NULL ?? but pci_dev->driver is set??? > > Because if use pci_dev->driver can put into low power state, means > > pci_dev->driver is set, but in the situation, use dev->driver will can't, > > means dev->driver = null, but I have not find any case that > > dev->driver = null, but pci_dev->driver != null; Sorry I make a mistake here. The dev->driver != null in local_pci_probe(). We use pci_dev->driver instead of dev->driver in pci_pm_runtime_xxx() because we want device to be kept in normal power state (D0) and SUSPENDED state when unbound. The pm_runtime_put/get_sync in pci_device_remove/local_pci_probe will not change the power state of the device because of the check in pci_pm_runtime_xxx(). > I know I always been a question guy, i apologize for spend a lot > time to reply this mail, but I really want to understand it, Never mind. Best Regards, Huang Ying ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: A question about the patch: [PATCH] PCI/PM: Keep runtime PM enabled for unbound PCI devices 2013-11-14 8:25 ` Huang Ying @ 2013-11-14 8:37 ` mike 2013-11-14 8:54 ` Huang Ying 0 siblings, 1 reply; 15+ messages in thread From: mike @ 2013-11-14 8:37 UTC (permalink / raw) To: Huang Ying Cc: Alan Stern, Bjorn Helgaas, linux-pci@vger.kernel.org, linux-pm, rjw On 11/14/2013 04:25 PM, Huang Ying wrote: > On Thu, 2013-11-14 at 16:12 +0800, mike wrote: >> On 11/14/2013 03:53 PM, Huang Ying wrote: >>> On Thu, 2013-11-14 at 15:19 +0800, mike wrote: >>>> On 11/14/2013 01:59 PM, Huang Ying wrote: >>>>> On Thu, 2013-11-14 at 11:23 +0800, mike wrote: >>>>>> On 11/14/2013 03:20 AM, Alan Stern wrote: >>>>>>> On Wed, 13 Nov 2013, Bjorn Helgaas wrote: >>>>>>> >>>>>>>> [+cc Rafael, linux-pm] >>>>>>>> >>>>>>>> On Wed, Nov 13, 2013 at 6:09 AM, mike<qiudayu@linux.vnet.ibm.com> wrote: >>>>>>>>> Hi Huang Ying, >>>>>>>>> >>>>>>>>> I see you are the author of this patch, commit id is: >>>>>>>>> 967577b062417b4e4b8e27b711220f4124f5153a >>>>>>>>> >>>>>>>>> I have a question while I try to understand this patch, >>>>>>>>> So I would very grateful if you or others can give me some reply..... >>>>>>>>> >>>>>>>>> ............ >>>>>>>>> - rc = ddi->drv->probe(ddi->dev, ddi->id); >>>>>>>>> + pm_runtime_get_sync(dev); >>>>>>>>> + pci_dev->driver = pci_drv; >>>>>>>>> ^^^^^^^^^^^^^^^^^^^^^^^^^^ >>>>>>>>> I see here you make the driver to initialize before probe, >>>>>>>>> But I have no idea of why you do this change..... >>>>>>>>> >>>>>>>>> and I look inside the code, it may be pm_runtime relate?? >>>>>>> Yes, it is related to runtime PM. In the PCI subsystem, runtime PM >>>>>>> doesn't do anything unless pci_dev->driver is set. You can see this at >>>>>>> the start of pci_pm_runtime_suspend(). >>>>>>> >>>>>>> Since we want the driver's probe routine to be able to carry out >>>>>>> runtime PM operations, we have to set pci_dev->driver before the probe >>>>>>> routine runs. >>>>>> Is there any situations , like in probe state, pci_dev->driver >>>>>> has been set. the pci_pm_runtime_xxx() has passed >>>>>> pci_dev->driver NULL check, but at this point, probe fail >>>>>> occurs, and pci_dev->driver to be set to NULL. >>>>>> >>>>>> What will happen ? Or this situation will never happen? >>>>>> I'm confuse about this. >>>>> I think that will never happen. Before ->probe(), pm_runtime_get_sync() >>>>> is called, so pci_pm_runtime_xxx() will not be called until >>>>> pm_runtime_put_noidle() is called in ->probe(). And >>>>> should be done as one of the latest actions in >>>>> ->probe(), after the normal probe actions succeeded. >>>> OK, just as your description, it seems OK. >>>> But this is really a issue as I explained in last email. >>>> >>>> So I want to know if there are any side-effect of changing the code >>>> in pci_pm_runtime_xxx() >>>> >>>> if (!pci_dev->driver) >>>> return 0; >>>> to >>>> >>>> if (!dev->driver) >>>> return 0; >>>> >>> If you make this change, we can not put devices into low power state >>> (runtime suspend the device) in ->probe(). That is expected in some >> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ >> This means dev->driver is NULL ?? but pci_dev->driver is set??? >> >> Because if use pci_dev->driver can put into low power state, means >> >> pci_dev->driver is set, but in the situation, use dev->driver will can't, >> >> means dev->driver = null, but I have not find any case that >> >> dev->driver = null, but pci_dev->driver != null; > Sorry I make a mistake here. The dev->driver != null in > local_pci_probe(). We use pci_dev->driver instead of dev->driver in > pci_pm_runtime_xxx() because we want device to be kept in normal power > state (D0) and SUSPENDED state when unbound.The > pm_runtime_put/get_sync in pci_device_remove/local_pci_probe will not > change the power state of the device because of the check in > pci_pm_runtime_xxx(). Yes, you are right, but what am I confuse is that, why check dev->driver in pci_pm_runtime_xxx() can't keep the device in normal power state (D0) and SUSPENDED state when unbound. May be logic issue ? Thanks Mike > >> I know I always been a question guy, i apologize for spend a lot >> time to reply this mail, but I really want to understand it, > Never mind. > > Best Regards, > Huang Ying > > ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: A question about the patch: [PATCH] PCI/PM: Keep runtime PM enabled for unbound PCI devices 2013-11-14 8:37 ` mike @ 2013-11-14 8:54 ` Huang Ying 2013-11-26 5:41 ` Mike Qiu 0 siblings, 1 reply; 15+ messages in thread From: Huang Ying @ 2013-11-14 8:54 UTC (permalink / raw) To: mike; +Cc: Alan Stern, Bjorn Helgaas, linux-pci@vger.kernel.org, linux-pm, rjw On Thu, 2013-11-14 at 16:37 +0800, mike wrote: > On 11/14/2013 04:25 PM, Huang Ying wrote: > > On Thu, 2013-11-14 at 16:12 +0800, mike wrote: > >> On 11/14/2013 03:53 PM, Huang Ying wrote: > >>> On Thu, 2013-11-14 at 15:19 +0800, mike wrote: > >>>> On 11/14/2013 01:59 PM, Huang Ying wrote: > >>>>> On Thu, 2013-11-14 at 11:23 +0800, mike wrote: > >>>>>> On 11/14/2013 03:20 AM, Alan Stern wrote: > >>>>>>> On Wed, 13 Nov 2013, Bjorn Helgaas wrote: > >>>>>>> > >>>>>>>> [+cc Rafael, linux-pm] > >>>>>>>> > >>>>>>>> On Wed, Nov 13, 2013 at 6:09 AM, mike<qiudayu@linux.vnet.ibm.com> wrote: > >>>>>>>>> Hi Huang Ying, > >>>>>>>>> > >>>>>>>>> I see you are the author of this patch, commit id is: > >>>>>>>>> 967577b062417b4e4b8e27b711220f4124f5153a > >>>>>>>>> > >>>>>>>>> I have a question while I try to understand this patch, > >>>>>>>>> So I would very grateful if you or others can give me some reply..... > >>>>>>>>> > >>>>>>>>> ............ > >>>>>>>>> - rc = ddi->drv->probe(ddi->dev, ddi->id); > >>>>>>>>> + pm_runtime_get_sync(dev); > >>>>>>>>> + pci_dev->driver = pci_drv; > >>>>>>>>> ^^^^^^^^^^^^^^^^^^^^^^^^^^ > >>>>>>>>> I see here you make the driver to initialize before probe, > >>>>>>>>> But I have no idea of why you do this change..... > >>>>>>>>> > >>>>>>>>> and I look inside the code, it may be pm_runtime relate?? > >>>>>>> Yes, it is related to runtime PM. In the PCI subsystem, runtime PM > >>>>>>> doesn't do anything unless pci_dev->driver is set. You can see this at > >>>>>>> the start of pci_pm_runtime_suspend(). > >>>>>>> > >>>>>>> Since we want the driver's probe routine to be able to carry out > >>>>>>> runtime PM operations, we have to set pci_dev->driver before the probe > >>>>>>> routine runs. > >>>>>> Is there any situations , like in probe state, pci_dev->driver > >>>>>> has been set. the pci_pm_runtime_xxx() has passed > >>>>>> pci_dev->driver NULL check, but at this point, probe fail > >>>>>> occurs, and pci_dev->driver to be set to NULL. > >>>>>> > >>>>>> What will happen ? Or this situation will never happen? > >>>>>> I'm confuse about this. > >>>>> I think that will never happen. Before ->probe(), pm_runtime_get_sync() > >>>>> is called, so pci_pm_runtime_xxx() will not be called until > >>>>> pm_runtime_put_noidle() is called in ->probe(). And > >>>>> should be done as one of the latest actions in > >>>>> ->probe(), after the normal probe actions succeeded. > >>>> OK, just as your description, it seems OK. > >>>> But this is really a issue as I explained in last email. > >>>> > >>>> So I want to know if there are any side-effect of changing the code > >>>> in pci_pm_runtime_xxx() > >>>> > >>>> if (!pci_dev->driver) > >>>> return 0; > >>>> to > >>>> > >>>> if (!dev->driver) > >>>> return 0; > >>>> > >>> If you make this change, we can not put devices into low power state > >>> (runtime suspend the device) in ->probe(). That is expected in some > >> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > >> This means dev->driver is NULL ?? but pci_dev->driver is set??? > >> > >> Because if use pci_dev->driver can put into low power state, means > >> > >> pci_dev->driver is set, but in the situation, use dev->driver will can't, > >> > >> means dev->driver = null, but I have not find any case that > >> > >> dev->driver = null, but pci_dev->driver != null; > > Sorry I make a mistake here. The dev->driver != null in > > local_pci_probe(). We use pci_dev->driver instead of dev->driver in > > pci_pm_runtime_xxx() because we want device to be kept in normal power > > state (D0) and SUSPENDED state when unbound.The > > pm_runtime_put/get_sync in pci_device_remove/local_pci_probe will not > > change the power state of the device because of the check in > > pci_pm_runtime_xxx(). > Yes, you are right, but what am I confuse is that, why check dev->driver > in pci_pm_runtime_xxx() can't keep the device in normal power > state (D0) and SUSPENDED state when unbound. > > May be logic issue ? Because dev->driver is set before local_pci_probe() and cleared after pci_device_remove(). But we need a flag to be changed in local_pci_probe() and pci_device_remove(). Best Regards, Huang Ying ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: A question about the patch: [PATCH] PCI/PM: Keep runtime PM enabled for unbound PCI devices 2013-11-14 8:54 ` Huang Ying @ 2013-11-26 5:41 ` Mike Qiu 2013-11-26 20:32 ` Rafael J. Wysocki 0 siblings, 1 reply; 15+ messages in thread From: Mike Qiu @ 2013-11-26 5:41 UTC (permalink / raw) To: Huang Ying Cc: Alan Stern, Bjorn Helgaas, linux-pci@vger.kernel.org, linux-pm, rjw On 11/14/2013 04:54 PM, Huang Ying wrote: > On Thu, 2013-11-14 at 16:37 +0800, mike wrote: >> On 11/14/2013 04:25 PM, Huang Ying wrote: >>> On Thu, 2013-11-14 at 16:12 +0800, mike wrote: >>>> On 11/14/2013 03:53 PM, Huang Ying wrote: >>>>> On Thu, 2013-11-14 at 15:19 +0800, mike wrote: >>>>>> On 11/14/2013 01:59 PM, Huang Ying wrote: >>>>>>> On Thu, 2013-11-14 at 11:23 +0800, mike wrote: >>>>>>>> On 11/14/2013 03:20 AM, Alan Stern wrote: >>>>>>>>> On Wed, 13 Nov 2013, Bjorn Helgaas wrote: >>>>>>>>> >>>>>>>>>> [+cc Rafael, linux-pm] >>>>>>>>>> >>>>>>>>>> On Wed, Nov 13, 2013 at 6:09 AM, mike<qiudayu@linux.vnet.ibm.com> wrote: >>>>>>>>>>> Hi Huang Ying, >>>>>>>>>>> >>>>>>>>>>> I see you are the author of this patch, commit id is: >>>>>>>>>>> 967577b062417b4e4b8e27b711220f4124f5153a >>>>>>>>>>> >>>>>>>>>>> I have a question while I try to understand this patch, >>>>>>>>>>> So I would very grateful if you or others can give me some reply..... >>>>>>>>>>> >>>>>>>>>>> ............ >>>>>>>>>>> - rc = ddi->drv->probe(ddi->dev, ddi->id); >>>>>>>>>>> + pm_runtime_get_sync(dev); >>>>>>>>>>> + pci_dev->driver = pci_drv; >>>>>>>>>>> ^^^^^^^^^^^^^^^^^^^^^^^^^^ >>>>>>>>>>> I see here you make the driver to initialize before probe, >>>>>>>>>>> But I have no idea of why you do this change..... >>>>>>>>>>> >>>>>>>>>>> and I look inside the code, it may be pm_runtime relate?? >>>>>>>>> Yes, it is related to runtime PM. In the PCI subsystem, runtime PM >>>>>>>>> doesn't do anything unless pci_dev->driver is set. You can see this at >>>>>>>>> the start of pci_pm_runtime_suspend(). >>>>>>>>> >>>>>>>>> Since we want the driver's probe routine to be able to carry out >>>>>>>>> runtime PM operations, we have to set pci_dev->driver before the probe >>>>>>>>> routine runs. >>>>>>>> Is there any situations , like in probe state, pci_dev->driver >>>>>>>> has been set. the pci_pm_runtime_xxx() has passed >>>>>>>> pci_dev->driver NULL check, but at this point, probe fail >>>>>>>> occurs, and pci_dev->driver to be set to NULL. >>>>>>>> >>>>>>>> What will happen ? Or this situation will never happen? >>>>>>>> I'm confuse about this. >>>>>>> I think that will never happen. Before ->probe(), pm_runtime_get_sync() >>>>>>> is called, so pci_pm_runtime_xxx() will not be called until >>>>>>> pm_runtime_put_noidle() is called in ->probe(). And >>>>>>> should be done as one of the latest actions in >>>>>>> ->probe(), after the normal probe actions succeeded. >>>>>> OK, just as your description, it seems OK. >>>>>> But this is really a issue as I explained in last email. >>>>>> >>>>>> So I want to know if there are any side-effect of changing the code >>>>>> in pci_pm_runtime_xxx() >>>>>> >>>>>> if (!pci_dev->driver) >>>>>> return 0; >>>>>> to >>>>>> >>>>>> if (!dev->driver) >>>>>> return 0; >>>>>> >>>>> If you make this change, we can not put devices into low power state >>>>> (runtime suspend the device) in ->probe(). That is expected in some >>>> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ >>>> This means dev->driver is NULL ?? but pci_dev->driver is set??? >>>> >>>> Because if use pci_dev->driver can put into low power state, means >>>> >>>> pci_dev->driver is set, but in the situation, use dev->driver will can't, >>>> >>>> means dev->driver = null, but I have not find any case that >>>> >>>> dev->driver = null, but pci_dev->driver != null; >>> Sorry I make a mistake here. The dev->driver != null in >>> local_pci_probe(). We use pci_dev->driver instead of dev->driver in >>> pci_pm_runtime_xxx() because we want device to be kept in normal power >>> state (D0) and SUSPENDED state when unbound.The >>> pm_runtime_put/get_sync in pci_device_remove/local_pci_probe will not >>> change the power state of the device because of the check in >>> pci_pm_runtime_xxx(). >> Yes, you are right, but what am I confuse is that, why check dev->driver >> in pci_pm_runtime_xxx() can't keep the device in normal power >> state (D0) and SUSPENDED state when unbound. >> >> May be logic issue ? > Because dev->driver is set before local_pci_probe() and cleared after > pci_device_remove(). But we need a flag to be changed in > local_pci_probe() and pci_device_remove(). Hi Ying, I'm now face one bug, and the root cause is this logic has some problem. The other component calls the ops in driver during probe state, which a lot of critical data struct haven't been setup yet. This never happen in old logic, because dev->driver is unset in probe state, it can check dev->driver to see if the device diver can work. But for new logic it is really a big issue. Shall I add an other flag like 'unsigned int probe_state:1' in struct pci_dev instead of setting dev->driver before probe and change the logic back? Then in pci_pm_runtime_xxx() can check this flag instead of pci_dev->driver. If my logic does not affect your PM logic, I will send out the patch for review. Otherwise I will consider other solutions. Thanks Mike > > Best Regards, > Huang Ying > > ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: A question about the patch: [PATCH] PCI/PM: Keep runtime PM enabled for unbound PCI devices 2013-11-26 5:41 ` Mike Qiu @ 2013-11-26 20:32 ` Rafael J. Wysocki 2013-11-27 5:32 ` Mike Qiu 0 siblings, 1 reply; 15+ messages in thread From: Rafael J. Wysocki @ 2013-11-26 20:32 UTC (permalink / raw) To: Mike Qiu Cc: Huang Ying, Alan Stern, Bjorn Helgaas, linux-pci@vger.kernel.org, linux-pm On Tuesday, November 26, 2013 01:41:13 PM Mike Qiu wrote: > On 11/14/2013 04:54 PM, Huang Ying wrote: > > On Thu, 2013-11-14 at 16:37 +0800, mike wrote: > >> On 11/14/2013 04:25 PM, Huang Ying wrote: > >>> On Thu, 2013-11-14 at 16:12 +0800, mike wrote: > >>>> On 11/14/2013 03:53 PM, Huang Ying wrote: > >>>>> On Thu, 2013-11-14 at 15:19 +0800, mike wrote: > >>>>>> On 11/14/2013 01:59 PM, Huang Ying wrote: > >>>>>>> On Thu, 2013-11-14 at 11:23 +0800, mike wrote: > >>>>>>>> On 11/14/2013 03:20 AM, Alan Stern wrote: > >>>>>>>>> On Wed, 13 Nov 2013, Bjorn Helgaas wrote: > >>>>>>>>> > >>>>>>>>>> [+cc Rafael, linux-pm] > >>>>>>>>>> > >>>>>>>>>> On Wed, Nov 13, 2013 at 6:09 AM, mike<qiudayu@linux.vnet.ibm.com> wrote: > >>>>>>>>>>> Hi Huang Ying, > >>>>>>>>>>> > >>>>>>>>>>> I see you are the author of this patch, commit id is: > >>>>>>>>>>> 967577b062417b4e4b8e27b711220f4124f5153a > >>>>>>>>>>> > >>>>>>>>>>> I have a question while I try to understand this patch, > >>>>>>>>>>> So I would very grateful if you or others can give me some reply..... > >>>>>>>>>>> > >>>>>>>>>>> ............ > >>>>>>>>>>> - rc = ddi->drv->probe(ddi->dev, ddi->id); > >>>>>>>>>>> + pm_runtime_get_sync(dev); > >>>>>>>>>>> + pci_dev->driver = pci_drv; > >>>>>>>>>>> ^^^^^^^^^^^^^^^^^^^^^^^^^^ > >>>>>>>>>>> I see here you make the driver to initialize before probe, > >>>>>>>>>>> But I have no idea of why you do this change..... > >>>>>>>>>>> > >>>>>>>>>>> and I look inside the code, it may be pm_runtime relate?? > >>>>>>>>> Yes, it is related to runtime PM. In the PCI subsystem, runtime PM > >>>>>>>>> doesn't do anything unless pci_dev->driver is set. You can see this at > >>>>>>>>> the start of pci_pm_runtime_suspend(). > >>>>>>>>> > >>>>>>>>> Since we want the driver's probe routine to be able to carry out > >>>>>>>>> runtime PM operations, we have to set pci_dev->driver before the probe > >>>>>>>>> routine runs. > >>>>>>>> Is there any situations , like in probe state, pci_dev->driver > >>>>>>>> has been set. the pci_pm_runtime_xxx() has passed > >>>>>>>> pci_dev->driver NULL check, but at this point, probe fail > >>>>>>>> occurs, and pci_dev->driver to be set to NULL. > >>>>>>>> > >>>>>>>> What will happen ? Or this situation will never happen? > >>>>>>>> I'm confuse about this. > >>>>>>> I think that will never happen. Before ->probe(), pm_runtime_get_sync() > >>>>>>> is called, so pci_pm_runtime_xxx() will not be called until > >>>>>>> pm_runtime_put_noidle() is called in ->probe(). And > >>>>>>> should be done as one of the latest actions in > >>>>>>> ->probe(), after the normal probe actions succeeded. > >>>>>> OK, just as your description, it seems OK. > >>>>>> But this is really a issue as I explained in last email. > >>>>>> > >>>>>> So I want to know if there are any side-effect of changing the code > >>>>>> in pci_pm_runtime_xxx() > >>>>>> > >>>>>> if (!pci_dev->driver) > >>>>>> return 0; > >>>>>> to > >>>>>> > >>>>>> if (!dev->driver) > >>>>>> return 0; > >>>>>> > >>>>> If you make this change, we can not put devices into low power state > >>>>> (runtime suspend the device) in ->probe(). That is expected in some > >>>> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > >>>> This means dev->driver is NULL ?? but pci_dev->driver is set??? > >>>> > >>>> Because if use pci_dev->driver can put into low power state, means > >>>> > >>>> pci_dev->driver is set, but in the situation, use dev->driver will can't, > >>>> > >>>> means dev->driver = null, but I have not find any case that > >>>> > >>>> dev->driver = null, but pci_dev->driver != null; > >>> Sorry I make a mistake here. The dev->driver != null in > >>> local_pci_probe(). We use pci_dev->driver instead of dev->driver in > >>> pci_pm_runtime_xxx() because we want device to be kept in normal power > >>> state (D0) and SUSPENDED state when unbound.The > >>> pm_runtime_put/get_sync in pci_device_remove/local_pci_probe will not > >>> change the power state of the device because of the check in > >>> pci_pm_runtime_xxx(). > >> Yes, you are right, but what am I confuse is that, why check dev->driver > >> in pci_pm_runtime_xxx() can't keep the device in normal power > >> state (D0) and SUSPENDED state when unbound. > >> > >> May be logic issue ? > > Because dev->driver is set before local_pci_probe() and cleared after > > pci_device_remove(). But we need a flag to be changed in > > local_pci_probe() and pci_device_remove(). > Hi Ying, > > I'm now face one bug, and the root cause is this logic has some problem. > > The other component calls the ops in driver during probe state, which a > lot of critical data struct haven't been setup yet. > > This never happen in old logic, because dev->driver is unset in probe > state, it can check dev->driver to see if the device diver can work. But > for new logic it is really a big issue. What is the other component and why is it doing that? Checking dev->driver may not be a correct way to address this issue anyway. Thanks! -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: A question about the patch: [PATCH] PCI/PM: Keep runtime PM enabled for unbound PCI devices 2013-11-26 20:32 ` Rafael J. Wysocki @ 2013-11-27 5:32 ` Mike Qiu 2013-11-27 6:31 ` Huang Ying 0 siblings, 1 reply; 15+ messages in thread From: Mike Qiu @ 2013-11-27 5:32 UTC (permalink / raw) To: Rafael J. Wysocki Cc: Huang Ying, Alan Stern, Bjorn Helgaas, linux-pci@vger.kernel.org, linux-pm On 11/27/2013 04:32 AM, Rafael J. Wysocki wrote: > On Tuesday, November 26, 2013 01:41:13 PM Mike Qiu wrote: >> On 11/14/2013 04:54 PM, Huang Ying wrote: >>> On Thu, 2013-11-14 at 16:37 +0800, mike wrote: >>>> On 11/14/2013 04:25 PM, Huang Ying wrote: >>>>> On Thu, 2013-11-14 at 16:12 +0800, mike wrote: >>>>>> On 11/14/2013 03:53 PM, Huang Ying wrote: >>>>>>> On Thu, 2013-11-14 at 15:19 +0800, mike wrote: >>>>>>>> On 11/14/2013 01:59 PM, Huang Ying wrote: >>>>>>>>> On Thu, 2013-11-14 at 11:23 +0800, mike wrote: >>>>>>>>>> On 11/14/2013 03:20 AM, Alan Stern wrote: >>>>>>>>>>> On Wed, 13 Nov 2013, Bjorn Helgaas wrote: >>>>>>>>>>> >>>>>>>>>>>> [+cc Rafael, linux-pm] >>>>>>>>>>>> >>>>>>>>>>>> On Wed, Nov 13, 2013 at 6:09 AM, mike<qiudayu@linux.vnet.ibm.com> wrote: >>>>>>>>>>>>> Hi Huang Ying, >>>>>>>>>>>>> >>>>>>>>>>>>> I see you are the author of this patch, commit id is: >>>>>>>>>>>>> 967577b062417b4e4b8e27b711220f4124f5153a >>>>>>>>>>>>> >>>>>>>>>>>>> I have a question while I try to understand this patch, >>>>>>>>>>>>> So I would very grateful if you or others can give me some reply..... >>>>>>>>>>>>> >>>>>>>>>>>>> ............ >>>>>>>>>>>>> - rc = ddi->drv->probe(ddi->dev, ddi->id); >>>>>>>>>>>>> + pm_runtime_get_sync(dev); >>>>>>>>>>>>> + pci_dev->driver = pci_drv; >>>>>>>>>>>>> ^^^^^^^^^^^^^^^^^^^^^^^^^^ >>>>>>>>>>>>> I see here you make the driver to initialize before probe, >>>>>>>>>>>>> But I have no idea of why you do this change..... >>>>>>>>>>>>> >>>>>>>>>>>>> and I look inside the code, it may be pm_runtime relate?? >>>>>>>>>>> Yes, it is related to runtime PM. In the PCI subsystem, runtime PM >>>>>>>>>>> doesn't do anything unless pci_dev->driver is set. You can see this at >>>>>>>>>>> the start of pci_pm_runtime_suspend(). >>>>>>>>>>> >>>>>>>>>>> Since we want the driver's probe routine to be able to carry out >>>>>>>>>>> runtime PM operations, we have to set pci_dev->driver before the probe >>>>>>>>>>> routine runs. >>>>>>>>>> Is there any situations , like in probe state, pci_dev->driver >>>>>>>>>> has been set. the pci_pm_runtime_xxx() has passed >>>>>>>>>> pci_dev->driver NULL check, but at this point, probe fail >>>>>>>>>> occurs, and pci_dev->driver to be set to NULL. >>>>>>>>>> >>>>>>>>>> What will happen ? Or this situation will never happen? >>>>>>>>>> I'm confuse about this. >>>>>>>>> I think that will never happen. Before ->probe(), pm_runtime_get_sync() >>>>>>>>> is called, so pci_pm_runtime_xxx() will not be called until >>>>>>>>> pm_runtime_put_noidle() is called in ->probe(). And >>>>>>>>> should be done as one of the latest actions in >>>>>>>>> ->probe(), after the normal probe actions succeeded. >>>>>>>> OK, just as your description, it seems OK. >>>>>>>> But this is really a issue as I explained in last email. >>>>>>>> >>>>>>>> So I want to know if there are any side-effect of changing the code >>>>>>>> in pci_pm_runtime_xxx() >>>>>>>> >>>>>>>> if (!pci_dev->driver) >>>>>>>> return 0; >>>>>>>> to >>>>>>>> >>>>>>>> if (!dev->driver) >>>>>>>> return 0; >>>>>>>> >>>>>>> If you make this change, we can not put devices into low power state >>>>>>> (runtime suspend the device) in ->probe(). That is expected in some >>>>>> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ >>>>>> This means dev->driver is NULL ?? but pci_dev->driver is set??? >>>>>> >>>>>> Because if use pci_dev->driver can put into low power state, means >>>>>> >>>>>> pci_dev->driver is set, but in the situation, use dev->driver will can't, >>>>>> >>>>>> means dev->driver = null, but I have not find any case that >>>>>> >>>>>> dev->driver = null, but pci_dev->driver != null; >>>>> Sorry I make a mistake here. The dev->driver != null in >>>>> local_pci_probe(). We use pci_dev->driver instead of dev->driver in >>>>> pci_pm_runtime_xxx() because we want device to be kept in normal power >>>>> state (D0) and SUSPENDED state when unbound.The >>>>> pm_runtime_put/get_sync in pci_device_remove/local_pci_probe will not >>>>> change the power state of the device because of the check in >>>>> pci_pm_runtime_xxx(). >>>> Yes, you are right, but what am I confuse is that, why check dev->driver >>>> in pci_pm_runtime_xxx() can't keep the device in normal power >>>> state (D0) and SUSPENDED state when unbound. >>>> >>>> May be logic issue ? >>> Because dev->driver is set before local_pci_probe() and cleared after >>> pci_device_remove(). But we need a flag to be changed in >>> local_pci_probe() and pci_device_remove(). >> Hi Ying, >> >> I'm now face one bug, and the root cause is this logic has some problem. >> >> The other component calls the ops in driver during probe state, which a >> lot of critical data struct haven't been setup yet. >> >> This never happen in old logic, because dev->driver is unset in probe >> state, it can check dev->driver to see if the device diver can work. But >> for new logic it is really a big issue. > What is the other component and why is it doing that? Some component like EEH in Power arch, it need to check whether the driver is work or not. In old logic, if probed then dev->driver set, otherwise it will be NULL, it is safe to do so. But in new, it has problem, it can call the driver API, which is very dangerous in probe state, maybe a lot key data structure haven't been setup yet, this lead to the kernel down and machine reboot. Also this can be fixed in driver, like check the driver data it self, this solution needs all the driver fix this issue, It may be a huge program. So we need a new flag I think, or which old flag can we use to solve this issue ? Thanks Mike > > Checking dev->driver may not be a correct way to address this issue anyway. > > Thanks! > ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: A question about the patch: [PATCH] PCI/PM: Keep runtime PM enabled for unbound PCI devices 2013-11-27 5:32 ` Mike Qiu @ 2013-11-27 6:31 ` Huang Ying 2013-11-27 14:15 ` Rafael J. Wysocki 0 siblings, 1 reply; 15+ messages in thread From: Huang Ying @ 2013-11-27 6:31 UTC (permalink / raw) To: Mike Qiu Cc: Rafael J. Wysocki, Alan Stern, Bjorn Helgaas, linux-pci@vger.kernel.org, linux-pm On Wed, 2013-11-27 at 13:32 +0800, Mike Qiu wrote: > On 11/27/2013 04:32 AM, Rafael J. Wysocki wrote: > > On Tuesday, November 26, 2013 01:41:13 PM Mike Qiu wrote: > >> On 11/14/2013 04:54 PM, Huang Ying wrote: > >>> On Thu, 2013-11-14 at 16:37 +0800, mike wrote: > >>>> On 11/14/2013 04:25 PM, Huang Ying wrote: > >>>>> On Thu, 2013-11-14 at 16:12 +0800, mike wrote: > >>>>>> On 11/14/2013 03:53 PM, Huang Ying wrote: > >>>>>>> On Thu, 2013-11-14 at 15:19 +0800, mike wrote: > >>>>>>>> On 11/14/2013 01:59 PM, Huang Ying wrote: > >>>>>>>>> On Thu, 2013-11-14 at 11:23 +0800, mike wrote: > >>>>>>>>>> On 11/14/2013 03:20 AM, Alan Stern wrote: > >>>>>>>>>>> On Wed, 13 Nov 2013, Bjorn Helgaas wrote: > >>>>>>>>>>> > >>>>>>>>>>>> [+cc Rafael, linux-pm] > >>>>>>>>>>>> > >>>>>>>>>>>> On Wed, Nov 13, 2013 at 6:09 AM, mike<qiudayu@linux.vnet.ibm.com> wrote: > >>>>>>>>>>>>> Hi Huang Ying, > >>>>>>>>>>>>> > >>>>>>>>>>>>> I see you are the author of this patch, commit id is: > >>>>>>>>>>>>> 967577b062417b4e4b8e27b711220f4124f5153a > >>>>>>>>>>>>> > >>>>>>>>>>>>> I have a question while I try to understand this patch, > >>>>>>>>>>>>> So I would very grateful if you or others can give me some reply..... > >>>>>>>>>>>>> > >>>>>>>>>>>>> ............ > >>>>>>>>>>>>> - rc = ddi->drv->probe(ddi->dev, ddi->id); > >>>>>>>>>>>>> + pm_runtime_get_sync(dev); > >>>>>>>>>>>>> + pci_dev->driver = pci_drv; > >>>>>>>>>>>>> ^^^^^^^^^^^^^^^^^^^^^^^^^^ > >>>>>>>>>>>>> I see here you make the driver to initialize before probe, > >>>>>>>>>>>>> But I have no idea of why you do this change..... > >>>>>>>>>>>>> > >>>>>>>>>>>>> and I look inside the code, it may be pm_runtime relate?? > >>>>>>>>>>> Yes, it is related to runtime PM. In the PCI subsystem, runtime PM > >>>>>>>>>>> doesn't do anything unless pci_dev->driver is set. You can see this at > >>>>>>>>>>> the start of pci_pm_runtime_suspend(). > >>>>>>>>>>> > >>>>>>>>>>> Since we want the driver's probe routine to be able to carry out > >>>>>>>>>>> runtime PM operations, we have to set pci_dev->driver before the probe > >>>>>>>>>>> routine runs. > >>>>>>>>>> Is there any situations , like in probe state, pci_dev->driver > >>>>>>>>>> has been set. the pci_pm_runtime_xxx() has passed > >>>>>>>>>> pci_dev->driver NULL check, but at this point, probe fail > >>>>>>>>>> occurs, and pci_dev->driver to be set to NULL. > >>>>>>>>>> > >>>>>>>>>> What will happen ? Or this situation will never happen? > >>>>>>>>>> I'm confuse about this. > >>>>>>>>> I think that will never happen. Before ->probe(), pm_runtime_get_sync() > >>>>>>>>> is called, so pci_pm_runtime_xxx() will not be called until > >>>>>>>>> pm_runtime_put_noidle() is called in ->probe(). And > >>>>>>>>> should be done as one of the latest actions in > >>>>>>>>> ->probe(), after the normal probe actions succeeded. > >>>>>>>> OK, just as your description, it seems OK. > >>>>>>>> But this is really a issue as I explained in last email. > >>>>>>>> > >>>>>>>> So I want to know if there are any side-effect of changing the code > >>>>>>>> in pci_pm_runtime_xxx() > >>>>>>>> > >>>>>>>> if (!pci_dev->driver) > >>>>>>>> return 0; > >>>>>>>> to > >>>>>>>> > >>>>>>>> if (!dev->driver) > >>>>>>>> return 0; > >>>>>>>> > >>>>>>> If you make this change, we can not put devices into low power state > >>>>>>> (runtime suspend the device) in ->probe(). That is expected in some > >>>>>> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > >>>>>> This means dev->driver is NULL ?? but pci_dev->driver is set??? > >>>>>> > >>>>>> Because if use pci_dev->driver can put into low power state, means > >>>>>> > >>>>>> pci_dev->driver is set, but in the situation, use dev->driver will can't, > >>>>>> > >>>>>> means dev->driver = null, but I have not find any case that > >>>>>> > >>>>>> dev->driver = null, but pci_dev->driver != null; > >>>>> Sorry I make a mistake here. The dev->driver != null in > >>>>> local_pci_probe(). We use pci_dev->driver instead of dev->driver in > >>>>> pci_pm_runtime_xxx() because we want device to be kept in normal power > >>>>> state (D0) and SUSPENDED state when unbound.The > >>>>> pm_runtime_put/get_sync in pci_device_remove/local_pci_probe will not > >>>>> change the power state of the device because of the check in > >>>>> pci_pm_runtime_xxx(). > >>>> Yes, you are right, but what am I confuse is that, why check dev->driver > >>>> in pci_pm_runtime_xxx() can't keep the device in normal power > >>>> state (D0) and SUSPENDED state when unbound. > >>>> > >>>> May be logic issue ? > >>> Because dev->driver is set before local_pci_probe() and cleared after > >>> pci_device_remove(). But we need a flag to be changed in > >>> local_pci_probe() and pci_device_remove(). > >> Hi Ying, > >> > >> I'm now face one bug, and the root cause is this logic has some problem. > >> > >> The other component calls the ops in driver during probe state, which a > >> lot of critical data struct haven't been setup yet. > >> > >> This never happen in old logic, because dev->driver is unset in probe > >> state, it can check dev->driver to see if the device diver can work. But > >> for new logic it is really a big issue. > > What is the other component and why is it doing that? > > Some component like EEH in Power arch, it need to check whether the > driver is work or not. > > In old logic, if probed then dev->driver set, otherwise it will be NULL, > it is safe to do so. > > But in new, it has problem, it can call the driver API, which is very > dangerous in probe state, maybe a lot key data structure haven't been > setup yet, this lead to the kernel down and machine reboot. Also this > can be fixed in driver, like check the driver data it self, this > solution needs all the driver fix this issue, It may be a huge program. > > So we need a new flag I think, or which old flag can we use to solve > this issue ? I think a flag is not safe for you. Driver may be removed when you operate on it. Better to use device_lock() if possible, which will be held during device probe and driver remove. Best Regards, Huang Ying > Thanks > Mike > > > > Checking dev->driver may not be a correct way to address this issue anyway. > > > > > Thanks! > > > ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: A question about the patch: [PATCH] PCI/PM: Keep runtime PM enabled for unbound PCI devices 2013-11-27 6:31 ` Huang Ying @ 2013-11-27 14:15 ` Rafael J. Wysocki 0 siblings, 0 replies; 15+ messages in thread From: Rafael J. Wysocki @ 2013-11-27 14:15 UTC (permalink / raw) To: Huang Ying Cc: Mike Qiu, Alan Stern, Bjorn Helgaas, linux-pci@vger.kernel.org, linux-pm On Wednesday, November 27, 2013 02:31:32 PM Huang Ying wrote: > On Wed, 2013-11-27 at 13:32 +0800, Mike Qiu wrote: > > On 11/27/2013 04:32 AM, Rafael J. Wysocki wrote: > > > On Tuesday, November 26, 2013 01:41:13 PM Mike Qiu wrote: > > >> On 11/14/2013 04:54 PM, Huang Ying wrote: > > >>> On Thu, 2013-11-14 at 16:37 +0800, mike wrote: > > >>>> On 11/14/2013 04:25 PM, Huang Ying wrote: > > >>>>> On Thu, 2013-11-14 at 16:12 +0800, mike wrote: > > >>>>>> On 11/14/2013 03:53 PM, Huang Ying wrote: > > >>>>>>> On Thu, 2013-11-14 at 15:19 +0800, mike wrote: > > >>>>>>>> On 11/14/2013 01:59 PM, Huang Ying wrote: > > >>>>>>>>> On Thu, 2013-11-14 at 11:23 +0800, mike wrote: > > >>>>>>>>>> On 11/14/2013 03:20 AM, Alan Stern wrote: > > >>>>>>>>>>> On Wed, 13 Nov 2013, Bjorn Helgaas wrote: > > >>>>>>>>>>> > > >>>>>>>>>>>> [+cc Rafael, linux-pm] > > >>>>>>>>>>>> > > >>>>>>>>>>>> On Wed, Nov 13, 2013 at 6:09 AM, mike<qiudayu@linux.vnet.ibm.com> wrote: > > >>>>>>>>>>>>> Hi Huang Ying, > > >>>>>>>>>>>>> > > >>>>>>>>>>>>> I see you are the author of this patch, commit id is: > > >>>>>>>>>>>>> 967577b062417b4e4b8e27b711220f4124f5153a > > >>>>>>>>>>>>> > > >>>>>>>>>>>>> I have a question while I try to understand this patch, > > >>>>>>>>>>>>> So I would very grateful if you or others can give me some reply..... > > >>>>>>>>>>>>> > > >>>>>>>>>>>>> ............ > > >>>>>>>>>>>>> - rc = ddi->drv->probe(ddi->dev, ddi->id); > > >>>>>>>>>>>>> + pm_runtime_get_sync(dev); > > >>>>>>>>>>>>> + pci_dev->driver = pci_drv; > > >>>>>>>>>>>>> ^^^^^^^^^^^^^^^^^^^^^^^^^^ > > >>>>>>>>>>>>> I see here you make the driver to initialize before probe, > > >>>>>>>>>>>>> But I have no idea of why you do this change..... > > >>>>>>>>>>>>> > > >>>>>>>>>>>>> and I look inside the code, it may be pm_runtime relate?? > > >>>>>>>>>>> Yes, it is related to runtime PM. In the PCI subsystem, runtime PM > > >>>>>>>>>>> doesn't do anything unless pci_dev->driver is set. You can see this at > > >>>>>>>>>>> the start of pci_pm_runtime_suspend(). > > >>>>>>>>>>> > > >>>>>>>>>>> Since we want the driver's probe routine to be able to carry out > > >>>>>>>>>>> runtime PM operations, we have to set pci_dev->driver before the probe > > >>>>>>>>>>> routine runs. > > >>>>>>>>>> Is there any situations , like in probe state, pci_dev->driver > > >>>>>>>>>> has been set. the pci_pm_runtime_xxx() has passed > > >>>>>>>>>> pci_dev->driver NULL check, but at this point, probe fail > > >>>>>>>>>> occurs, and pci_dev->driver to be set to NULL. > > >>>>>>>>>> > > >>>>>>>>>> What will happen ? Or this situation will never happen? > > >>>>>>>>>> I'm confuse about this. > > >>>>>>>>> I think that will never happen. Before ->probe(), pm_runtime_get_sync() > > >>>>>>>>> is called, so pci_pm_runtime_xxx() will not be called until > > >>>>>>>>> pm_runtime_put_noidle() is called in ->probe(). And > > >>>>>>>>> should be done as one of the latest actions in > > >>>>>>>>> ->probe(), after the normal probe actions succeeded. > > >>>>>>>> OK, just as your description, it seems OK. > > >>>>>>>> But this is really a issue as I explained in last email. > > >>>>>>>> > > >>>>>>>> So I want to know if there are any side-effect of changing the code > > >>>>>>>> in pci_pm_runtime_xxx() > > >>>>>>>> > > >>>>>>>> if (!pci_dev->driver) > > >>>>>>>> return 0; > > >>>>>>>> to > > >>>>>>>> > > >>>>>>>> if (!dev->driver) > > >>>>>>>> return 0; > > >>>>>>>> > > >>>>>>> If you make this change, we can not put devices into low power state > > >>>>>>> (runtime suspend the device) in ->probe(). That is expected in some > > >>>>>> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > >>>>>> This means dev->driver is NULL ?? but pci_dev->driver is set??? > > >>>>>> > > >>>>>> Because if use pci_dev->driver can put into low power state, means > > >>>>>> > > >>>>>> pci_dev->driver is set, but in the situation, use dev->driver will can't, > > >>>>>> > > >>>>>> means dev->driver = null, but I have not find any case that > > >>>>>> > > >>>>>> dev->driver = null, but pci_dev->driver != null; > > >>>>> Sorry I make a mistake here. The dev->driver != null in > > >>>>> local_pci_probe(). We use pci_dev->driver instead of dev->driver in > > >>>>> pci_pm_runtime_xxx() because we want device to be kept in normal power > > >>>>> state (D0) and SUSPENDED state when unbound.The > > >>>>> pm_runtime_put/get_sync in pci_device_remove/local_pci_probe will not > > >>>>> change the power state of the device because of the check in > > >>>>> pci_pm_runtime_xxx(). > > >>>> Yes, you are right, but what am I confuse is that, why check dev->driver > > >>>> in pci_pm_runtime_xxx() can't keep the device in normal power > > >>>> state (D0) and SUSPENDED state when unbound. > > >>>> > > >>>> May be logic issue ? > > >>> Because dev->driver is set before local_pci_probe() and cleared after > > >>> pci_device_remove(). But we need a flag to be changed in > > >>> local_pci_probe() and pci_device_remove(). > > >> Hi Ying, > > >> > > >> I'm now face one bug, and the root cause is this logic has some problem. > > >> > > >> The other component calls the ops in driver during probe state, which a > > >> lot of critical data struct haven't been setup yet. > > >> > > >> This never happen in old logic, because dev->driver is unset in probe > > >> state, it can check dev->driver to see if the device diver can work. But > > >> for new logic it is really a big issue. > > > What is the other component and why is it doing that? > > > > Some component like EEH in Power arch, it need to check whether the > > driver is work or not. > > > > In old logic, if probed then dev->driver set, otherwise it will be NULL, > > it is safe to do so. > > > > But in new, it has problem, it can call the driver API, which is very > > dangerous in probe state, maybe a lot key data structure haven't been > > setup yet, this lead to the kernel down and machine reboot. Also this > > can be fixed in driver, like check the driver data it self, this > > solution needs all the driver fix this issue, It may be a huge program. > > > > So we need a new flag I think, or which old flag can we use to solve > > this issue ? > > I think a flag is not safe for you. Driver may be removed when you > operate on it. Precisely. The old code is still unsafe although it happens to work in the given test conditions. > Better to use device_lock() if possible, which will be > held during device probe and driver remove. Or generally synchronize it properly. Thanks, Rafael ^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2013-11-27 14:15 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <52837A10.3040301@linux.vnet.ibm.com>
2013-11-13 16:47 ` A question about the patch: [PATCH] PCI/PM: Keep runtime PM enabled for unbound PCI devices Bjorn Helgaas
2013-11-13 19:20 ` Alan Stern
2013-11-14 3:23 ` mike
2013-11-14 5:59 ` Huang Ying
2013-11-14 7:19 ` mike
2013-11-14 7:53 ` Huang Ying
2013-11-14 8:12 ` mike
2013-11-14 8:25 ` Huang Ying
2013-11-14 8:37 ` mike
2013-11-14 8:54 ` Huang Ying
2013-11-26 5:41 ` Mike Qiu
2013-11-26 20:32 ` Rafael J. Wysocki
2013-11-27 5:32 ` Mike Qiu
2013-11-27 6:31 ` Huang Ying
2013-11-27 14:15 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).