From: Bockholdt Arne <a.bockholdt@precitec-optronik.de>
To: Len Brown <lenb@kernel.org>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] intel_idle: Fixed C6 state on Avoton/Rangeley processors
Date: Wed, 27 Nov 2013 07:43:39 +0000 [thread overview]
Message-ID: <1385538219.4577.5.camel@po-d-abo-ubu> (raw)
In-Reply-To: <CAJvTdKm8bcUsnn_=_f_NQzJJ_FgmX6Ch3XDK3un22vwE9_Qh_Q@mail.gmail.com>
On Tue, 2013-11-26 at 13:43 -0500, Len Brown wrote:
> > .desc = "MWAIT 0x51",
> > - .flags = MWAIT2flg(0x58) | CPUIDLE_FLAG_TIME_VALID | CPUIDLE_FLAG_TLB_FLUSHED,
> > + .flags = MWAIT2flg(0x51) | CPUIDLE_FLAG_TIME_VALID | CPUIDLE_FLAG_TLB_FLUSHED,
> > .exit_latency = 15,
> > .target_residency = 45,
>
> Thanks for noticing that .desc and .flags are inconsistent.
> This is my fault -- apparently I e-mailed a version of this patch that
> is older than what I have in my git tree.
>
> No big issue, though, as 0x51 and 0x58 do exactly the same thing in
> AVN hardware.
> Indeed, changing .desc to 0x58 would be fine also.
The Rangeley on my Supermicro A1SRi-2758F board won't enter C6 with
MWAIT flag set to 0x58 but will do that with 0x51. Maybe the missing
turbo mode of the Rangeley ?
Arne
prev parent reply other threads:[~2013-11-27 7:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-26 7:13 [PATCH] intel_idle: Fixed C6 state on Avoton/Rangeley processors Bockholdt Arne
2013-11-26 12:53 ` Bartlomiej Zolnierkiewicz
2013-11-26 13:38 ` [PATCH v2] " Bockholdt Arne
2013-11-26 18:43 ` Len Brown
2013-11-27 7:43 ` Bockholdt Arne [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1385538219.4577.5.camel@po-d-abo-ubu \
--to=a.bockholdt@precitec-optronik.de \
--cc=b.zolnierkie@samsung.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox