From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Galbraith Subject: Re: 50 Watt idle power regression bisected to Linux-3.10 Date: Thu, 12 Dec 2013 05:59:57 +0100 Message-ID: <1386824397.6056.21.camel@marge.simpson.net> References: <20131211113839.GF21683@pd.tnic> <20131211115239.GA21999@twins.programming.kicks-ass.net> <1386764955.12005.60.camel@marge.simpson.net> <20131211124352.GB21999@twins.programming.kicks-ass.net> <20131211134048.GH21683@pd.tnic> <20131211145655.GB4510@gmail.com> <20131211164318.GA2480@laptop.programming.kicks-ass.net> <20131211175036.GC12431@gmail.com> <52A8F073.9040500@zytor.com> <20131211231425.GD8863@pd.tnic> <52A908DB.60902@zytor.com> <1386822357.6056.12.camel@marge.simpson.net> <52A94065.1050103@zytor.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from moutng.kundenserver.de ([212.227.17.10]:58588 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750755Ab3LLFCL (ORCPT ); Thu, 12 Dec 2013 00:02:11 -0500 In-Reply-To: <52A94065.1050103@zytor.com> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: "H. Peter Anvin" Cc: Borislav Petkov , Ingo Molnar , Peter Zijlstra , Thomas Gleixner , Len Brown , Linux PM list , "linux-kernel@vger.kernel.org" , Jeremy Eder , x86@kernel.org On Wed, 2013-12-11 at 20:49 -0800, H. Peter Anvin wrote: > On 12/11/2013 08:25 PM, Mike Galbraith wrote: > > arch/x86/include/asm/mwait.h | 4 ++-- > > arch/x86/kernel/cpu/common.c | 7 ++++--- > > arch/x86/kernel/setup_percpu.c | 1 + > > 3 files changed, 7 insertions(+), 5 deletions(-) > > > > Index: linux-2.6/arch/x86/kernel/cpu/common.c > > =================================================================== > > --- linux-2.6.orig/arch/x86/kernel/cpu/common.c > > +++ linux-2.6/arch/x86/kernel/cpu/common.c > > @@ -65,13 +65,14 @@ void __init setup_cpu_local_masks(void) > > } > > > > /* allocate percpu area for mwait doorbell */ > > -char __percpu *mwait_doorbell; > > +DEFINE_PER_CPU(char *, mwait_doorbell); > > +EXPORT_PER_CPU_SYMBOL(mwait_doorbell); > > > > Sorry, this is wrong. This is NOT a percpu variable, it is a pointer to > a percpu allocation, but the variable itself is not a percpu variable. > This explains your boom. Yeah, I know, I already slapped myself upside the head. (what were you thinking mikie...la la la la la:) -Mike