From: Zhang Rui <rui.zhang@intel.com>
To: josh@joshtriplett.org
Cc: Rashika Kheria <rashika.kheria@gmail.com>,
linux-kernel@vger.kernel.org,
Eduardo Valentin <eduardo.valentin@ti.com>,
linux-pm@vger.kernel.org
Subject: Re: [PATCH] drivers: thermal: Mark function as static in x86_pkg_temp_thermal.c
Date: Thu, 02 Jan 2014 10:35:03 +0800 [thread overview]
Message-ID: <1388630103.3739.71.camel@rzhang1-mobl4> (raw)
In-Reply-To: <20131218184014.GD24229@cloud>
On Wed, 2013-12-18 at 10:40 -0800, josh@joshtriplett.org wrote:
> On Wed, Dec 18, 2013 at 11:16:02PM +0530, Rashika Kheria wrote:
> > Mark function sys_set_trip_temp() as static in x86_pkg_temp_thermal.c
> > because it is not used outside this file.
> >
> > This eliminates the following warning in x86_pkg_temp_thermal.c:
> > drivers/thermal/x86_pkg_temp_thermal.c:218:5: warning: no previous prototype for ‘sys_set_trip_temp’ [-Wmissing-prototypes]
> >
> > Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
>
> Reviewed-by: Josh Triplett <josh@joshtriplett.org>
>
applied.
thanks,
rui
> > drivers/thermal/x86_pkg_temp_thermal.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/thermal/x86_pkg_temp_thermal.c b/drivers/thermal/x86_pkg_temp_thermal.c
> > index 7722cb9..972e1c7 100644
> > --- a/drivers/thermal/x86_pkg_temp_thermal.c
> > +++ b/drivers/thermal/x86_pkg_temp_thermal.c
> > @@ -215,7 +215,7 @@ static int sys_get_trip_temp(struct thermal_zone_device *tzd,
> > return 0;
> > }
> >
> > -int sys_set_trip_temp(struct thermal_zone_device *tzd, int trip,
> > +static int sys_set_trip_temp(struct thermal_zone_device *tzd, int trip,
> > unsigned long temp)
> > {
> > u32 l, h;
> > --
> > 1.7.9.5
> >
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2014-01-02 2:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-18 17:46 [PATCH] drivers: thermal: Mark function as static in x86_pkg_temp_thermal.c Rashika Kheria
2013-12-18 18:40 ` josh
2014-01-02 2:35 ` Zhang Rui [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1388630103.3739.71.camel@rzhang1-mobl4 \
--to=rui.zhang@intel.com \
--cc=eduardo.valentin@ti.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rashika.kheria@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox