From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Zhang Rui <rui.zhang@intel.com>,
Eduardo Valentin <eduardo.valentin@ti.com>,
Simon Horman <horms@verge.net.au>,
Magnus Damm <magnus.damm@gmail.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: linux-sh@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-pm@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@linux-m68k.org>
Subject: [PATCH 3/4] thermal: rcar: Add missing clock handling
Date: Tue, 7 Jan 2014 19:57:15 +0100 [thread overview]
Message-ID: <1389121036-3555-4-git-send-email-geert@linux-m68k.org> (raw)
In-Reply-To: <1389121036-3555-1-git-send-email-geert@linux-m68k.org>
From: Geert Uytterhoeven <geert+renesas@linux-m68k.org>
When using DT to instantiate the rcar-thermal device, it prints the
following error:
rcar_thermal e61f0000.thermal: thermal sensor was broken
Explicitly request and enable the thermal clock to fix this.
Signed-off-by: Geert Uytterhoeven <geert+renesas@linux-m68k.org>
---
drivers/thermal/rcar_thermal.c | 40 +++++++++++++++++++++++++++++++++-------
1 file changed, 33 insertions(+), 7 deletions(-)
diff --git a/drivers/thermal/rcar_thermal.c b/drivers/thermal/rcar_thermal.c
index 88f92e1a9944..a5629500723a 100644
--- a/drivers/thermal/rcar_thermal.c
+++ b/drivers/thermal/rcar_thermal.c
@@ -17,6 +17,7 @@
* with this program; if not, write to the Free Software Foundation, Inc.,
* 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA.
*/
+#include <linux/clk.h>
#include <linux/delay.h>
#include <linux/err.h>
#include <linux/irq.h>
@@ -53,6 +54,7 @@ struct rcar_thermal_common {
struct device *dev;
struct list_head head;
spinlock_t lock;
+ struct clk *clk;
};
struct rcar_thermal_priv {
@@ -378,23 +380,38 @@ static int rcar_thermal_probe(struct platform_device *pdev)
spin_lock_init(&common->lock);
common->dev = dev;
+ common->clk = devm_clk_get(&pdev->dev, NULL);
+ if (IS_ERR(common->clk)) {
+ dev_err(&pdev->dev, "cannot get clock\n");
+ return PTR_ERR(common->clk);
+ }
+
+ ret = clk_prepare(common->clk);
+ if (ret < 0) {
+ dev_err(&pdev->dev, "unable to prepare clock\n");
+ return ret;
+ }
+
+ clk_enable(common->clk);
+
pm_runtime_enable(dev);
pm_runtime_get_sync(dev);
irq = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
if (irq) {
- int ret;
+ int ret2;
/*
* platform has IRQ support.
* Then, drier use common register
*/
- ret = devm_request_irq(dev, irq->start, rcar_thermal_irq, 0,
- dev_name(dev), common);
- if (ret) {
+ ret2 = devm_request_irq(dev, irq->start, rcar_thermal_irq, 0,
+ dev_name(dev), common);
+ if (ret2) {
dev_err(dev, "irq request failed\n ");
- return ret;
+ ret = ret2;
+ goto error_unpm;
}
/*
@@ -402,8 +419,10 @@ static int rcar_thermal_probe(struct platform_device *pdev)
*/
res = platform_get_resource(pdev, IORESOURCE_MEM, mres++);
common->base = devm_ioremap_resource(dev, res);
- if (IS_ERR(common->base))
- return PTR_ERR(common->base);
+ if (IS_ERR(common->base)) {
+ ret = PTR_ERR(common->base);
+ goto error_unpm;
+ }
/* enable temperature comparation */
rcar_thermal_common_write(common, ENR, 0x00030303);
@@ -465,9 +484,13 @@ error_unregister:
rcar_thermal_irq_disable(priv);
}
+error_unpm:
pm_runtime_put_sync(dev);
pm_runtime_disable(dev);
+ clk_disable(common->clk);
+ clk_unprepare(common->clk);
+
return ret;
}
@@ -486,6 +509,9 @@ static int rcar_thermal_remove(struct platform_device *pdev)
pm_runtime_put_sync(dev);
pm_runtime_disable(dev);
+ clk_disable(common->clk);
+ clk_unprepare(common->clk);
+
return 0;
}
--
1.7.9.5
next prev parent reply other threads:[~2014-01-07 18:57 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-07 18:57 [PATCH 0/4] thermal: rcar: Add missing clock handling Geert Uytterhoeven
2014-01-07 18:57 ` [PATCH 1/4] ARM: shmobile: r8a7791: Add thermal clock in device tree Geert Uytterhoeven
2014-01-08 0:20 ` Laurent Pinchart
2014-01-08 0:52 ` Simon Horman
2014-01-07 18:57 ` [PATCH 2/4] ARM: shmobile: r8a7790: " Geert Uytterhoeven
2014-01-08 0:20 ` Laurent Pinchart
2014-01-08 0:52 ` Simon Horman
2014-01-07 18:57 ` Geert Uytterhoeven [this message]
2014-01-07 20:04 ` [PATCH 3/4] thermal: rcar: Add missing clock handling Sergei Shtylyov
2014-01-07 20:57 ` Gerhard Sittig
2014-01-08 12:20 ` Ben Dooks
2014-01-08 1:08 ` Kuninori Morimoto
2014-01-08 10:23 ` Geert Uytterhoeven
2014-01-13 8:57 ` Geert Uytterhoeven
2014-01-14 0:20 ` Kuninori Morimoto
2014-01-14 1:27 ` Simon Horman
2014-01-08 12:23 ` Ben Dooks
2014-01-08 12:58 ` Geert Uytterhoeven
2014-01-07 18:57 ` [PATCH -trivial 4/4] thermal: rcar: Spelling s/delaye/delay/g Geert Uytterhoeven
2014-01-08 0:12 ` Simon Horman
2014-01-17 8:23 ` Zhang Rui
2014-01-07 21:52 ` [PATCH 0/4] thermal: rcar: Add missing clock handling Valentine
2014-01-07 22:13 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1389121036-3555-4-git-send-email-geert@linux-m68k.org \
--to=geert@linux-m68k.org \
--cc=eduardo.valentin@ti.com \
--cc=geert+renesas@linux-m68k.org \
--cc=horms@verge.net.au \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).