From: Fabio Estevam <fabio.estevam@freescale.com>
To: rjw@rjwysocki.net
Cc: viresh.kumar@linaro.org, shawn.guo@linaro.org,
linux-pm@vger.kernel.org, festevam@gmail.com,
Fabio Estevam <fabio.estevam@freescale.com>
Subject: [PATCH v3] cpufreq: Kconfig.arm: Fix unmet direct dependencies
Date: Tue, 18 Feb 2014 10:44:51 -0300 [thread overview]
Message-ID: <1392731091-817-1-git-send-email-fabio.estevam@freescale.com> (raw)
Currently the following warning is generated when building multi_v7_defconfig:
$ make multi_v7_defconfig
warning: (ARM_HIGHBANK_CPUFREQ) selects GENERIC_CPUFREQ_CPU0 which has unmet direct dependencies (ARCH_HAS_CPUFREQ && CPU_FREQ && HAVE_CLK && REGULATOR && OF && THERMAL && CPU_THERMAL)
# configuration written to .config
Instead of forcing the selection of GENERIC_CPUFREQ_CPU0 let's depend on it.
By depending on GENERIC_CPUFREQ_CPU0 we can remove the selection of PM_OPP
and REGULATOR because we have:
config GENERIC_CPUFREQ_CPU0
tristate "Generic CPU0 cpufreq driver"
depends on HAVE_CLK && REGULATOR && OF && THERMAL && CPU_THERMAL
select PM_OPP
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
Changes since v2:
- Only keep the 'depends on GENERIC_CPUFREQ_CPU0' and remove the other
selections
Changes since v1:
- Use 'depends on'
drivers/cpufreq/Kconfig.arm | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
index 3129749..c43e2c2 100644
--- a/drivers/cpufreq/Kconfig.arm
+++ b/drivers/cpufreq/Kconfig.arm
@@ -84,9 +84,7 @@ config ARM_EXYNOS_CPU_FREQ_BOOST_SW
config ARM_HIGHBANK_CPUFREQ
tristate "Calxeda Highbank-based"
depends on ARCH_HIGHBANK
- select GENERIC_CPUFREQ_CPU0
- select PM_OPP
- select REGULATOR
+ depends on GENERIC_CPUFREQ_CPU0
default m
help
--
1.8.1.2
next reply other threads:[~2014-02-18 13:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-18 13:44 Fabio Estevam [this message]
2014-02-19 5:51 ` [PATCH v3] cpufreq: Kconfig.arm: Fix unmet direct dependencies Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1392731091-817-1-git-send-email-fabio.estevam@freescale.com \
--to=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=shawn.guo@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).