[PATCH v3] cpufreq: Kconfig.arm: Fix unmet direct dependencies

[PATCH v3] cpufreq: Kconfig.arm: Fix unmet direct dependencies

[Fabio Estevam]

Currently the following warning is generated when building multi_v7_defconfig:

$ make multi_v7_defconfig 
warning: (ARM_HIGHBANK_CPUFREQ) selects GENERIC_CPUFREQ_CPU0 which has unmet direct dependencies (ARCH_HAS_CPUFREQ && CPU_FREQ && HAVE_CLK && REGULATOR && OF && THERMAL && CPU_THERMAL)
# configuration written to .config

Instead of forcing the selection of GENERIC_CPUFREQ_CPU0 let's depend on it.

By depending on GENERIC_CPUFREQ_CPU0 we can remove the selection of PM_OPP
and REGULATOR because we have:

config GENERIC_CPUFREQ_CPU0
	tristate "Generic CPU0 cpufreq driver"
	depends on HAVE_CLK && REGULATOR && OF && THERMAL && CPU_THERMAL
	select PM_OPP

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
Changes since v2:
- Only keep the 'depends on GENERIC_CPUFREQ_CPU0' and remove the other 
selections
Changes since v1:
- Use 'depends on'

 drivers/cpufreq/Kconfig.arm | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
index 3129749..c43e2c2 100644
--- a/drivers/cpufreq/Kconfig.arm
+++ b/drivers/cpufreq/Kconfig.arm
@@ -84,9 +84,7 @@ config ARM_EXYNOS_CPU_FREQ_BOOST_SW
 config ARM_HIGHBANK_CPUFREQ
 	tristate "Calxeda Highbank-based"
 	depends on ARCH_HIGHBANK
-	select GENERIC_CPUFREQ_CPU0
-	select PM_OPP
-	select REGULATOR
+	depends on GENERIC_CPUFREQ_CPU0
 
 	default m
 	help
-- 
1.8.1.2

Re: [PATCH v3] cpufreq: Kconfig.arm: Fix unmet direct dependencies

[Viresh Kumar]

On 18 February 2014 19:14, Fabio Estevam <fabio.estevam@freescale.com> wrote:
> Currently the following warning is generated when building multi_v7_defconfig:
>
> $ make multi_v7_defconfig
> warning: (ARM_HIGHBANK_CPUFREQ) selects GENERIC_CPUFREQ_CPU0 which has unmet direct dependencies (ARCH_HAS_CPUFREQ && CPU_FREQ && HAVE_CLK && REGULATOR && OF && THERMAL && CPU_THERMAL)
> # configuration written to .config
>
> Instead of forcing the selection of GENERIC_CPUFREQ_CPU0 let's depend on it.
>
> By depending on GENERIC_CPUFREQ_CPU0 we can remove the selection of PM_OPP
> and REGULATOR because we have:
>
> config GENERIC_CPUFREQ_CPU0
>         tristate "Generic CPU0 cpufreq driver"
>         depends on HAVE_CLK && REGULATOR && OF && THERMAL && CPU_THERMAL
>         select PM_OPP
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> Changes since v2:
> - Only keep the 'depends on GENERIC_CPUFREQ_CPU0' and remove the other
> selections
> Changes since v1:
> - Use 'depends on'
>
>  drivers/cpufreq/Kconfig.arm | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
> index 3129749..c43e2c2 100644
> --- a/drivers/cpufreq/Kconfig.arm
> +++ b/drivers/cpufreq/Kconfig.arm
> @@ -84,9 +84,7 @@ config ARM_EXYNOS_CPU_FREQ_BOOST_SW
>  config ARM_HIGHBANK_CPUFREQ
>         tristate "Calxeda Highbank-based"
>         depends on ARCH_HIGHBANK
> -       select GENERIC_CPUFREQ_CPU0
> -       select PM_OPP
> -       select REGULATOR
> +       depends on GENERIC_CPUFREQ_CPU0
>
>         default m
>         help

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>