From: Sebastian Capella <sebastian.capella@linaro.org>
To: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
linaro-kernel@lists.linaro.org,
linux-arm-kernel@lists.infradead.org
Cc: Sebastian Capella <sebastian.capella@linaro.org>,
Russ Dill <Russ.Dill@ti.com>, Ming Lei <ming.lei@canonical.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: [PATCH RFC v1 2/3] Fix hibernation restore hang in freeze_processes
Date: Tue, 18 Feb 2014 17:52:08 -0800 [thread overview]
Message-ID: <1392774729-3235-3-git-send-email-sebastian.capella@linaro.org> (raw)
In-Reply-To: <1392774729-3235-1-git-send-email-sebastian.capella@linaro.org>
During restore, pm_notifier chain are called with
PM_RESTORE_PREPARE. The firmware_class driver handler
fw_pm_notify does not have a handler for this. As a result,
it keeps a reader on the kmod.c umhelper_sem. During
freeze_processes, the call to __usermodehelper_disable tries to
take a write lock on this semaphore and hangs waiting.
Signed-off-by: Sebastian Capella <sebastian.capella@linaro.org>
Cc: Russ Dill <Russ.Dill@ti.com>
Cc: Ming Lei <ming.lei@canonical.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/base/firmware_class.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c
index eb8fb94..e2b51f8 100644
--- a/drivers/base/firmware_class.c
+++ b/drivers/base/firmware_class.c
@@ -1541,6 +1541,7 @@ static int fw_pm_notify(struct notifier_block *notify_block,
switch (mode) {
case PM_HIBERNATION_PREPARE:
case PM_SUSPEND_PREPARE:
+ case PM_RESTORE_PREPARE:
kill_requests_without_uevent();
device_cache_fw_images();
break;
--
1.7.9.5
next prev parent reply other threads:[~2014-02-19 1:52 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-19 1:52 [PATCH RFC v1 0/3] hibernation support on ARM Sebastian Capella
2014-02-19 1:52 ` [PATCH RFC v1 1/3] ARM: Add irq disabled version of soft_restart Sebastian Capella
2014-02-22 10:26 ` Russell King - ARM Linux
2014-02-24 23:13 ` Sebastian Capella
2014-02-25 0:22 ` Sebastian Capella
2014-02-25 7:56 ` Russ Dill
2014-02-25 10:27 ` Thomas Gleixner
2014-02-25 17:15 ` Russ Dill
2014-02-25 23:24 ` Sebastian Capella
2014-02-19 1:52 ` Sebastian Capella [this message]
2014-02-24 7:09 ` [PATCH RFC v1 2/3] Fix hibernation restore hang in freeze_processes Ming Lei
2014-02-19 1:52 ` [PATCH RFC v1 3/3] ARM hibernation / suspend-to-disk Sebastian Capella
2014-02-19 16:12 ` Lorenzo Pieralisi
2014-02-19 19:10 ` Russ Dill
2014-02-20 10:37 ` Lorenzo Pieralisi
2014-02-19 19:33 ` Sebastian Capella
2014-02-20 16:27 ` Lorenzo Pieralisi
2014-02-21 18:39 ` Sebastian Capella
2014-02-21 23:59 ` Sebastian Capella
2014-02-22 4:37 ` Sebastian Capella
2014-02-22 6:46 ` Russ Dill
2014-02-22 10:22 ` Russell King - ARM Linux
2014-02-22 10:16 ` Russell King - ARM Linux
2014-02-22 12:13 ` Lorenzo Pieralisi
2014-02-22 22:30 ` Pavel Machek
2014-02-21 1:01 ` Sebastian Capella
2014-02-22 10:38 ` Russell King - ARM Linux
2014-02-22 12:09 ` Lorenzo Pieralisi
2014-02-22 22:28 ` Pavel Machek
2014-02-23 19:52 ` Sebastian Capella
2014-02-23 20:02 ` Sebastian Capella
2014-02-25 11:32 ` Lorenzo Pieralisi
2014-02-25 17:55 ` Sebastian Capella
2014-02-26 10:24 ` Lorenzo Pieralisi
2014-02-26 17:50 ` Sebastian Capella
2014-02-26 19:03 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1392774729-3235-3-git-send-email-sebastian.capella@linaro.org \
--to=sebastian.capella@linaro.org \
--cc=Russ.Dill@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=ming.lei@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).