From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zhang Rui Subject: Re: [PATCH 2/2] thermal,rcar_thermal: Add dependency on HAS_IOMEM Date: Thu, 27 Feb 2014 14:58:02 +0800 Message-ID: <1393484282.2637.17.camel@rzhang1-mobl4> References: <1390688954-4940-1-git-send-email-richard@nod.at> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from mga09.intel.com ([134.134.136.24]:60648 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750742AbaB0G6X (ORCPT ); Thu, 27 Feb 2014 01:58:23 -0500 In-Reply-To: <1390688954-4940-1-git-send-email-richard@nod.at> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Richard Weinberger Cc: eduardo.valentin@ti.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, horms@verge.net.au, laurent.pinchart+renesas@ideasonboard.com, Kuninori Morimoto On Sat, 2014-01-25 at 23:29 +0100, Richard Weinberger wrote: > Commit beeb5a1e (thermal: rcar-thermal: Enable driver compilation with COMPILE_TEST) > broke build on archs wihout io memory. > > On archs like S390 or um this driver cannot build nor work. > Make it depend on HAS_IOMEM to bypass build failures. > > drivers/thermal/rcar_thermal.c:404: undefined reference to `devm_ioremap_resource' > drivers/thermal/rcar_thermal.c:426: undefined reference to `devm_ioremap_resource' > > Signed-off-by: Richard Weinberger Kuninori, are you okay with this patch? thanks, rui > --- > drivers/thermal/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig > index 35c0664..88efa8f 100644 > --- a/drivers/thermal/Kconfig > +++ b/drivers/thermal/Kconfig > @@ -136,6 +136,7 @@ config SPEAR_THERMAL > config RCAR_THERMAL > tristate "Renesas R-Car thermal driver" > depends on ARCH_SHMOBILE || COMPILE_TEST > + depends on HAS_IO_MEM > help > Enable this to plug the R-Car thermal sensor driver into the Linux > thermal framework.