Re: [PATCH] Thermal: thermal zone governor fix

Javi Merino
2014-02-27T13:41:27Z

Hi Rui,

On Thu, Feb 27, 2014 at 06:47:48AM +0000, Zhang Rui wrote:
> On Thu, 2014-02-27 at 14:41 +0800, Zhang Rui wrote:
> > From cd587add3043ed7bf3347e5d956f65ec8adf04cf Mon Sep 17 00:00:00 2001
> > From: Zhang Rui <rui.zhang@intel.com>
> > Date: Fri, 24 Jan 2014 10:23:19 +0800
> > Subject: [PATCH] Thermal: thermal zone governor fix
>
> oops. forgot to attach the updated version.
>
> thanks,
> rui
>
> From dff1b207825609e73c7722bc79dda0ea29974931 Mon Sep 17 00:00:00 2001
> From: Zhang Rui <rui.zhang@intel.com>
> Date: Fri, 24 Jan 2014 10:23:19 +0800
> Subject: [PATCH] Thermal: thermal zone governor fix
>
> This patch does a cleanup about the thermal zone govenor,
> setting and make the following rule.
> 1. For thermal zone devices that are registered w/o tz->tzp,
> they can use the default thermal governor only.
> 2. For thermal zone devices w/ governor name specified in
> tz->tzp->governor_name, we will use the default govenor
> if the governor specified is not available at the moment,
> and update tz->governor when the matched governor is registered.

Right, but this doesn't solve my problem. What I was trying to say
was that we should get the default governor if tz->tzp->governor_name
is not initialized. of_parse_thermal_zones() calls
thermal_zone_device_register() with a tzp that has an empty
governor_name and ends up with no governor.

I'll send a patch that gets you the default governor if you don't
specify a governor_name in tzp and add your patch on top.

Cheers,
Javi