* Re: [PATCH] cpuidle: governor: menu: move repeated correction factor check to init [not found] ` <2870361.ixyW1GZfvF@vostro.rjw.lan> @ 2014-04-22 9:54 ` Chander Kashyap 2014-04-22 11:24 ` Rafael J. Wysocki 0 siblings, 1 reply; 7+ messages in thread From: Chander Kashyap @ 2014-04-22 9:54 UTC (permalink / raw) To: Rafael J. Wysocki Cc: Tuukka Tikkanen, linux-kernel@vger.kernel.org, rafael.j.wysocki, Daniel Lezcano, linux-pm +cc linux-pm@vger.kernel.org. On 22 April 2014 15:33, Rafael J. Wysocki <rjw@rjwysocki.net> wrote: > On Tuesday, April 22, 2014 08:27:53 AM Chander Kashyap wrote: >> ping > > Please CC cpuidle patches to linux-pm@vger.kernel.org. +cc to linux-pm@vger.kernel.org. Thanks Rafael > > Thanks! > >> On 10 April 2014 19:57, Tuukka Tikkanen <tuukka.tikkanen@linaro.org> wrote: >> > On 10 April 2014 16:43, Chander Kashyap <chander.kashyap@linaro.org> wrote: >> >> In menu_select function we check for correction factor every time. >> >> If it is zero we are initializing to unity. Hence move it to init function >> >> and initialise by unity, hence avoid repeated comparisons. >> >> >> >> Signed-off-by: Chander Kashyap <chander.kashyap@linaro.org> >> >> --- >> >> drivers/cpuidle/governors/menu.c | 15 ++++++++------- >> >> 1 file changed, 8 insertions(+), 7 deletions(-) >> >> >> >> diff --git a/drivers/cpuidle/governors/menu.c b/drivers/cpuidle/governors/menu.c >> >> index cf7f2f0..048f6d9 100644 >> >> --- a/drivers/cpuidle/governors/menu.c >> >> +++ b/drivers/cpuidle/governors/menu.c >> >> @@ -315,13 +315,6 @@ static int menu_select(struct cpuidle_driver *drv, struct cpuidle_device *dev) >> >> multiplier = performance_multiplier(); >> >> >> >> /* >> >> - * if the correction factor is 0 (eg first time init or cpu hotplug >> >> - * etc), we actually want to start out with a unity factor. >> >> - */ >> >> - if (data->correction_factor[data->bucket] == 0) >> >> - data->correction_factor[data->bucket] = RESOLUTION * DECAY; >> >> - >> >> - /* >> >> * Force the result of multiplication to be 64 bits even if both >> >> * operands are 32 bits. >> >> * Make sure to round up for half microseconds. >> >> @@ -453,9 +446,17 @@ static int menu_enable_device(struct cpuidle_driver *drv, >> >> struct cpuidle_device *dev) >> >> { >> >> struct menu_device *data = &per_cpu(menu_devices, dev->cpu); >> >> + int i; >> >> >> >> memset(data, 0, sizeof(struct menu_device)); >> >> >> >> + /* >> >> + * if the correction factor is 0 (eg first time init or cpu hotplug >> >> + * etc), we actually want to start out with a unity factor. >> >> + */ >> >> + for(i = 0; i < BUCKETS; i++) >> >> + data->correction_factor[i] = RESOLUTION * DECAY; >> >> + >> >> return 0; >> >> } >> >> >> >> -- >> >> 1.7.9.5 >> >> >> > >> > Reviewed-by: Tuukka Tikkanen <tuukka.tikkanen@linaro.org> >> >> >> >> > > -- > I speak only for myself. > Rafael J. Wysocki, Intel Open Source Technology Center. -- with warm regards, Chander Kashyap ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] cpuidle: governor: menu: move repeated correction factor check to init 2014-04-22 9:54 ` [PATCH] cpuidle: governor: menu: move repeated correction factor check to init Chander Kashyap @ 2014-04-22 11:24 ` Rafael J. Wysocki 2014-04-22 12:26 ` Chander Kashyap 0 siblings, 1 reply; 7+ messages in thread From: Rafael J. Wysocki @ 2014-04-22 11:24 UTC (permalink / raw) To: Chander Kashyap Cc: Tuukka Tikkanen, linux-kernel@vger.kernel.org, rafael.j.wysocki, Daniel Lezcano, linux-pm On Tuesday, April 22, 2014 03:24:21 PM Chander Kashyap wrote: > +cc > linux-pm@vger.kernel.org. And can you please resend the patch? So that it shows up in Patchwork, for example? > On 22 April 2014 15:33, Rafael J. Wysocki <rjw@rjwysocki.net> wrote: > > On Tuesday, April 22, 2014 08:27:53 AM Chander Kashyap wrote: > >> ping > > > > Please CC cpuidle patches to linux-pm@vger.kernel.org. > > +cc to linux-pm@vger.kernel.org. > Thanks Rafael > > > > > Thanks! > > > >> On 10 April 2014 19:57, Tuukka Tikkanen <tuukka.tikkanen@linaro.org> wrote: > >> > On 10 April 2014 16:43, Chander Kashyap <chander.kashyap@linaro.org> wrote: > >> >> In menu_select function we check for correction factor every time. > >> >> If it is zero we are initializing to unity. Hence move it to init function > >> >> and initialise by unity, hence avoid repeated comparisons. > >> >> > >> >> Signed-off-by: Chander Kashyap <chander.kashyap@linaro.org> > >> >> --- > >> >> drivers/cpuidle/governors/menu.c | 15 ++++++++------- > >> >> 1 file changed, 8 insertions(+), 7 deletions(-) > >> >> > >> >> diff --git a/drivers/cpuidle/governors/menu.c b/drivers/cpuidle/governors/menu.c > >> >> index cf7f2f0..048f6d9 100644 > >> >> --- a/drivers/cpuidle/governors/menu.c > >> >> +++ b/drivers/cpuidle/governors/menu.c > >> >> @@ -315,13 +315,6 @@ static int menu_select(struct cpuidle_driver *drv, struct cpuidle_device *dev) > >> >> multiplier = performance_multiplier(); > >> >> > >> >> /* > >> >> - * if the correction factor is 0 (eg first time init or cpu hotplug > >> >> - * etc), we actually want to start out with a unity factor. > >> >> - */ > >> >> - if (data->correction_factor[data->bucket] == 0) > >> >> - data->correction_factor[data->bucket] = RESOLUTION * DECAY; > >> >> - > >> >> - /* > >> >> * Force the result of multiplication to be 64 bits even if both > >> >> * operands are 32 bits. > >> >> * Make sure to round up for half microseconds. > >> >> @@ -453,9 +446,17 @@ static int menu_enable_device(struct cpuidle_driver *drv, > >> >> struct cpuidle_device *dev) > >> >> { > >> >> struct menu_device *data = &per_cpu(menu_devices, dev->cpu); > >> >> + int i; > >> >> > >> >> memset(data, 0, sizeof(struct menu_device)); > >> >> > >> >> + /* > >> >> + * if the correction factor is 0 (eg first time init or cpu hotplug > >> >> + * etc), we actually want to start out with a unity factor. > >> >> + */ > >> >> + for(i = 0; i < BUCKETS; i++) > >> >> + data->correction_factor[i] = RESOLUTION * DECAY; > >> >> + > >> >> return 0; > >> >> } > >> >> > >> >> -- > >> >> 1.7.9.5 > >> >> > >> > > >> > Reviewed-by: Tuukka Tikkanen <tuukka.tikkanen@linaro.org> > >> > >> > >> > >> > > > > -- > > I speak only for myself. > > Rafael J. Wysocki, Intel Open Source Technology Center. > > > > -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] cpuidle: governor: menu: move repeated correction factor check to init 2014-04-22 11:24 ` Rafael J. Wysocki @ 2014-04-22 12:26 ` Chander Kashyap 2014-04-22 12:38 ` [RESEND][PATCH] " Chander Kashyap 0 siblings, 1 reply; 7+ messages in thread From: Chander Kashyap @ 2014-04-22 12:26 UTC (permalink / raw) To: Rafael J. Wysocki Cc: Tuukka Tikkanen, linux-kernel@vger.kernel.org, rafael.j.wysocki, Daniel Lezcano, linux-pm On 22 April 2014 16:54, Rafael J. Wysocki <rjw@rjwysocki.net> wrote: > On Tuesday, April 22, 2014 03:24:21 PM Chander Kashyap wrote: >> +cc >> linux-pm@vger.kernel.org. > > And can you please resend the patch? So that it shows up in Patchwork, > for example? > Yes i will resend it again. > >> On 22 April 2014 15:33, Rafael J. Wysocki <rjw@rjwysocki.net> wrote: >> > On Tuesday, April 22, 2014 08:27:53 AM Chander Kashyap wrote: >> >> ping >> > >> > Please CC cpuidle patches to linux-pm@vger.kernel.org. >> >> +cc to linux-pm@vger.kernel.org. >> Thanks Rafael >> >> > >> > Thanks! >> > >> >> On 10 April 2014 19:57, Tuukka Tikkanen <tuukka.tikkanen@linaro.org> wrote: >> >> > On 10 April 2014 16:43, Chander Kashyap <chander.kashyap@linaro.org> wrote: >> >> >> In menu_select function we check for correction factor every time. >> >> >> If it is zero we are initializing to unity. Hence move it to init function >> >> >> and initialise by unity, hence avoid repeated comparisons. >> >> >> >> >> >> Signed-off-by: Chander Kashyap <chander.kashyap@linaro.org> >> >> >> --- >> >> >> drivers/cpuidle/governors/menu.c | 15 ++++++++------- >> >> >> 1 file changed, 8 insertions(+), 7 deletions(-) >> >> >> >> >> >> diff --git a/drivers/cpuidle/governors/menu.c b/drivers/cpuidle/governors/menu.c >> >> >> index cf7f2f0..048f6d9 100644 >> >> >> --- a/drivers/cpuidle/governors/menu.c >> >> >> +++ b/drivers/cpuidle/governors/menu.c >> >> >> @@ -315,13 +315,6 @@ static int menu_select(struct cpuidle_driver *drv, struct cpuidle_device *dev) >> >> >> multiplier = performance_multiplier(); >> >> >> >> >> >> /* >> >> >> - * if the correction factor is 0 (eg first time init or cpu hotplug >> >> >> - * etc), we actually want to start out with a unity factor. >> >> >> - */ >> >> >> - if (data->correction_factor[data->bucket] == 0) >> >> >> - data->correction_factor[data->bucket] = RESOLUTION * DECAY; >> >> >> - >> >> >> - /* >> >> >> * Force the result of multiplication to be 64 bits even if both >> >> >> * operands are 32 bits. >> >> >> * Make sure to round up for half microseconds. >> >> >> @@ -453,9 +446,17 @@ static int menu_enable_device(struct cpuidle_driver *drv, >> >> >> struct cpuidle_device *dev) >> >> >> { >> >> >> struct menu_device *data = &per_cpu(menu_devices, dev->cpu); >> >> >> + int i; >> >> >> >> >> >> memset(data, 0, sizeof(struct menu_device)); >> >> >> >> >> >> + /* >> >> >> + * if the correction factor is 0 (eg first time init or cpu hotplug >> >> >> + * etc), we actually want to start out with a unity factor. >> >> >> + */ >> >> >> + for(i = 0; i < BUCKETS; i++) >> >> >> + data->correction_factor[i] = RESOLUTION * DECAY; >> >> >> + >> >> >> return 0; >> >> >> } >> >> >> >> >> >> -- >> >> >> 1.7.9.5 >> >> >> >> >> > >> >> > Reviewed-by: Tuukka Tikkanen <tuukka.tikkanen@linaro.org> >> >> >> >> >> >> >> >> >> > >> > -- >> > I speak only for myself. >> > Rafael J. Wysocki, Intel Open Source Technology Center. >> >> >> >> > > -- > I speak only for myself. > Rafael J. Wysocki, Intel Open Source Technology Center. -- with warm regards, Chander Kashyap ^ permalink raw reply [flat|nested] 7+ messages in thread
* [RESEND][PATCH] cpuidle: governor: menu: move repeated correction factor check to init 2014-04-22 12:26 ` Chander Kashyap @ 2014-04-22 12:38 ` Chander Kashyap 2014-05-16 8:16 ` Chander Kashyap 0 siblings, 1 reply; 7+ messages in thread From: Chander Kashyap @ 2014-04-22 12:38 UTC (permalink / raw) To: rjw Cc: tuukka.tikkanen, rafael.j.wysocki, daniel.lezcano, linux-pm, linux-kernel, Chander Kashyap In menu_select function we check for correction factor every time. If it is zero we are initializing to unity. Hence move it to init function and initialise by unity, hence avoid repeated comparisons. Signed-off-by: Chander Kashyap <chander.kashyap@linaro.org> Reviewed-by: Tuukka Tikkanen <tuukka.tikkanen@linaro.org> --- drivers/cpuidle/governors/menu.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/cpuidle/governors/menu.c b/drivers/cpuidle/governors/menu.c index 71b5232..9b7918c 100644 --- a/drivers/cpuidle/governors/menu.c +++ b/drivers/cpuidle/governors/menu.c @@ -311,13 +311,6 @@ static int menu_select(struct cpuidle_driver *drv, struct cpuidle_device *dev) data->bucket = which_bucket(data->next_timer_us); /* - * if the correction factor is 0 (eg first time init or cpu hotplug - * etc), we actually want to start out with a unity factor. - */ - if (data->correction_factor[data->bucket] == 0) - data->correction_factor[data->bucket] = RESOLUTION * DECAY; - - /* * Force the result of multiplication to be 64 bits even if both * operands are 32 bits. * Make sure to round up for half microseconds. @@ -466,9 +459,17 @@ static int menu_enable_device(struct cpuidle_driver *drv, struct cpuidle_device *dev) { struct menu_device *data = &per_cpu(menu_devices, dev->cpu); + int i; memset(data, 0, sizeof(struct menu_device)); + /* + * if the correction factor is 0 (eg first time init or cpu hotplug + * etc), we actually want to start out with a unity factor. + */ + for(i = 0; i < BUCKETS; i++) + data->correction_factor[i] = RESOLUTION * DECAY; + return 0; } -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [RESEND][PATCH] cpuidle: governor: menu: move repeated correction factor check to init 2014-04-22 12:38 ` [RESEND][PATCH] " Chander Kashyap @ 2014-05-16 8:16 ` Chander Kashyap 2014-05-16 9:46 ` Rafael J. Wysocki 0 siblings, 1 reply; 7+ messages in thread From: Chander Kashyap @ 2014-05-16 8:16 UTC (permalink / raw) To: Rafael J. Wysocki Cc: Tuukka Tikkanen, rafael.j.wysocki, Daniel Lezcano, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Chander Kashyap On 22 April 2014 18:08, Chander Kashyap <chander.kashyap@linaro.org> wrote: > In menu_select function we check for correction factor every time. > If it is zero we are initializing to unity. Hence move it to init function > and initialise by unity, hence avoid repeated comparisons. > > Signed-off-by: Chander Kashyap <chander.kashyap@linaro.org> > Reviewed-by: Tuukka Tikkanen <tuukka.tikkanen@linaro.org> > --- > drivers/cpuidle/governors/menu.c | 15 ++++++++------- > 1 file changed, 8 insertions(+), 7 deletions(-) > > diff --git a/drivers/cpuidle/governors/menu.c b/drivers/cpuidle/governors/menu.c > index 71b5232..9b7918c 100644 > --- a/drivers/cpuidle/governors/menu.c > +++ b/drivers/cpuidle/governors/menu.c > @@ -311,13 +311,6 @@ static int menu_select(struct cpuidle_driver *drv, struct cpuidle_device *dev) > data->bucket = which_bucket(data->next_timer_us); > > /* > - * if the correction factor is 0 (eg first time init or cpu hotplug > - * etc), we actually want to start out with a unity factor. > - */ > - if (data->correction_factor[data->bucket] == 0) > - data->correction_factor[data->bucket] = RESOLUTION * DECAY; > - > - /* > * Force the result of multiplication to be 64 bits even if both > * operands are 32 bits. > * Make sure to round up for half microseconds. > @@ -466,9 +459,17 @@ static int menu_enable_device(struct cpuidle_driver *drv, > struct cpuidle_device *dev) > { > struct menu_device *data = &per_cpu(menu_devices, dev->cpu); > + int i; > > memset(data, 0, sizeof(struct menu_device)); > > + /* > + * if the correction factor is 0 (eg first time init or cpu hotplug > + * etc), we actually want to start out with a unity factor. > + */ > + for(i = 0; i < BUCKETS; i++) > + data->correction_factor[i] = RESOLUTION * DECAY; > + > return 0; > } > ping. > -- > 1.7.9.5 > -- with warm regards, Chander Kashyap ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [RESEND][PATCH] cpuidle: governor: menu: move repeated correction factor check to init 2014-05-16 8:16 ` Chander Kashyap @ 2014-05-16 9:46 ` Rafael J. Wysocki 2014-05-16 9:54 ` Chander Kashyap 0 siblings, 1 reply; 7+ messages in thread From: Rafael J. Wysocki @ 2014-05-16 9:46 UTC (permalink / raw) To: Chander Kashyap, Rafael J. Wysocki Cc: Tuukka Tikkanen, Daniel Lezcano, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org On 5/16/2014 10:16 AM, Chander Kashyap wrote: > On 22 April 2014 18:08, Chander Kashyap <chander.kashyap@linaro.org> wrote: >> In menu_select function we check for correction factor every time. >> If it is zero we are initializing to unity. Hence move it to init function >> and initialise by unity, hence avoid repeated comparisons. >> >> Signed-off-by: Chander Kashyap <chander.kashyap@linaro.org> >> Reviewed-by: Tuukka Tikkanen <tuukka.tikkanen@linaro.org> >> --- >> drivers/cpuidle/governors/menu.c | 15 ++++++++------- >> 1 file changed, 8 insertions(+), 7 deletions(-) >> >> diff --git a/drivers/cpuidle/governors/menu.c b/drivers/cpuidle/governors/menu.c >> index 71b5232..9b7918c 100644 >> --- a/drivers/cpuidle/governors/menu.c >> +++ b/drivers/cpuidle/governors/menu.c >> @@ -311,13 +311,6 @@ static int menu_select(struct cpuidle_driver *drv, struct cpuidle_device *dev) >> data->bucket = which_bucket(data->next_timer_us); >> >> /* >> - * if the correction factor is 0 (eg first time init or cpu hotplug >> - * etc), we actually want to start out with a unity factor. >> - */ >> - if (data->correction_factor[data->bucket] == 0) >> - data->correction_factor[data->bucket] = RESOLUTION * DECAY; >> - >> - /* >> * Force the result of multiplication to be 64 bits even if both >> * operands are 32 bits. >> * Make sure to round up for half microseconds. >> @@ -466,9 +459,17 @@ static int menu_enable_device(struct cpuidle_driver *drv, >> struct cpuidle_device *dev) >> { >> struct menu_device *data = &per_cpu(menu_devices, dev->cpu); >> + int i; >> >> memset(data, 0, sizeof(struct menu_device)); >> >> + /* >> + * if the correction factor is 0 (eg first time init or cpu hotplug >> + * etc), we actually want to start out with a unity factor. >> + */ >> + for(i = 0; i < BUCKETS; i++) >> + data->correction_factor[i] = RESOLUTION * DECAY; >> + >> return 0; >> } >> > ping. I believe this is in linux-next today, care to check? Rafael ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [RESEND][PATCH] cpuidle: governor: menu: move repeated correction factor check to init 2014-05-16 9:46 ` Rafael J. Wysocki @ 2014-05-16 9:54 ` Chander Kashyap 0 siblings, 0 replies; 7+ messages in thread From: Chander Kashyap @ 2014-05-16 9:54 UTC (permalink / raw) To: Rafael J. Wysocki Cc: Rafael J. Wysocki, Tuukka Tikkanen, Daniel Lezcano, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org On 16 May 2014 15:16, Rafael J. Wysocki <rafael.j.wysocki@intel.com> wrote: > On 5/16/2014 10:16 AM, Chander Kashyap wrote: >> >> On 22 April 2014 18:08, Chander Kashyap <chander.kashyap@linaro.org> >> wrote: >>> >>> In menu_select function we check for correction factor every time. >>> If it is zero we are initializing to unity. Hence move it to init >>> function >>> and initialise by unity, hence avoid repeated comparisons. >>> >>> Signed-off-by: Chander Kashyap <chander.kashyap@linaro.org> >>> Reviewed-by: Tuukka Tikkanen <tuukka.tikkanen@linaro.org> >>> --- >>> drivers/cpuidle/governors/menu.c | 15 ++++++++------- >>> 1 file changed, 8 insertions(+), 7 deletions(-) >>> >>> diff --git a/drivers/cpuidle/governors/menu.c >>> b/drivers/cpuidle/governors/menu.c >>> index 71b5232..9b7918c 100644 >>> --- a/drivers/cpuidle/governors/menu.c >>> +++ b/drivers/cpuidle/governors/menu.c >>> @@ -311,13 +311,6 @@ static int menu_select(struct cpuidle_driver *drv, >>> struct cpuidle_device *dev) >>> data->bucket = which_bucket(data->next_timer_us); >>> >>> /* >>> - * if the correction factor is 0 (eg first time init or cpu >>> hotplug >>> - * etc), we actually want to start out with a unity factor. >>> - */ >>> - if (data->correction_factor[data->bucket] == 0) >>> - data->correction_factor[data->bucket] = RESOLUTION * >>> DECAY; >>> - >>> - /* >>> * Force the result of multiplication to be 64 bits even if both >>> * operands are 32 bits. >>> * Make sure to round up for half microseconds. >>> @@ -466,9 +459,17 @@ static int menu_enable_device(struct cpuidle_driver >>> *drv, >>> struct cpuidle_device *dev) >>> { >>> struct menu_device *data = &per_cpu(menu_devices, dev->cpu); >>> + int i; >>> >>> memset(data, 0, sizeof(struct menu_device)); >>> >>> + /* >>> + * if the correction factor is 0 (eg first time init or cpu >>> hotplug >>> + * etc), we actually want to start out with a unity factor. >>> + */ >>> + for(i = 0; i < BUCKETS; i++) >>> + data->correction_factor[i] = RESOLUTION * DECAY; >>> + >>> return 0; >>> } >>> >> ping. > > > I believe this is in linux-next today, care to check? > > Rafael > Thanks, Rafael -- with warm regards, Chander Kashyap ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2014-05-16 9:54 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1397137433-19106-1-git-send-email-chander.kashyap@linaro.org>
[not found] ` <CAG-99FPLOXWnjb_oiDbLmdrYnDnticN9r1drDm_8JHtG=4BSiA@mail.gmail.com>
[not found] ` <CANuQgHFGTkT0h6_FmxRxg4kYQA2NWEuzch1pj4Ec+_XnRHV2EQ@mail.gmail.com>
[not found] ` <2870361.ixyW1GZfvF@vostro.rjw.lan>
2014-04-22 9:54 ` [PATCH] cpuidle: governor: menu: move repeated correction factor check to init Chander Kashyap
2014-04-22 11:24 ` Rafael J. Wysocki
2014-04-22 12:26 ` Chander Kashyap
2014-04-22 12:38 ` [RESEND][PATCH] " Chander Kashyap
2014-05-16 8:16 ` Chander Kashyap
2014-05-16 9:46 ` Rafael J. Wysocki
2014-05-16 9:54 ` Chander Kashyap
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).