From: Morten Rasmussen <morten.rasmussen@arm.com>
To: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
peterz@infradead.org, mingo@kernel.org
Cc: rjw@rjwysocki.net, vincent.guittot@linaro.org,
daniel.lezcano@linaro.org, preeti@linux.vnet.ibm.com,
dietmar.eggemann@arm.com
Subject: [RFC PATCH 12/16] sched: Task wakeup tracking
Date: Fri, 23 May 2014 19:16:39 +0100 [thread overview]
Message-ID: <1400869003-27769-13-git-send-email-morten.rasmussen@arm.com> (raw)
In-Reply-To: <1400869003-27769-1-git-send-email-morten.rasmussen@arm.com>
Track task wakeup rate in wakeup_avg_sum by counting wakeups. Note that
this is _not_ cpu wakeups (idle exits). Task wakeups only cause cpu
wakeups if the cpu is idle when the task wakeup occurs.
The wakeup rate decays over time at the same rate as used for the
existing entity load tracking. Unlike runnable_avg_sum, wakeup_avg_sum
is counting events, not time, and is therefore theoretically unbounded
and should be used with care.
Signed-off-by: Morten Rasmussen <morten.rasmussen@arm.com>
---
include/linux/sched.h | 3 +++
kernel/sched/fair.c | 18 ++++++++++++++++++
2 files changed, 21 insertions(+)
diff --git a/include/linux/sched.h b/include/linux/sched.h
index 727b936..d7b032f 100644
--- a/include/linux/sched.h
+++ b/include/linux/sched.h
@@ -1109,6 +1109,9 @@ struct sched_avg {
u64 last_runnable_update;
s64 decay_count;
unsigned long load_avg_contrib;
+
+ unsigned long last_wakeup_update;
+ u32 wakeup_avg_sum;
};
#ifdef CONFIG_SCHEDSTATS
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 09e5232..39e9cd8 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -679,6 +679,8 @@ void init_task_runnable_average(struct task_struct *p)
p->se.avg.runnable_avg_sum = slice;
p->se.avg.runnable_avg_period = slice;
__update_task_entity_contrib(&p->se);
+
+ p->se.avg.last_wakeup_update = jiffies;
}
#else
void init_task_runnable_average(struct task_struct *p)
@@ -4025,6 +4027,21 @@ static void record_wakee(struct task_struct *p)
}
}
+static void update_wakeup_avg(struct task_struct *p)
+{
+ struct sched_entity *se = &p->se;
+ struct sched_avg *sa = &se->avg;
+ unsigned long now = ACCESS_ONCE(jiffies);
+
+ if (time_after(now, sa->last_wakeup_update)) {
+ sa->wakeup_avg_sum = decay_load(sa->wakeup_avg_sum,
+ jiffies_to_msecs(now - sa->last_wakeup_update));
+ sa->last_wakeup_update = now;
+ }
+
+ sa->wakeup_avg_sum += 1024;
+}
+
static void task_waking_fair(struct task_struct *p)
{
struct sched_entity *se = &p->se;
@@ -4045,6 +4062,7 @@ static void task_waking_fair(struct task_struct *p)
se->vruntime -= min_vruntime;
record_wakee(p);
+ update_wakeup_avg(p);
}
#ifdef CONFIG_FAIR_GROUP_SCHED
--
1.7.9.5
next prev parent reply other threads:[~2014-05-23 18:16 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-23 18:16 [RFC PATCH 00/16] sched: Energy cost model for energy-aware scheduling Morten Rasmussen
2014-05-23 18:16 ` [RFC PATCH 01/16] sched: Documentation for scheduler energy cost model Morten Rasmussen
2014-06-05 8:49 ` Vincent Guittot
2014-06-05 11:35 ` Morten Rasmussen
2014-06-05 15:02 ` Vincent Guittot
2014-05-23 18:16 ` [RFC PATCH 02/16] sched: Introduce CONFIG_SCHED_ENERGY Morten Rasmussen
2014-06-08 6:03 ` Henrik Austad
2014-06-09 10:20 ` Morten Rasmussen
2014-06-10 9:39 ` Peter Zijlstra
2014-06-10 10:06 ` Morten Rasmussen
2014-06-10 10:23 ` Peter Zijlstra
2014-06-10 11:17 ` Henrik Austad
2014-06-10 12:19 ` Peter Zijlstra
2014-06-10 11:24 ` Morten Rasmussen
2014-06-10 12:24 ` Peter Zijlstra
2014-06-10 14:41 ` Morten Rasmussen
2014-05-23 18:16 ` [RFC PATCH 03/16] sched: Introduce sd energy data structures Morten Rasmussen
2014-05-23 18:16 ` [RFC PATCH 04/16] sched: Allocate and initialize sched energy Morten Rasmussen
2014-05-23 18:16 ` [RFC PATCH 05/16] sched: Add sd energy procfs interface Morten Rasmussen
2014-05-23 18:16 ` [RFC PATCH 06/16] arm: topology: Define TC2 sched energy and provide it to scheduler Morten Rasmussen
2014-05-30 12:04 ` Peter Zijlstra
2014-06-02 14:15 ` Morten Rasmussen
2014-06-03 11:41 ` Peter Zijlstra
2014-06-04 13:49 ` Morten Rasmussen
2014-06-03 11:44 ` Peter Zijlstra
2014-06-04 15:42 ` Morten Rasmussen
2014-06-04 16:16 ` Peter Zijlstra
2014-06-06 13:15 ` Morten Rasmussen
2014-06-06 13:43 ` Peter Zijlstra
2014-06-06 14:29 ` Morten Rasmussen
2014-06-12 15:05 ` Vince Weaver
2014-06-03 11:50 ` Peter Zijlstra
2014-06-04 16:02 ` Morten Rasmussen
2014-06-04 17:27 ` Peter Zijlstra
2014-06-04 21:56 ` Rafael J. Wysocki
2014-06-05 6:52 ` Peter Zijlstra
2014-06-05 15:03 ` Dirk Brandewie
2014-06-05 20:29 ` Yuyang Du
2014-06-06 8:05 ` Peter Zijlstra
2014-06-06 0:35 ` Yuyang Du
2014-06-06 10:50 ` Peter Zijlstra
2014-06-06 12:13 ` Ingo Molnar
2014-06-06 12:27 ` Ingo Molnar
2014-06-06 14:11 ` Morten Rasmussen
2014-06-07 2:33 ` Nicolas Pitre
2014-06-09 8:27 ` Morten Rasmussen
2014-06-09 13:22 ` Nicolas Pitre
2014-06-11 11:02 ` Eduardo Valentin
2014-06-11 11:42 ` Morten Rasmussen
2014-06-11 11:43 ` Eduardo Valentin
2014-06-11 13:37 ` Morten Rasmussen
2014-06-07 23:53 ` Yuyang Du
2014-06-07 23:26 ` Yuyang Du
2014-06-09 8:59 ` Morten Rasmussen
2014-06-09 2:15 ` Yuyang Du
2014-06-10 10:16 ` Peter Zijlstra
2014-06-10 17:01 ` Nicolas Pitre
2014-06-10 18:35 ` Yuyang Du
2014-06-06 16:27 ` Jacob Pan
2014-06-06 13:03 ` Morten Rasmussen
2014-06-07 2:52 ` Nicolas Pitre
2014-05-23 18:16 ` [RFC PATCH 07/16] sched: Introduce system-wide sched_energy Morten Rasmussen
2014-05-23 18:16 ` [RFC PATCH 08/16] sched: Introduce SD_SHARE_CAP_STATES sched_domain flag Morten Rasmussen
2014-05-23 18:16 ` [RFC PATCH 09/16] sched, cpufreq: Introduce current cpu compute capacity into scheduler Morten Rasmussen
2014-05-23 18:16 ` [RFC PATCH 10/16] sched, cpufreq: Current compute capacity hack for ARM TC2 Morten Rasmussen
2014-05-23 18:16 ` [RFC PATCH 11/16] sched: Energy model functions Morten Rasmussen
2014-05-23 18:16 ` Morten Rasmussen [this message]
2014-05-23 18:16 ` [RFC PATCH 13/16] sched: Take task wakeups into account in energy estimates Morten Rasmussen
2014-05-23 18:16 ` [RFC PATCH 14/16] sched: Use energy model in select_idle_sibling Morten Rasmussen
2014-05-23 18:16 ` [RFC PATCH 15/16] sched: Use energy to guide wakeup task placement Morten Rasmussen
2014-05-23 18:16 ` [RFC PATCH 16/16] sched: Disable wake_affine to broaden the scope of wakeup target cpus Morten Rasmussen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1400869003-27769-13-git-send-email-morten.rasmussen@arm.com \
--to=morten.rasmussen@arm.com \
--cc=daniel.lezcano@linaro.org \
--cc=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=preeti@linux.vnet.ibm.com \
--cc=rjw@rjwysocki.net \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).