* [PATCH] cpufreq: acpi: Add comment under ACPI_ADR_SPACE_SYSTEM_IO case
@ 2013-10-12 1:36 Viresh Kumar
2013-10-12 13:38 ` Rafael J. Wysocki
0 siblings, 1 reply; 9+ messages in thread
From: Viresh Kumar @ 2013-10-12 1:36 UTC (permalink / raw)
To: rjw; +Cc: linaro-kernel, patches, cpufreq, linux-pm, linux-kernel,
Viresh Kumar
policy->cur is now set by cpufreq core when cpufreq_driver->get() is defined and
so drivers aren't required to set it. When space_id is ACPI_ADR_SPACE_SYSTEM_IO
for acpi cpufreq driver it doesn't set ->get to a valid function pointer and so
policy->cur is required to be set by driver.
This is already followed in acpi-cpufreq driver. This patch adds a comment
describing why we need to set policy->cur from driver.
Suggested-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
This change was requested by Rafael here:
http://www.spinics.net/lists/linux-acpi/msg46748.html
drivers/cpufreq/acpi-cpufreq.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/cpufreq/acpi-cpufreq.c b/drivers/cpufreq/acpi-cpufreq.c
index a8dac7b..8ecd74e 100644
--- a/drivers/cpufreq/acpi-cpufreq.c
+++ b/drivers/cpufreq/acpi-cpufreq.c
@@ -838,6 +838,7 @@ static int acpi_cpufreq_cpu_init(struct cpufreq_policy *policy)
switch (perf->control_register.space_id) {
case ACPI_ADR_SPACE_SYSTEM_IO:
/* Current speed is unknown and not detectable by IO port */
+ /* ->cur wouldn't be set by core as ->get() is NULL */
policy->cur = acpi_cpufreq_guess_freq(data, policy->cpu);
break;
case ACPI_ADR_SPACE_FIXED_HARDWARE:
--
1.7.12.rc2.18.g61b472e
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH] cpufreq: acpi: Add comment under ACPI_ADR_SPACE_SYSTEM_IO case
2013-10-12 1:36 [PATCH] cpufreq: acpi: Add comment under ACPI_ADR_SPACE_SYSTEM_IO case Viresh Kumar
@ 2013-10-12 13:38 ` Rafael J. Wysocki
2013-10-12 15:28 ` Viresh Kumar
0 siblings, 1 reply; 9+ messages in thread
From: Rafael J. Wysocki @ 2013-10-12 13:38 UTC (permalink / raw)
To: Viresh Kumar; +Cc: linaro-kernel, patches, cpufreq, linux-pm, linux-kernel
On Saturday, October 12, 2013 07:06:03 AM Viresh Kumar wrote:
> policy->cur is now set by cpufreq core when cpufreq_driver->get() is defined and
> so drivers aren't required to set it. When space_id is ACPI_ADR_SPACE_SYSTEM_IO
> for acpi cpufreq driver it doesn't set ->get to a valid function pointer and so
> policy->cur is required to be set by driver.
>
> This is already followed in acpi-cpufreq driver. This patch adds a comment
> describing why we need to set policy->cur from driver.
>
> Suggested-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> This change was requested by Rafael here:
> http://www.spinics.net/lists/linux-acpi/msg46748.html
>
> drivers/cpufreq/acpi-cpufreq.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/cpufreq/acpi-cpufreq.c b/drivers/cpufreq/acpi-cpufreq.c
> index a8dac7b..8ecd74e 100644
> --- a/drivers/cpufreq/acpi-cpufreq.c
> +++ b/drivers/cpufreq/acpi-cpufreq.c
> @@ -838,6 +838,7 @@ static int acpi_cpufreq_cpu_init(struct cpufreq_policy *policy)
> switch (perf->control_register.space_id) {
> case ACPI_ADR_SPACE_SYSTEM_IO:
> /* Current speed is unknown and not detectable by IO port */
> + /* ->cur wouldn't be set by core as ->get() is NULL */
Well, please merge it with the existing comment and use the usual format for
comments that are longer than two lines.
> policy->cur = acpi_cpufreq_guess_freq(data, policy->cpu);
> break;
> case ACPI_ADR_SPACE_FIXED_HARDWARE:
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] cpufreq: acpi: Add comment under ACPI_ADR_SPACE_SYSTEM_IO case
2013-10-12 13:38 ` Rafael J. Wysocki
@ 2013-10-12 15:28 ` Viresh Kumar
2013-10-12 20:41 ` Rafael J. Wysocki
0 siblings, 1 reply; 9+ messages in thread
From: Viresh Kumar @ 2013-10-12 15:28 UTC (permalink / raw)
To: Rafael J. Wysocki; +Cc: linaro-kernel, patches, cpufreq, linux-pm, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 2143 bytes --]
On 12/10/2013, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> Well, please merge it with the existing comment and use the usual format
> for comments that are longer than two lines.
I thought these are separate comments and so keeping them separate
might be better, so that this one doesn't get deleted in case somebody
is removing the other one.. and vice versa..
Anyway its fixed in attached commit now :)
commit ecb9ef81b50eb5e8559f7d132ef46803c8272091
Author: Viresh Kumar <viresh.kumar@linaro.org>
Date: Sat Oct 12 07:00:01 2013 +0530
cpufreq: acpi: Add comment under ACPI_ADR_SPACE_SYSTEM_IO case
policy->cur is now set by cpufreq core when cpufreq_driver->get()
is defined and
so drivers aren't required to set it. When space_id is
ACPI_ADR_SPACE_SYSTEM_IO
for acpi cpufreq driver it doesn't set ->get to a valid function
pointer and so
policy->cur is required to be set by driver.
This is already followed in acpi-cpufreq driver. This patch adds a comment
describing why we need to set policy->cur from driver.
Suggested-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
drivers/cpufreq/acpi-cpufreq.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/cpufreq/acpi-cpufreq.c b/drivers/cpufreq/acpi-cpufreq.c
index a8dac7b..d2df543 100644
--- a/drivers/cpufreq/acpi-cpufreq.c
+++ b/drivers/cpufreq/acpi-cpufreq.c
@@ -837,7 +837,12 @@ static int acpi_cpufreq_cpu_init(struct
cpufreq_policy *policy)
switch (perf->control_register.space_id) {
case ACPI_ADR_SPACE_SYSTEM_IO:
- /* Current speed is unknown and not detectable by IO port */
+ /*
+ * Current speed is unknown and not detectable by IO port.
+ * policy->cur wouldn't be set by core as cpufreq_driver->get()
+ * is NULL for this space_id and so we need to set policy->cur
+ * here.
+ */
policy->cur = acpi_cpufreq_guess_freq(data, policy->cpu);
break;
case ACPI_ADR_SPACE_FIXED_HARDWARE:
[-- Attachment #2: 0001-cpufreq-acpi-Add-comment-under-ACPI_ADR_SPACE_SYSTEM.patch --]
[-- Type: text/x-patch, Size: 1727 bytes --]
From ecb9ef81b50eb5e8559f7d132ef46803c8272091 Mon Sep 17 00:00:00 2001
Message-Id: <ecb9ef81b50eb5e8559f7d132ef46803c8272091.1381591429.git.viresh.kumar@linaro.org>
From: Viresh Kumar <viresh.kumar@linaro.org>
Date: Sat, 12 Oct 2013 07:00:01 +0530
Subject: [PATCH] cpufreq: acpi: Add comment under ACPI_ADR_SPACE_SYSTEM_IO
case
policy->cur is now set by cpufreq core when cpufreq_driver->get() is defined and
so drivers aren't required to set it. When space_id is ACPI_ADR_SPACE_SYSTEM_IO
for acpi cpufreq driver it doesn't set ->get to a valid function pointer and so
policy->cur is required to be set by driver.
This is already followed in acpi-cpufreq driver. This patch adds a comment
describing why we need to set policy->cur from driver.
Suggested-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
drivers/cpufreq/acpi-cpufreq.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/cpufreq/acpi-cpufreq.c b/drivers/cpufreq/acpi-cpufreq.c
index a8dac7b..d2df543 100644
--- a/drivers/cpufreq/acpi-cpufreq.c
+++ b/drivers/cpufreq/acpi-cpufreq.c
@@ -837,7 +837,12 @@ static int acpi_cpufreq_cpu_init(struct cpufreq_policy *policy)
switch (perf->control_register.space_id) {
case ACPI_ADR_SPACE_SYSTEM_IO:
- /* Current speed is unknown and not detectable by IO port */
+ /*
+ * Current speed is unknown and not detectable by IO port.
+ * policy->cur wouldn't be set by core as cpufreq_driver->get()
+ * is NULL for this space_id and so we need to set policy->cur
+ * here.
+ */
policy->cur = acpi_cpufreq_guess_freq(data, policy->cpu);
break;
case ACPI_ADR_SPACE_FIXED_HARDWARE:
--
1.7.12.rc2.18.g61b472e
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH] cpufreq: acpi: Add comment under ACPI_ADR_SPACE_SYSTEM_IO case
2013-10-12 15:28 ` Viresh Kumar
@ 2013-10-12 20:41 ` Rafael J. Wysocki
2013-10-13 0:37 ` Viresh Kumar
0 siblings, 1 reply; 9+ messages in thread
From: Rafael J. Wysocki @ 2013-10-12 20:41 UTC (permalink / raw)
To: Viresh Kumar; +Cc: linaro-kernel, patches, cpufreq, linux-pm, linux-kernel
On Saturday, October 12, 2013 08:58:10 PM Viresh Kumar wrote:
> On 12/10/2013, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> > Well, please merge it with the existing comment and use the usual format
> > for comments that are longer than two lines.
>
> I thought these are separate comments and so keeping them separate
> might be better,
No, comments that go like
/* Comment 1. */
/* Comment 2. */
do not even *look* separate.
In general you can do something like
/*
* Comment 1.
*
* Comment 2.
*/
in such cases, but again in this particular case the comments aren't even
logically separate in my opinion. ->
> so that this one doesn't get deleted in case somebody
> is removing the other one.. and vice versa..
>
> Anyway its fixed in attached commit now :)
>
> commit ecb9ef81b50eb5e8559f7d132ef46803c8272091
> Author: Viresh Kumar <viresh.kumar@linaro.org>
> Date: Sat Oct 12 07:00:01 2013 +0530
>
> cpufreq: acpi: Add comment under ACPI_ADR_SPACE_SYSTEM_IO case
>
> policy->cur is now set by cpufreq core when cpufreq_driver->get()
> is defined and
> so drivers aren't required to set it. When space_id is
> ACPI_ADR_SPACE_SYSTEM_IO
> for acpi cpufreq driver it doesn't set ->get to a valid function
> pointer and so
> policy->cur is required to be set by driver.
>
> This is already followed in acpi-cpufreq driver. This patch adds a comment
> describing why we need to set policy->cur from driver.
>
> Suggested-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> drivers/cpufreq/acpi-cpufreq.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/acpi-cpufreq.c b/drivers/cpufreq/acpi-cpufreq.c
> index a8dac7b..d2df543 100644
> --- a/drivers/cpufreq/acpi-cpufreq.c
> +++ b/drivers/cpufreq/acpi-cpufreq.c
> @@ -837,7 +837,12 @@ static int acpi_cpufreq_cpu_init(struct
> cpufreq_policy *policy)
>
> switch (perf->control_register.space_id) {
> case ACPI_ADR_SPACE_SYSTEM_IO:
> - /* Current speed is unknown and not detectable by IO port */
> + /*
> + * Current speed is unknown and not detectable by IO port.
> + * policy->cur wouldn't be set by core as cpufreq_driver->get()
> + * is NULL for this space_id and so we need to set policy->cur
> + * here.
> + */
-> What about this:
/*
* The core will not set policy->cur, because cpufreq_driver->get is NULL,
* so we need to set it here. However, we have to guess it, because the
* current speed is unknown and not detectable via IO ports.
*/
> policy->cur = acpi_cpufreq_guess_freq(data, policy->cpu);
> break;
> case ACPI_ADR_SPACE_FIXED_HARDWARE:
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] cpufreq: acpi: Add comment under ACPI_ADR_SPACE_SYSTEM_IO case
2013-10-12 20:41 ` Rafael J. Wysocki
@ 2013-10-13 0:37 ` Viresh Kumar
2013-10-21 7:13 ` Viresh Kumar
0 siblings, 1 reply; 9+ messages in thread
From: Viresh Kumar @ 2013-10-13 0:37 UTC (permalink / raw)
To: Rafael J. Wysocki; +Cc: linaro-kernel, patches, cpufreq, linux-pm, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 346 bytes --]
On 13/10/2013, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> -> What about this:
>
> /*
> * The core will not set policy->cur, because cpufreq_driver->get is NULL,
> * so we need to set it here. However, we have to guess it, because the
> * current speed is unknown and not detectable via IO ports.
> */
Far better. Attached again. Thanks.
[-- Attachment #2: 0001-cpufreq-acpi-Add-comment-under-ACPI_ADR_SPACE_SYSTEM.patch --]
[-- Type: text/x-patch, Size: 1743 bytes --]
From 055b5d73bef0898d477188372b215cd2ec82fe81 Mon Sep 17 00:00:00 2001
Message-Id: <055b5d73bef0898d477188372b215cd2ec82fe81.1381624602.git.viresh.kumar@linaro.org>
From: Viresh Kumar <viresh.kumar@linaro.org>
Date: Sat, 12 Oct 2013 07:00:01 +0530
Subject: [PATCH] cpufreq: acpi: Add comment under ACPI_ADR_SPACE_SYSTEM_IO
case
policy->cur is now set by cpufreq core when cpufreq_driver->get() is defined and
so drivers aren't required to set it. When space_id is ACPI_ADR_SPACE_SYSTEM_IO
for acpi cpufreq driver it doesn't set ->get to a valid function pointer and so
policy->cur is required to be set by driver.
This is already followed in acpi-cpufreq driver. This patch adds a comment
describing why we need to set policy->cur from driver.
Suggested-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
drivers/cpufreq/acpi-cpufreq.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/cpufreq/acpi-cpufreq.c b/drivers/cpufreq/acpi-cpufreq.c
index a8dac7b..a1717d7 100644
--- a/drivers/cpufreq/acpi-cpufreq.c
+++ b/drivers/cpufreq/acpi-cpufreq.c
@@ -837,7 +837,12 @@ static int acpi_cpufreq_cpu_init(struct cpufreq_policy *policy)
switch (perf->control_register.space_id) {
case ACPI_ADR_SPACE_SYSTEM_IO:
- /* Current speed is unknown and not detectable by IO port */
+ /*
+ * The core will not set policy->cur, because
+ * cpufreq_driver->get is NULL, so we need to set it here.
+ * However, we have to guess it, because the current speed is
+ * unknown and not detectable via IO ports.
+ */
policy->cur = acpi_cpufreq_guess_freq(data, policy->cpu);
break;
case ACPI_ADR_SPACE_FIXED_HARDWARE:
--
1.7.12.rc2.18.g61b472e
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH] cpufreq: acpi: Add comment under ACPI_ADR_SPACE_SYSTEM_IO case
2013-10-13 0:37 ` Viresh Kumar
@ 2013-10-21 7:13 ` Viresh Kumar
2013-10-21 22:39 ` Rafael J. Wysocki
0 siblings, 1 reply; 9+ messages in thread
From: Viresh Kumar @ 2013-10-21 7:13 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Lists linaro-kernel, Patch Tracking, cpufreq@vger.kernel.org,
linux-pm@vger.kernel.org, Linux Kernel Mailing List
[-- Attachment #1: Type: text/plain, Size: 508 bytes --]
On 13 October 2013 06:07, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> On 13/10/2013, Rafael J. Wysocki <rjw@sisk.pl> wrote:
>> -> What about this:
>>
>> /*
>> * The core will not set policy->cur, because cpufreq_driver->get is NULL,
>> * so we need to set it here. However, we have to guess it, because the
>> * current speed is unknown and not detectable via IO ports.
>> */
>
> Far better. Attached again. Thanks.
Have you missed applying this one? Attached again..
[-- Attachment #2: 0001-cpufreq-acpi-Add-comment-under-ACPI_ADR_SPACE_SYSTEM.patch --]
[-- Type: application/octet-stream, Size: 1743 bytes --]
From 055b5d73bef0898d477188372b215cd2ec82fe81 Mon Sep 17 00:00:00 2001
Message-Id: <055b5d73bef0898d477188372b215cd2ec82fe81.1381624602.git.viresh.kumar@linaro.org>
From: Viresh Kumar <viresh.kumar@linaro.org>
Date: Sat, 12 Oct 2013 07:00:01 +0530
Subject: [PATCH] cpufreq: acpi: Add comment under ACPI_ADR_SPACE_SYSTEM_IO
case
policy->cur is now set by cpufreq core when cpufreq_driver->get() is defined and
so drivers aren't required to set it. When space_id is ACPI_ADR_SPACE_SYSTEM_IO
for acpi cpufreq driver it doesn't set ->get to a valid function pointer and so
policy->cur is required to be set by driver.
This is already followed in acpi-cpufreq driver. This patch adds a comment
describing why we need to set policy->cur from driver.
Suggested-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
drivers/cpufreq/acpi-cpufreq.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/cpufreq/acpi-cpufreq.c b/drivers/cpufreq/acpi-cpufreq.c
index a8dac7b..a1717d7 100644
--- a/drivers/cpufreq/acpi-cpufreq.c
+++ b/drivers/cpufreq/acpi-cpufreq.c
@@ -837,7 +837,12 @@ static int acpi_cpufreq_cpu_init(struct cpufreq_policy *policy)
switch (perf->control_register.space_id) {
case ACPI_ADR_SPACE_SYSTEM_IO:
- /* Current speed is unknown and not detectable by IO port */
+ /*
+ * The core will not set policy->cur, because
+ * cpufreq_driver->get is NULL, so we need to set it here.
+ * However, we have to guess it, because the current speed is
+ * unknown and not detectable via IO ports.
+ */
policy->cur = acpi_cpufreq_guess_freq(data, policy->cpu);
break;
case ACPI_ADR_SPACE_FIXED_HARDWARE:
--
1.7.12.rc2.18.g61b472e
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH] cpufreq: acpi: Add comment under ACPI_ADR_SPACE_SYSTEM_IO case
2013-10-21 7:13 ` Viresh Kumar
@ 2013-10-21 22:39 ` Rafael J. Wysocki
2013-10-22 0:42 ` Viresh Kumar
0 siblings, 1 reply; 9+ messages in thread
From: Rafael J. Wysocki @ 2013-10-21 22:39 UTC (permalink / raw)
To: Viresh Kumar
Cc: Lists linaro-kernel, Patch Tracking, cpufreq@vger.kernel.org,
linux-pm@vger.kernel.org, Linux Kernel Mailing List
On Monday, October 21, 2013 12:43:32 PM Viresh Kumar wrote:
> On 13 October 2013 06:07, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> > On 13/10/2013, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> >> -> What about this:
> >>
> >> /*
> >> * The core will not set policy->cur, because cpufreq_driver->get is NULL,
> >> * so we need to set it here. However, we have to guess it, because the
> >> * current speed is unknown and not detectable via IO ports.
> >> */
> >
> > Far better. Attached again. Thanks.
>
> Have you missed applying this one? Attached again..
I don't think I've missed it. It should be commit 1bab64d in my tree.
Thanks!
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] cpufreq: acpi: Add comment under ACPI_ADR_SPACE_SYSTEM_IO case
2013-10-21 22:39 ` Rafael J. Wysocki
@ 2013-10-22 0:42 ` Viresh Kumar
2013-10-22 22:08 ` Rafael J. Wysocki
0 siblings, 1 reply; 9+ messages in thread
From: Viresh Kumar @ 2013-10-22 0:42 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Lists linaro-kernel, Patch Tracking, cpufreq@vger.kernel.org,
linux-pm@vger.kernel.org, Linux Kernel Mailing List
On 22 October 2013 04:09, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> I don't think I've missed it. It should be commit 1bab64d in my tree.
I fetched your tree yesterday and this wasn't there in linux-next or
bleeding-edge branch.. When I fetched it now again, it is there..
Thanks.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] cpufreq: acpi: Add comment under ACPI_ADR_SPACE_SYSTEM_IO case
2013-10-22 0:42 ` Viresh Kumar
@ 2013-10-22 22:08 ` Rafael J. Wysocki
0 siblings, 0 replies; 9+ messages in thread
From: Rafael J. Wysocki @ 2013-10-22 22:08 UTC (permalink / raw)
To: Viresh Kumar, cpufreq@vger.kernel.org
Cc: linux-pm@vger.kernel.org, Linux Kernel Mailing List
On Tuesday, October 22, 2013 06:12:08 AM Viresh Kumar wrote:
> On 22 October 2013 04:09, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> > I don't think I've missed it. It should be commit 1bab64d in my tree.
>
> I fetched your tree yesterday and this wasn't there in linux-next or
> bleeding-edge branch.. When I fetched it now again, it is there..
That's because I pushed an old branch by mistake on Sunday. Sorry about
that.
Thanks!
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2013-10-22 22:08 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-12 1:36 [PATCH] cpufreq: acpi: Add comment under ACPI_ADR_SPACE_SYSTEM_IO case Viresh Kumar
2013-10-12 13:38 ` Rafael J. Wysocki
2013-10-12 15:28 ` Viresh Kumar
2013-10-12 20:41 ` Rafael J. Wysocki
2013-10-13 0:37 ` Viresh Kumar
2013-10-21 7:13 ` Viresh Kumar
2013-10-21 22:39 ` Rafael J. Wysocki
2013-10-22 0:42 ` Viresh Kumar
2013-10-22 22:08 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox