public inbox for linux-pm@vger.kernel.org
 help / color / mirror / Atom feed
From: Derek Basehore <dbasehore@chromium.org>
To: linux-kernel@vger.kernel.org
Cc: linux-pm@vger.kernel.org, Laxman Dewangan <ldewangan@nvidia.com>,
	Ian Campbell <ian.campbell@citrix.com>,
	xen-devel@lists.xenproject.org,
	Derek Basehore <dbasehore@chromium.org>
Subject: [PATCH v1 2/2] Revert "irq: Enable all irqs unconditionally in irq_resume"
Date: Fri, 27 Jun 2014 17:04:25 -0700	[thread overview]
Message-ID: <1403913865-31614-2-git-send-email-dbasehore@chromium.org> (raw)
In-Reply-To: <1403913865-31614-1-git-send-email-dbasehore@chromium.org>

This reverts the fix to IRQF_EARLY_RESUME irqs staying disabled after a suspend
failure. It incorrectly stated that Xen is the only platform that uses this
feature. Some rtc drivers such as rtc-as3722.c use the feature and can have its
irq permanently enabled with the change. The driver does disable/enable the irq
for the rtc alarm, so it needs a different fix which is in "genirq: Fix error
path for resuming irqs"

We should also keep correct enable/disable parity for irqs.

This reverts commit ac01810c9d2814238f08a227062e66a35a0e1ea2.

Signed-off-by: Derek Basehore <dbasehore@chromium.org>
---
 kernel/irq/pm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/irq/pm.c b/kernel/irq/pm.c
index b07dc9c..a5eaf1f 100644
--- a/kernel/irq/pm.c
+++ b/kernel/irq/pm.c
@@ -50,7 +50,7 @@ static void resume_irqs(bool want_early)
 		bool is_early = desc->action &&
 			desc->action->flags & IRQF_EARLY_RESUME;
 
-		if (!is_early && want_early)
+		if (is_early != want_early)
 			continue;
 
 		raw_spin_lock_irqsave(&desc->lock, flags);
-- 
2.0.0.526.g5318336

  reply	other threads:[~2014-06-28  0:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-28  0:04 [PATCH v1 1/2] genirq: Fix error path for resuming irqs Derek Basehore
2014-06-28  0:04 ` Derek Basehore [this message]
2014-07-07 15:33 ` [Xen-devel] " Konrad Rzeszutek Wilk
2014-10-01 20:48   ` dbasehore .
2014-10-01 22:25     ` Rafael J. Wysocki
2014-10-01 22:30       ` Rafael J. Wysocki
2014-10-01 23:01         ` dbasehore .
2014-10-01 23:30           ` Rafael J. Wysocki
2014-10-01 23:45           ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1403913865-31614-2-git-send-email-dbasehore@chromium.org \
    --to=dbasehore@chromium.org \
    --cc=ian.campbell@citrix.com \
    --cc=ldewangan@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox