Re: [PATCHv3 2/7] ARM: mvebu: extend PMSU code to support dynamic frequency scaling

Jason Cooper
2014-07-24T11:11:15Z

On Thu, Jul 24, 2014 at 08:29:02AM +0200, Thomas Petazzoni wrote:
> Dear Mike Turquette,
>
> On Wed, 23 Jul 2014 16:50:26 -0700, Mike Turquette wrote:
>
> > > * registers the frequency operating points supported by the CPU;
> > >
> > > * registers a clock notifier of the CPU clocks. The notifier function
> >
> > Where does this code register a clock notifier callback?
> >
> > > listens to the newly introduced APPLY_RATE_CHANGE event, and uses
> >
> > I don't see APPLY_RATE_CHANGE referenced.
>
> Yes, this is a mistake of the commit log, due to remains of the v2 of
> the patch series. Back in the v2, there was indeed a new clock notifier
> being used. But Stephen Boyd argued against that, and instead suggested
> to use a direct function call, which this v3 implements, as stated in
> the cover letter:
>
> - As suggested by Stephen Boyd, instead of using a new clock notifier
> that somewhat "hides" the dependency of the clk-cpu clock driver on
> the PMSU, use a direct call from the clk-cpu driver to the PMSU
> driver.
>
> The commit log of this commit was not adjusted consequently, and this
> is my fault. Jason, is it still time to change this commit log?

If there are no code changes, I'd prefer not to. We're rather late in
the game.

Even though it's not ideal, the commit in question does have a Link: tag
pointing at the patch email on which this conversation is based. So a
frustrated future developer won't be frustrated long. :)

thx,

Jason.