[PATCH] Cpufreq: ARM IMX6Q: Select PM_OPP

[PATCH] Cpufreq: ARM IMX6Q: Select PM_OPP

[Nicolas Del Piano]

PM_OPP is a library used by several of the existing cpufreq drivers.
ARM IMX6Q cpufreq driver uses this library for its functionality.
Thus, it should be selected in Kconfig.

Reported-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
Signed-off-by: Nicolas Del Piano <ndel314@gmail.com>
---
 drivers/cpufreq/Kconfig.arm |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
index ebac671..8c5cf4b 100644
--- a/drivers/cpufreq/Kconfig.arm
+++ b/drivers/cpufreq/Kconfig.arm
@@ -104,6 +104,7 @@ config ARM_IMX6Q_CPUFREQ
 	tristate "Freescale i.MX6 cpufreq support"
 	depends on ARCH_MXC
 	depends on REGULATOR_ANATOP
+	select PM_OPP
 	help
 	  This adds cpufreq driver support for Freescale i.MX6 series SoCs.
 
-- 
1.7.9.5

Re: [PATCH] Cpufreq: ARM IMX6Q: Select PM_OPP

[Viresh Kumar]

On 14 July 2014 03:29, Nicolas Del Piano <ndel314@gmail.com> wrote:
> PM_OPP is a library used by several of the existing cpufreq drivers.
> ARM IMX6Q cpufreq driver uses this library for its functionality.
> Thus, it should be selected in Kconfig.
>
> Reported-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
> Signed-off-by: Nicolas Del Piano <ndel314@gmail.com>
> ---
>  drivers/cpufreq/Kconfig.arm |    1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
> index ebac671..8c5cf4b 100644
> --- a/drivers/cpufreq/Kconfig.arm
> +++ b/drivers/cpufreq/Kconfig.arm
> @@ -104,6 +104,7 @@ config ARM_IMX6Q_CPUFREQ
>         tristate "Freescale i.MX6 cpufreq support"
>         depends on ARCH_MXC
>         depends on REGULATOR_ANATOP
> +       select PM_OPP
>         help
>           This adds cpufreq driver support for Freescale i.MX6 series SoCs.

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

Re: [PATCH] Cpufreq: ARM IMX6Q: Select PM_OPP

[Ezequiel Garcia]

Nico,

On 13 Jul 06:59 PM, Nicolas Del Piano wrote:
> PM_OPP is a library used by several of the existing cpufreq drivers.
> ARM IMX6Q cpufreq driver uses this library for its functionality.
> Thus, it should be selected in Kconfig.
> 
> Reported-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
> Signed-off-by: Nicolas Del Piano <ndel314@gmail.com>

Thanks for the patch. I have just a very minor nitpick to comment;
if you run a git log, you'll see the subject should be:

"cpufreq: imx6q: Select PM_OPP"

In general, it's better to see the recent commits to find out how to write
the commit title; each driver can have its own style.
-- 
Ezequiel Garcia, VanguardiaSur
www.vanguardiasur.com.ar

Re: [PATCH] Cpufreq: ARM IMX6Q: Select PM_OPP

[Nicolas Del Piano]

El 14/07/14 09:43, Ezequiel Garcia escribió:
> Thanks for the patch. I have just a very minor nitpick to comment;
> if you run a git log, you'll see the subject should be:
>
> "cpufreq: imx6q: Select PM_OPP"
>
> In general, it's better to see the recent commits to find out how to write
> the commit title; each driver can have its own style.

Thanks for the advice Eze! I'll do it next time.

Re: [PATCH] Cpufreq: ARM IMX6Q: Select PM_OPP

[Rafael J. Wysocki]

On Sunday, July 13, 2014 06:59:00 PM Nicolas Del Piano wrote:
> PM_OPP is a library used by several of the existing cpufreq drivers.
> ARM IMX6Q cpufreq driver uses this library for its functionality.
> Thus, it should be selected in Kconfig.
> 
> Reported-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
> Signed-off-by: Nicolas Del Piano <ndel314@gmail.com>

Fixed up the subject, applied.  Thanks!

> ---
>  drivers/cpufreq/Kconfig.arm |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
> index ebac671..8c5cf4b 100644
> --- a/drivers/cpufreq/Kconfig.arm
> +++ b/drivers/cpufreq/Kconfig.arm
> @@ -104,6 +104,7 @@ config ARM_IMX6Q_CPUFREQ
>  	tristate "Freescale i.MX6 cpufreq support"
>  	depends on ARCH_MXC
>  	depends on REGULATOR_ANATOP
> +	select PM_OPP
>  	help
>  	  This adds cpufreq driver support for Freescale i.MX6 series SoCs.
>  
> 

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.