* [PATCH] Cpufreq: ARM IMX6Q: Select PM_OPP
@ 2014-07-13 21:59 Nicolas Del Piano
2014-07-14 4:10 ` Viresh Kumar
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Nicolas Del Piano @ 2014-07-13 21:59 UTC (permalink / raw)
To: rjw; +Cc: viresh.kumar, linux-pm, linux-kernel, ezequiel, Nicolas Del Piano
PM_OPP is a library used by several of the existing cpufreq drivers.
ARM IMX6Q cpufreq driver uses this library for its functionality.
Thus, it should be selected in Kconfig.
Reported-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
Signed-off-by: Nicolas Del Piano <ndel314@gmail.com>
---
drivers/cpufreq/Kconfig.arm | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
index ebac671..8c5cf4b 100644
--- a/drivers/cpufreq/Kconfig.arm
+++ b/drivers/cpufreq/Kconfig.arm
@@ -104,6 +104,7 @@ config ARM_IMX6Q_CPUFREQ
tristate "Freescale i.MX6 cpufreq support"
depends on ARCH_MXC
depends on REGULATOR_ANATOP
+ select PM_OPP
help
This adds cpufreq driver support for Freescale i.MX6 series SoCs.
--
1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] Cpufreq: ARM IMX6Q: Select PM_OPP
2014-07-13 21:59 [PATCH] Cpufreq: ARM IMX6Q: Select PM_OPP Nicolas Del Piano
@ 2014-07-14 4:10 ` Viresh Kumar
2014-07-14 12:43 ` Ezequiel Garcia
2014-07-18 1:04 ` Rafael J. Wysocki
2 siblings, 0 replies; 5+ messages in thread
From: Viresh Kumar @ 2014-07-14 4:10 UTC (permalink / raw)
To: Nicolas Del Piano
Cc: Rafael J. Wysocki, linux-pm@vger.kernel.org,
Linux Kernel Mailing List, ezequiel
On 14 July 2014 03:29, Nicolas Del Piano <ndel314@gmail.com> wrote:
> PM_OPP is a library used by several of the existing cpufreq drivers.
> ARM IMX6Q cpufreq driver uses this library for its functionality.
> Thus, it should be selected in Kconfig.
>
> Reported-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
> Signed-off-by: Nicolas Del Piano <ndel314@gmail.com>
> ---
> drivers/cpufreq/Kconfig.arm | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
> index ebac671..8c5cf4b 100644
> --- a/drivers/cpufreq/Kconfig.arm
> +++ b/drivers/cpufreq/Kconfig.arm
> @@ -104,6 +104,7 @@ config ARM_IMX6Q_CPUFREQ
> tristate "Freescale i.MX6 cpufreq support"
> depends on ARCH_MXC
> depends on REGULATOR_ANATOP
> + select PM_OPP
> help
> This adds cpufreq driver support for Freescale i.MX6 series SoCs.
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Cpufreq: ARM IMX6Q: Select PM_OPP
2014-07-13 21:59 [PATCH] Cpufreq: ARM IMX6Q: Select PM_OPP Nicolas Del Piano
2014-07-14 4:10 ` Viresh Kumar
@ 2014-07-14 12:43 ` Ezequiel Garcia
2014-07-14 13:29 ` Nicolas Del Piano
2014-07-18 1:04 ` Rafael J. Wysocki
2 siblings, 1 reply; 5+ messages in thread
From: Ezequiel Garcia @ 2014-07-14 12:43 UTC (permalink / raw)
To: Nicolas Del Piano; +Cc: rjw, viresh.kumar, linux-pm, linux-kernel
Nico,
On 13 Jul 06:59 PM, Nicolas Del Piano wrote:
> PM_OPP is a library used by several of the existing cpufreq drivers.
> ARM IMX6Q cpufreq driver uses this library for its functionality.
> Thus, it should be selected in Kconfig.
>
> Reported-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
> Signed-off-by: Nicolas Del Piano <ndel314@gmail.com>
Thanks for the patch. I have just a very minor nitpick to comment;
if you run a git log, you'll see the subject should be:
"cpufreq: imx6q: Select PM_OPP"
In general, it's better to see the recent commits to find out how to write
the commit title; each driver can have its own style.
--
Ezequiel Garcia, VanguardiaSur
www.vanguardiasur.com.ar
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Cpufreq: ARM IMX6Q: Select PM_OPP
2014-07-14 12:43 ` Ezequiel Garcia
@ 2014-07-14 13:29 ` Nicolas Del Piano
0 siblings, 0 replies; 5+ messages in thread
From: Nicolas Del Piano @ 2014-07-14 13:29 UTC (permalink / raw)
To: Ezequiel Garcia; +Cc: rjw, viresh.kumar, linux-pm, linux-kernel
El 14/07/14 09:43, Ezequiel Garcia escribió:
> Thanks for the patch. I have just a very minor nitpick to comment;
> if you run a git log, you'll see the subject should be:
>
> "cpufreq: imx6q: Select PM_OPP"
>
> In general, it's better to see the recent commits to find out how to write
> the commit title; each driver can have its own style.
Thanks for the advice Eze! I'll do it next time.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Cpufreq: ARM IMX6Q: Select PM_OPP
2014-07-13 21:59 [PATCH] Cpufreq: ARM IMX6Q: Select PM_OPP Nicolas Del Piano
2014-07-14 4:10 ` Viresh Kumar
2014-07-14 12:43 ` Ezequiel Garcia
@ 2014-07-18 1:04 ` Rafael J. Wysocki
2 siblings, 0 replies; 5+ messages in thread
From: Rafael J. Wysocki @ 2014-07-18 1:04 UTC (permalink / raw)
To: Nicolas Del Piano; +Cc: viresh.kumar, linux-pm, linux-kernel, ezequiel
On Sunday, July 13, 2014 06:59:00 PM Nicolas Del Piano wrote:
> PM_OPP is a library used by several of the existing cpufreq drivers.
> ARM IMX6Q cpufreq driver uses this library for its functionality.
> Thus, it should be selected in Kconfig.
>
> Reported-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
> Signed-off-by: Nicolas Del Piano <ndel314@gmail.com>
Fixed up the subject, applied. Thanks!
> ---
> drivers/cpufreq/Kconfig.arm | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
> index ebac671..8c5cf4b 100644
> --- a/drivers/cpufreq/Kconfig.arm
> +++ b/drivers/cpufreq/Kconfig.arm
> @@ -104,6 +104,7 @@ config ARM_IMX6Q_CPUFREQ
> tristate "Freescale i.MX6 cpufreq support"
> depends on ARCH_MXC
> depends on REGULATOR_ANATOP
> + select PM_OPP
> help
> This adds cpufreq driver support for Freescale i.MX6 series SoCs.
>
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-07-18 0:46 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-13 21:59 [PATCH] Cpufreq: ARM IMX6Q: Select PM_OPP Nicolas Del Piano
2014-07-14 4:10 ` Viresh Kumar
2014-07-14 12:43 ` Ezequiel Garcia
2014-07-14 13:29 ` Nicolas Del Piano
2014-07-18 1:04 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).