* [PATCH] cpufreq: Fix latency for cpufreq_info
@ 2014-07-14 5:01 Nicholas Krause
2014-07-14 6:10 ` Viresh Kumar
0 siblings, 1 reply; 7+ messages in thread
From: Nicholas Krause @ 2014-07-14 5:01 UTC (permalink / raw)
To: rjw; +Cc: viresh.kumar, linux-pm, linux-kernel
This fixes the latency for the cpufreq policy to 1 million nanoseconds
that calls the function pxa_cpu_init for the member of the structure
called cpuinfo.transition_latency.
Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
---
drivers/cpufreq/pxa2xx-cpufreq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/cpufreq/pxa2xx-cpufreq.c b/drivers/cpufreq/pxa2xx-cpufreq.c
index e24269a..e08bb98 100644
--- a/drivers/cpufreq/pxa2xx-cpufreq.c
+++ b/drivers/cpufreq/pxa2xx-cpufreq.c
@@ -372,7 +372,7 @@ static int pxa_cpufreq_init(struct cpufreq_policy *policy)
init_sdram_rows();
/* set default policy and cpuinfo */
- policy->cpuinfo.transition_latency = 1000; /* FIXME: 1 ms, assumed */
+ policy->cpuinfo.transition_latency = 1000, 000;
/* Generate pxa25x the run cpufreq_frequency_table struct */
for (i = 0; i < NUM_PXA25x_RUN_FREQS; i++) {
--
1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] cpufreq: Fix latency for cpufreq_info
2014-07-14 5:01 [PATCH] cpufreq: Fix latency for cpufreq_info Nicholas Krause
@ 2014-07-14 6:10 ` Viresh Kumar
2014-07-14 6:25 ` Nick Krause
0 siblings, 1 reply; 7+ messages in thread
From: Viresh Kumar @ 2014-07-14 6:10 UTC (permalink / raw)
To: Nicholas Krause
Cc: Rafael J. Wysocki, linux-pm@vger.kernel.org,
Linux Kernel Mailing List
On 14 July 2014 10:31, Nicholas Krause <xerofoify@gmail.com> wrote:
> This fixes the latency for the cpufreq policy to 1 million nanoseconds
> that calls the function pxa_cpu_init for the member of the structure
> called cpuinfo.transition_latency.
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
> drivers/cpufreq/pxa2xx-cpufreq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/pxa2xx-cpufreq.c b/drivers/cpufreq/pxa2xx-cpufreq.c
> index e24269a..e08bb98 100644
> --- a/drivers/cpufreq/pxa2xx-cpufreq.c
> +++ b/drivers/cpufreq/pxa2xx-cpufreq.c
> @@ -372,7 +372,7 @@ static int pxa_cpufreq_init(struct cpufreq_policy *policy)
> init_sdram_rows();
>
> /* set default policy and cpuinfo */
> - policy->cpuinfo.transition_latency = 1000; /* FIXME: 1 ms, assumed */
> + policy->cpuinfo.transition_latency = 1000, 000;
Have you tried testing this at all? This patch wouldn't change anything.
Still 1000 will get assigned to latency :)
Get rid of the comma.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] cpufreq: Fix latency for cpufreq_info
2014-07-14 6:10 ` Viresh Kumar
@ 2014-07-14 6:25 ` Nick Krause
0 siblings, 0 replies; 7+ messages in thread
From: Nick Krause @ 2014-07-14 6:25 UTC (permalink / raw)
To: Viresh Kumar
Cc: Rafael J. Wysocki, linux-pm@vger.kernel.org,
Linux Kernel Mailing List
On Mon, Jul 14, 2014 at 2:10 AM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> On 14 July 2014 10:31, Nicholas Krause <xerofoify@gmail.com> wrote:
>> This fixes the latency for the cpufreq policy to 1 million nanoseconds
>> that calls the function pxa_cpu_init for the member of the structure
>> called cpuinfo.transition_latency.
>>
>> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
>> ---
>> drivers/cpufreq/pxa2xx-cpufreq.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/cpufreq/pxa2xx-cpufreq.c b/drivers/cpufreq/pxa2xx-cpufreq.c
>> index e24269a..e08bb98 100644
>> --- a/drivers/cpufreq/pxa2xx-cpufreq.c
>> +++ b/drivers/cpufreq/pxa2xx-cpufreq.c
>> @@ -372,7 +372,7 @@ static int pxa_cpufreq_init(struct cpufreq_policy *policy)
>> init_sdram_rows();
>>
>> /* set default policy and cpuinfo */
>> - policy->cpuinfo.transition_latency = 1000; /* FIXME: 1 ms, assumed */
>> + policy->cpuinfo.transition_latency = 1000, 000;
>
> Have you tried testing this at all? This patch wouldn't change anything.
> Still 1000 will get assigned to latency :)
>
> Get rid of the comma.
Sure , sorry about the comma. I am resending this patch to you fixed.
Cheers Nick
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] cpufreq: Fix latency for cpufreq_info
@ 2014-07-14 6:28 Nicholas Krause
2014-07-14 6:30 ` Viresh Kumar
0 siblings, 1 reply; 7+ messages in thread
From: Nicholas Krause @ 2014-07-14 6:28 UTC (permalink / raw)
To: rjw; +Cc: viresh.kumar, linux-pm, linux-kernel
This fixes the latency for the cpufreq policy to 1 million nanoseconds
that calls the function pxa_cpu_init for the member of the structure
called cpuinfo.transition_latency.
Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
---
drivers/cpufreq/pxa2xx-cpufreq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/cpufreq/pxa2xx-cpufreq.c b/drivers/cpufreq/pxa2xx-cpufreq.c
index e24269a..e08bb98 100644
--- a/drivers/cpufreq/pxa2xx-cpufreq.c
+++ b/drivers/cpufreq/pxa2xx-cpufreq.c
@@ -372,7 +372,7 @@ static int pxa_cpufreq_init(struct cpufreq_policy *policy)
init_sdram_rows();
/* set default policy and cpuinfo */
- policy->cpuinfo.transition_latency = 1000; /* FIXME: 1 ms, assumed */
+ policy->cpuinfo.transition_latency = 1000000;
/* Generate pxa25x the run cpufreq_frequency_table struct */
for (i = 0; i < NUM_PXA25x_RUN_FREQS; i++) {
--
1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] cpufreq: Fix latency for cpufreq_info
2014-07-14 6:28 Nicholas Krause
@ 2014-07-14 6:30 ` Viresh Kumar
2014-07-25 5:36 ` pramod gurav
0 siblings, 1 reply; 7+ messages in thread
From: Viresh Kumar @ 2014-07-14 6:30 UTC (permalink / raw)
To: Nicholas Krause
Cc: Rafael J. Wysocki, linux-pm@vger.kernel.org,
Linux Kernel Mailing List
On 14 July 2014 11:58, Nicholas Krause <xerofoify@gmail.com> wrote:
> This fixes the latency for the cpufreq policy to 1 million nanoseconds
> that calls the function pxa_cpu_init for the member of the structure
> called cpuinfo.transition_latency.
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
> drivers/cpufreq/pxa2xx-cpufreq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/pxa2xx-cpufreq.c b/drivers/cpufreq/pxa2xx-cpufreq.c
> index e24269a..e08bb98 100644
> --- a/drivers/cpufreq/pxa2xx-cpufreq.c
> +++ b/drivers/cpufreq/pxa2xx-cpufreq.c
> @@ -372,7 +372,7 @@ static int pxa_cpufreq_init(struct cpufreq_policy *policy)
> init_sdram_rows();
>
> /* set default policy and cpuinfo */
> - policy->cpuinfo.transition_latency = 1000; /* FIXME: 1 ms, assumed */
> + policy->cpuinfo.transition_latency = 1000000;
>
> /* Generate pxa25x the run cpufreq_frequency_table struct */
> for (i = 0; i < NUM_PXA25x_RUN_FREQS; i++) {
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] cpufreq: Fix latency for cpufreq_info
2014-07-14 6:30 ` Viresh Kumar
@ 2014-07-25 5:36 ` pramod gurav
2014-07-25 23:06 ` Nick Krause
0 siblings, 1 reply; 7+ messages in thread
From: pramod gurav @ 2014-07-25 5:36 UTC (permalink / raw)
To: Viresh Kumar
Cc: Nicholas Krause, Rafael J. Wysocki, linux-pm@vger.kernel.org,
Linux Kernel Mailing List
Viresh,
Be careful when you ACK Nick's patches. He has confessed he has no
idea how to build test a kernel. His patches are NOT AT ALL build
tested. And some of his patches are being reverted for causing
problems in build and all. He looks for FIXME and removes/edits the
code as per the comments. Just be careful.
On Mon, Jul 14, 2014 at 12:00 PM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> On 14 July 2014 11:58, Nicholas Krause <xerofoify@gmail.com> wrote:
>> This fixes the latency for the cpufreq policy to 1 million nanoseconds
>> that calls the function pxa_cpu_init for the member of the structure
>> called cpuinfo.transition_latency.
>>
>> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
>> ---
>> drivers/cpufreq/pxa2xx-cpufreq.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/cpufreq/pxa2xx-cpufreq.c b/drivers/cpufreq/pxa2xx-cpufreq.c
>> index e24269a..e08bb98 100644
>> --- a/drivers/cpufreq/pxa2xx-cpufreq.c
>> +++ b/drivers/cpufreq/pxa2xx-cpufreq.c
>> @@ -372,7 +372,7 @@ static int pxa_cpufreq_init(struct cpufreq_policy *policy)
>> init_sdram_rows();
>>
>> /* set default policy and cpuinfo */
>> - policy->cpuinfo.transition_latency = 1000; /* FIXME: 1 ms, assumed */
>> + policy->cpuinfo.transition_latency = 1000000;
>>
>> /* Generate pxa25x the run cpufreq_frequency_table struct */
>> for (i = 0; i < NUM_PXA25x_RUN_FREQS; i++) {
>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Thanks and Regards
Pramod
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] cpufreq: Fix latency for cpufreq_info
2014-07-25 5:36 ` pramod gurav
@ 2014-07-25 23:06 ` Nick Krause
0 siblings, 0 replies; 7+ messages in thread
From: Nick Krause @ 2014-07-25 23:06 UTC (permalink / raw)
To: pramod gurav
Cc: Viresh Kumar, Rafael J. Wysocki, linux-pm@vger.kernel.org,
Linux Kernel Mailing List
On Fri, Jul 25, 2014 at 1:36 AM, pramod gurav
<pramod.gurav.etc@gmail.com> wrote:
> Viresh,
> Be careful when you ACK Nick's patches. He has confessed he has no
> idea how to build test a kernel. His patches are NOT AT ALL build
> tested. And some of his patches are being reverted for causing
> problems in build and all. He looks for FIXME and removes/edits the
> code as per the comments. Just be careful.
>
> On Mon, Jul 14, 2014 at 12:00 PM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
>> On 14 July 2014 11:58, Nicholas Krause <xerofoify@gmail.com> wrote:
>>> This fixes the latency for the cpufreq policy to 1 million nanoseconds
>>> that calls the function pxa_cpu_init for the member of the structure
>>> called cpuinfo.transition_latency.
>>>
>>> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
>>> ---
>>> drivers/cpufreq/pxa2xx-cpufreq.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/cpufreq/pxa2xx-cpufreq.c b/drivers/cpufreq/pxa2xx-cpufreq.c
>>> index e24269a..e08bb98 100644
>>> --- a/drivers/cpufreq/pxa2xx-cpufreq.c
>>> +++ b/drivers/cpufreq/pxa2xx-cpufreq.c
>>> @@ -372,7 +372,7 @@ static int pxa_cpufreq_init(struct cpufreq_policy *policy)
>>> init_sdram_rows();
>>>
>>> /* set default policy and cpuinfo */
>>> - policy->cpuinfo.transition_latency = 1000; /* FIXME: 1 ms, assumed */
>>> + policy->cpuinfo.transition_latency = 1000000;
>>>
>>> /* Generate pxa25x the run cpufreq_frequency_table struct */
>>> for (i = 0; i < NUM_PXA25x_RUN_FREQS; i++) {
>>
>> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at http://www.tux.org/lkml/
>
>
>
> --
> Thanks and Regards
> Pramod
Pramod,
I learned how to do it today and Viresh checked this and it didn't build
so I sent him another fixed patch :). I am learning fast now and known
how to properly test my patches now.
Nick
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2014-07-25 23:06 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-14 5:01 [PATCH] cpufreq: Fix latency for cpufreq_info Nicholas Krause
2014-07-14 6:10 ` Viresh Kumar
2014-07-14 6:25 ` Nick Krause
-- strict thread matches above, loose matches on Subject: below --
2014-07-14 6:28 Nicholas Krause
2014-07-14 6:30 ` Viresh Kumar
2014-07-25 5:36 ` pramod gurav
2014-07-25 23:06 ` Nick Krause
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).