linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: dirk.brandewie@gmail.com
To: linux-pm@vger.kernel.org
Cc: rjw@rjwysocki.net, Stratos Karafotis <stratosk@semaphore.gr>,
	Dirk Brandewie <dirk.j.brandewie@intel.com>
Subject: [PATCH 04/11] cpufreq: intel_pstate: Fit code in a single line where possible
Date: Fri, 18 Jul 2014 08:37:20 -0700	[thread overview]
Message-ID: <1405697848-13546-5-git-send-email-dirk.j.brandewie@intel.com> (raw)
In-Reply-To: <1405697848-13546-1-git-send-email-dirk.j.brandewie@intel.com>

From: Stratos Karafotis <stratosk@semaphore.gr>

We can fit these lines in a single one, under the 80 characters
limit.

Signed-off-by: Stratos Karafotis <stratosk@semaphore.gr>
Signed-off-by: Dirk Brandewie <dirk.j.brandewie@intel.com>
---
 drivers/cpufreq/intel_pstate.c | 18 +++++-------------
 1 file changed, 5 insertions(+), 13 deletions(-)

diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
index e9f3048..424c5a9 100644
--- a/drivers/cpufreq/intel_pstate.c
+++ b/drivers/cpufreq/intel_pstate.c
@@ -205,11 +205,7 @@ static inline void intel_pstate_busy_pid_reset(struct cpudata *cpu)
 	pid_d_gain_set(&cpu->pid, pid_params.d_gain_pct);
 	pid_i_gain_set(&cpu->pid, pid_params.i_gain_pct);
 
-	pid_reset(&cpu->pid,
-		pid_params.setpoint,
-		100,
-		pid_params.deadband,
-		0);
+	pid_reset(&cpu->pid, pid_params.setpoint, 100, pid_params.deadband, 0);
 }
 
 static inline void intel_pstate_reset_all_pid(void)
@@ -235,8 +231,7 @@ static int pid_param_get(void *data, u64 *val)
 	*val = *(u32 *)data;
 	return 0;
 }
-DEFINE_SIMPLE_ATTRIBUTE(fops_pid_param, pid_param_get,
-			pid_param_set, "%llu\n");
+DEFINE_SIMPLE_ATTRIBUTE(fops_pid_param, pid_param_get, pid_param_set, "%llu\n");
 
 struct pid_param {
 	char *name;
@@ -355,8 +350,7 @@ static void __init intel_pstate_sysfs_expose_params(void)
 	intel_pstate_kobject = kobject_create_and_add("intel_pstate",
 						&cpu_subsys.dev_root->kobj);
 	BUG_ON(!intel_pstate_kobject);
-	rc = sysfs_create_group(intel_pstate_kobject,
-				&intel_pstate_attr_group);
+	rc = sysfs_create_group(intel_pstate_kobject, &intel_pstate_attr_group);
 	BUG_ON(rc);
 }
 
@@ -515,8 +509,7 @@ static void intel_pstate_get_min_max(struct cpudata *cpu, int *min, int *max)
 			cpu->pstate.min_pstate, cpu->pstate.turbo_pstate);
 
 	min_perf = fp_toint(mul_fp(int_tofp(max_perf), limits.min_perf));
-	*min = clamp_t(int, min_perf,
-			cpu->pstate.min_pstate, max_perf);
+	*min = clamp_t(int, min_perf, cpu->pstate.min_pstate, max_perf);
 }
 
 static void intel_pstate_set_pstate(struct cpudata *cpu, int pstate)
@@ -713,8 +706,7 @@ static int intel_pstate_init_cpu(unsigned int cpunum)
 
 	init_timer_deferrable(&cpu->timer);
 	cpu->timer.function = intel_pstate_timer_func;
-	cpu->timer.data =
-		(unsigned long)cpu;
+	cpu->timer.data = (unsigned long)cpu;
 	cpu->timer.expires = jiffies + HZ/100;
 	intel_pstate_busy_pid_reset(cpu);
 	intel_pstate_sample(cpu);
-- 
1.9.3


  parent reply	other threads:[~2014-07-18 15:37 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-18 15:37 [PATCH 00/11] intel_pstate updates dirk.brandewie
2014-07-18 15:37 ` [PATCH 01/11] cpufreq: intel_pstate: Make intel_pstate_kobject and debugfs_parent locals dirk.brandewie
2014-07-18 15:37 ` [PATCH 02/11] cpufreq: intel_pstate: Remove unnecessary type casting in div_s64() call dirk.brandewie
2014-07-18 15:37 ` [PATCH 03/11] cpufreq: intel_pstate: Add missing blank lines after declarations dirk.brandewie
2014-07-18 15:37 ` dirk.brandewie [this message]
2014-07-18 15:37 ` [PATCH 05/11] cpufreq: intel_pstate: Cleanup parentheses dirk.brandewie
2014-07-18 15:37 ` [PATCH 06/11] cpufreq: intel_pstate: Remove unnecessary intermediate variable sample_time dirk.brandewie
2014-07-18 15:37 ` [PATCH 07/11] cpufreq: intel_pstate: Align multiple lines to open parenthesis dirk.brandewie
2014-07-18 15:37 ` [PATCH 08/11] cpufreq: intel_pstate: Disable interrupts during MSRs reading dirk.brandewie
2014-07-18 15:37 ` [PATCH 09/17] cpufreq: intel_pstate: Keep values in aperf/mperf in full precision dirk.brandewie
2014-07-18 15:37 ` [PATCH 09/11] cpufreq: intel_pstate: Simplify P state adjustment logic dirk.brandewie
2014-07-18 15:37 ` [PATCH 10/11] cpufreq: intel_pstate: Remove core_pct rounding dirk.brandewie
2014-07-18 15:37 ` [PATCH 11/11] cpufreq: intel_pstate: Keep values in aperf/mperf in full precision dirk.brandewie
2014-07-19 20:31 ` [PATCH 00/11] intel_pstate updates Rafael J. Wysocki
2014-07-19 21:01   ` Stratos Karafotis
2014-07-19 21:54     ` Rafael J. Wysocki
2014-07-19 22:05       ` Stratos Karafotis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1405697848-13546-5-git-send-email-dirk.j.brandewie@intel.com \
    --to=dirk.brandewie@gmail.com \
    --cc=dirk.j.brandewie@intel.com \
    --cc=linux-pm@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=stratosk@semaphore.gr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).