From: dirk.brandewie@gmail.com
To: linux-pm@vger.kernel.org
Cc: rjw@rjwysocki.net, Stratos Karafotis <stratosk@semaphore.gr>,
Dirk Brandewie <dirk.j.brandewie@intel.com>
Subject: [PATCH 08/11] cpufreq: intel_pstate: Disable interrupts during MSRs reading
Date: Fri, 18 Jul 2014 08:37:24 -0700 [thread overview]
Message-ID: <1405697848-13546-9-git-send-email-dirk.j.brandewie@intel.com> (raw)
In-Reply-To: <1405697848-13546-1-git-send-email-dirk.j.brandewie@intel.com>
From: Stratos Karafotis <stratosk@semaphore.gr>
According to Intel 64 and IA-32 Architectures SDM, Volume 3,
Chapter 14.2, "Software needs to exercise care to avoid delays
between the two RDMSRs (for example interrupts)".
So, disable interrupts during reading MSRs IA32_APERF and IA32_MPERF.
This should increase the accuracy of the calculations.
Signed-off-by: Stratos Karafotis <stratosk@semaphore.gr>
Signed-off-by: Dirk Brandewie <dirk.j.brandewie@intel.com>
---
drivers/cpufreq/intel_pstate.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
index 9d75bd6..ff3c562 100644
--- a/drivers/cpufreq/intel_pstate.c
+++ b/drivers/cpufreq/intel_pstate.c
@@ -577,9 +577,12 @@ static inline void intel_pstate_calc_busy(struct cpudata *cpu)
static inline void intel_pstate_sample(struct cpudata *cpu)
{
u64 aperf, mperf;
+ unsigned long flags;
+ local_irq_save(flags);
rdmsrl(MSR_IA32_APERF, aperf);
rdmsrl(MSR_IA32_MPERF, mperf);
+ local_irq_restore(flags);
aperf = aperf >> FRAC_BITS;
mperf = mperf >> FRAC_BITS;
--
1.9.3
next prev parent reply other threads:[~2014-07-18 15:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-18 15:37 [PATCH 00/11] intel_pstate updates dirk.brandewie
2014-07-18 15:37 ` [PATCH 01/11] cpufreq: intel_pstate: Make intel_pstate_kobject and debugfs_parent locals dirk.brandewie
2014-07-18 15:37 ` [PATCH 02/11] cpufreq: intel_pstate: Remove unnecessary type casting in div_s64() call dirk.brandewie
2014-07-18 15:37 ` [PATCH 03/11] cpufreq: intel_pstate: Add missing blank lines after declarations dirk.brandewie
2014-07-18 15:37 ` [PATCH 04/11] cpufreq: intel_pstate: Fit code in a single line where possible dirk.brandewie
2014-07-18 15:37 ` [PATCH 05/11] cpufreq: intel_pstate: Cleanup parentheses dirk.brandewie
2014-07-18 15:37 ` [PATCH 06/11] cpufreq: intel_pstate: Remove unnecessary intermediate variable sample_time dirk.brandewie
2014-07-18 15:37 ` [PATCH 07/11] cpufreq: intel_pstate: Align multiple lines to open parenthesis dirk.brandewie
2014-07-18 15:37 ` dirk.brandewie [this message]
2014-07-18 15:37 ` [PATCH 09/17] cpufreq: intel_pstate: Keep values in aperf/mperf in full precision dirk.brandewie
2014-07-18 15:37 ` [PATCH 09/11] cpufreq: intel_pstate: Simplify P state adjustment logic dirk.brandewie
2014-07-18 15:37 ` [PATCH 10/11] cpufreq: intel_pstate: Remove core_pct rounding dirk.brandewie
2014-07-18 15:37 ` [PATCH 11/11] cpufreq: intel_pstate: Keep values in aperf/mperf in full precision dirk.brandewie
2014-07-19 20:31 ` [PATCH 00/11] intel_pstate updates Rafael J. Wysocki
2014-07-19 21:01 ` Stratos Karafotis
2014-07-19 21:54 ` Rafael J. Wysocki
2014-07-19 22:05 ` Stratos Karafotis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1405697848-13546-9-git-send-email-dirk.j.brandewie@intel.com \
--to=dirk.brandewie@gmail.com \
--cc=dirk.j.brandewie@intel.com \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=stratosk@semaphore.gr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).