public inbox for linux-pm@vger.kernel.org
 help / color / mirror / Atom feed
From: Prarit Bhargava <prarit@redhat.com>
To: linux-pm@vger.kernel.org
Cc: rjw@rjwysocki.net, viresh.kumar@linaro.org,
	Prarit Bhargava <prarit@redhat.com>
Subject: [Question] Why is there a restriction on the policy->rwsem & CPUFREQ_GOV_POLICY_EXIT ?
Date: Wed, 23 Jul 2014 16:45:39 -0400	[thread overview]
Message-ID: <1406148339-29065-1-git-send-email-prarit@redhat.com> (raw)

I'm debugging a race/locking issue in the store_scaling_governor path and
came across the following restriction on using a semaphore in the
cpufreq_policy struct defined in include/linux/cpufreq.h :

         * Additional rules:
         * - Lock should not be held across
         *     __cpufreq_governor(data, CPUFREQ_GOV_POLICY_EXIT);

	struct rw_semaphore	rwsem;

I'm not completely familiar with this code and am wondering why the
restriction is in place?  Is there a worry about the module_put() in
__cpufreq_governor()?

Thanks,

P.

             reply	other threads:[~2014-07-23 20:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-23 20:45 Prarit Bhargava [this message]
2014-07-24  5:52 ` [Question] Why is there a restriction on the policy->rwsem & CPUFREQ_GOV_POLICY_EXIT ? Viresh Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1406148339-29065-1-git-send-email-prarit@redhat.com \
    --to=prarit@redhat.com \
    --cc=linux-pm@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox