From: Chuansheng Liu <chuansheng.liu@intel.com>
To: peterz@infradead.org, luto@amacapital.net,
daniel.lezcano@linaro.org, rjw@rjwysocki.net, mingo@redhat.com
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
changcheng.liu@intel.com, xiaoming.wang@intel.com,
souvik.k.chakravarty@intel.com,
Chuansheng Liu <chuansheng.liu@intel.com>
Subject: [PATCH 3/3] cpuidle: Using the kick_all_cpus_sync() to wake up all cpus
Date: Fri, 15 Aug 2014 15:01:25 +0800 [thread overview]
Message-ID: <1408086085-16691-3-git-send-email-chuansheng.liu@intel.com> (raw)
In-Reply-To: <1408086085-16691-1-git-send-email-chuansheng.liu@intel.com>
Current latency notify callback has the same function with
kick_all_cpus_sync().
Here use it directly to remove the redundant code.
Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
---
drivers/cpuidle/cpuidle.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c
index ee9df5e..7827375 100644
--- a/drivers/cpuidle/cpuidle.c
+++ b/drivers/cpuidle/cpuidle.c
@@ -530,11 +530,6 @@ EXPORT_SYMBOL_GPL(cpuidle_register);
#ifdef CONFIG_SMP
-static void smp_callback(void *v)
-{
- /* we already woke the CPU up, nothing more to do */
-}
-
/*
* This function gets called when a part of the kernel has a new latency
* requirement. This means we need to get all processors out of their C-state,
@@ -544,7 +539,7 @@ static void smp_callback(void *v)
static int cpuidle_latency_notify(struct notifier_block *b,
unsigned long l, void *v)
{
- smp_call_function(smp_callback, NULL, 1);
+ kick_all_cpus_sync();
return NOTIFY_OK;
}
--
1.7.9.5
prev parent reply other threads:[~2014-08-15 7:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-15 7:01 [PATCH 1/3] sched: Add new API wake_up_if_idle() to wake up the idle cpu Chuansheng Liu
2014-08-15 7:01 ` [PATCH 2/3] smp: re-implement the kick_all_cpus_sync() with wake_up_if_idle() Chuansheng Liu
2014-08-15 15:40 ` Andy Lutomirski
2014-08-18 0:12 ` Liu, Chuansheng
2014-08-15 7:01 ` Chuansheng Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1408086085-16691-3-git-send-email-chuansheng.liu@intel.com \
--to=chuansheng.liu@intel.com \
--cc=changcheng.liu@intel.com \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rjw@rjwysocki.net \
--cc=souvik.k.chakravarty@intel.com \
--cc=xiaoming.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).