From: Maciej Matraszek <m.matraszek@samsung.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [PATCH] PM / Domains: add debugfs listing of struct generic_pm_domain-s
Date: Thu, 11 Sep 2014 19:02:58 +0200 [thread overview]
Message-ID: <1410454978.8852.18.camel@AMDC723> (raw)
In-Reply-To: <20140910182712.GE14642@kroah.com>
On Wed, 2014-09-10 at 11:27 -0700, Greg Kroah-Hartman wrote:
> > >
> > > > + if (!d)
> > > > + return -ENOMEM;
> > > > +
> > > > + return 0;
> > > > +}
> > > > +late_initcall(pm_genpd_debug_init);
> > > > +#endif /* CONFIG_PM_ADVANCED_DEBUG */
> > >
> > > No tear-down of the debugfs files on shutdown?
> >
> > In drivers/clk/clk.c, there is no tear-down of debugfs files paired
> > with clk_debug_init(), same with wakeup_sources_debugfs_init() from
> > drivers/base/power/wakeup.c. On the other hand, some subsystems
> > perform it. What would you prefer?
>
> In my quest for symmetry I prefer to see files you add to be removed at
> the proper time. :)
And they will be! (in v2 :)
Thanks,
--
Maciej Matraszek
Samsung R&D Institute Poland
Samsung Electronics
next prev parent reply other threads:[~2014-09-11 17:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-10 11:28 [PATCH] PM / Domains: add debugfs listing of struct generic_pm_domain-s Maciej Matraszek
2014-09-10 14:43 ` Greg Kroah-Hartman
2014-09-10 15:38 ` Maciej Matraszek
2014-09-10 18:27 ` Greg Kroah-Hartman
2014-09-11 17:02 ` Maciej Matraszek [this message]
2014-09-10 19:18 ` Al Viro
2014-09-11 16:52 ` Maciej Matraszek
2014-09-11 8:51 ` Geert Uytterhoeven
2014-09-11 16:45 ` Maciej Matraszek
2014-09-11 17:27 ` Geert Uytterhoeven
2014-09-12 16:19 ` Maciej Matraszek
2014-09-17 11:09 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1410454978.8852.18.camel@AMDC723 \
--to=m.matraszek@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=k.kozlowski@samsung.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).