* PM / OPP: ARCH_HAS_OPP
@ 2014-07-28 12:47 Paul Bolle
2014-07-29 7:03 ` Shawn Guo
2014-09-12 8:38 ` [PATCH] PM / OPP: Remove ARCH_HAS_OPP completely Paul Bolle
0 siblings, 2 replies; 10+ messages in thread
From: Paul Bolle @ 2014-07-28 12:47 UTC (permalink / raw)
To: Mark Brown
Cc: Viresh Kumar, Nishanth Menon, Rob Herring, Shawn Guo,
Simon Horman, Rafael J. Wysocki, linux-pm
Mark,
Your commit 78c5e0bb145d ("PM / OPP: Remove ARCH_HAS_OPP") landed in
today's linux-next (ie, next-20140728). It removes the Kconfig symbol
ARCH_HAS_OPP and ten select statements for that symbol.
After that commit there are still nine select statements for that symbol
left in linux-next. (These select statements are now actually NOPs.) The
peculiar thing is that these nine statements are all found in Kconfig
files also touched by that commit.
Anyhow, are patches to remove these pointless select statements queued
somewhere?
Paul Bolle
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: PM / OPP: ARCH_HAS_OPP 2014-07-28 12:47 PM / OPP: ARCH_HAS_OPP Paul Bolle @ 2014-07-29 7:03 ` Shawn Guo 2014-09-12 8:38 ` [PATCH] PM / OPP: Remove ARCH_HAS_OPP completely Paul Bolle 1 sibling, 0 replies; 10+ messages in thread From: Shawn Guo @ 2014-07-29 7:03 UTC (permalink / raw) To: Paul Bolle Cc: Mark Brown, Viresh Kumar, Nishanth Menon, Rob Herring, Simon Horman, Rafael J. Wysocki, linux-pm On Mon, Jul 28, 2014 at 02:47:12PM +0200, Paul Bolle wrote: > Mark, > > Your commit 78c5e0bb145d ("PM / OPP: Remove ARCH_HAS_OPP") landed in > today's linux-next (ie, next-20140728). It removes the Kconfig symbol > ARCH_HAS_OPP and ten select statements for that symbol. > > After that commit there are still nine select statements for that symbol > left in linux-next. (These select statements are now actually NOPs.) The > peculiar thing is that these nine statements are all found in Kconfig > files also touched by that commit. > > Anyhow, are patches to remove these pointless select statements queued > somewhere? There a couple of such select in imx Kconfig, and I will clean them up. Shawn ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] PM / OPP: Remove ARCH_HAS_OPP completely 2014-07-28 12:47 PM / OPP: ARCH_HAS_OPP Paul Bolle 2014-07-29 7:03 ` Shawn Guo @ 2014-09-12 8:38 ` Paul Bolle 2014-09-12 10:20 ` Nishanth Menon 2014-09-16 0:09 ` Simon Horman 1 sibling, 2 replies; 10+ messages in thread From: Paul Bolle @ 2014-09-12 8:38 UTC (permalink / raw) To: Mark Brown, Viresh Kumar, Rafael J. Wysocki Cc: Nishanth Menon, Rob Herring, Shawn Guo, Simon Horman, Tony Lindgren, Russell King, Magnus Damm, MyungJoo Ham, Kyungmin Park, linux-omap, linux-arm-kernel, linux-sh, linux-pm, linux-kernel The Kconfig symbol ARCH_HAS_OPP became redundant in v3.16: commit 049d595a4db3 ("PM / OPP: Make OPP invisible to users in Kconfig") removed the only dependency that used it. Setting it had no effect anymore. So commit 78c5e0bb145d ("PM / OPP: Remove ARCH_HAS_OPP") removed it. For some reason that commit did not remove all select statements for that symbol. These statements are useless. Remove them too. Signed-off-by: Paul Bolle <pebolle@tiscali.nl> --- Done on top of next-20140912. Tested with git grep only! arch/arm/mach-omap2/Kconfig | 5 ----- arch/arm/mach-shmobile/Kconfig | 1 - drivers/devfreq/Kconfig | 1 - 3 files changed, 7 deletions(-) diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig index 5b103099626d..f138bd33a463 100644 --- a/arch/arm/mach-omap2/Kconfig +++ b/arch/arm/mach-omap2/Kconfig @@ -22,7 +22,6 @@ config ARCH_OMAP4 bool "TI OMAP4" depends on ARCH_MULTI_V7 select ARCH_OMAP2PLUS - select ARCH_HAS_OPP select ARCH_NEEDS_CPU_IDLE_COUPLED if SMP select ARM_CPU_SUSPEND if PM select ARM_ERRATA_720789 @@ -41,7 +40,6 @@ config SOC_OMAP5 bool "TI OMAP5" depends on ARCH_MULTI_V7 select ARCH_OMAP2PLUS - select ARCH_HAS_OPP select ARM_CPU_SUSPEND if PM select ARM_GIC select HAVE_ARM_SCU if SMP @@ -53,14 +51,12 @@ config SOC_AM33XX bool "TI AM33XX" depends on ARCH_MULTI_V7 select ARCH_OMAP2PLUS - select ARCH_HAS_OPP select ARM_CPU_SUSPEND if PM config SOC_AM43XX bool "TI AM43x" depends on ARCH_MULTI_V7 select ARCH_OMAP2PLUS - select ARCH_HAS_OPP select ARM_GIC select MACH_OMAP_GENERIC select MIGHT_HAVE_CACHE_L2X0 @@ -69,7 +65,6 @@ config SOC_DRA7XX bool "TI DRA7XX" depends on ARCH_MULTI_V7 select ARCH_OMAP2PLUS - select ARCH_HAS_OPP select ARM_CPU_SUSPEND if PM select ARM_GIC select HAVE_ARM_ARCH_TIMER diff --git a/arch/arm/mach-shmobile/Kconfig b/arch/arm/mach-shmobile/Kconfig index 21f457b56c01..f59019dd986e 100644 --- a/arch/arm/mach-shmobile/Kconfig +++ b/arch/arm/mach-shmobile/Kconfig @@ -36,7 +36,6 @@ menuconfig ARCH_SHMOBILE_MULTI select NO_IOPORT_MAP select PINCTRL select ARCH_REQUIRE_GPIOLIB - select ARCH_HAS_OPP if ARCH_SHMOBILE_MULTI diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig index 3dced0a9eae3..2227e9bf3884 100644 --- a/drivers/devfreq/Kconfig +++ b/drivers/devfreq/Kconfig @@ -80,7 +80,6 @@ config ARM_EXYNOS4_BUS_DEVFREQ config ARM_EXYNOS5_BUS_DEVFREQ bool "ARM Exynos5250 Bus DEVFREQ Driver" depends on SOC_EXYNOS5250 - select ARCH_HAS_OPP select DEVFREQ_GOV_SIMPLE_ONDEMAND select PM_OPP help -- 1.9.3 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] PM / OPP: Remove ARCH_HAS_OPP completely 2014-09-12 8:38 ` [PATCH] PM / OPP: Remove ARCH_HAS_OPP completely Paul Bolle @ 2014-09-12 10:20 ` Nishanth Menon 2014-09-12 10:46 ` Paul Bolle 2014-09-16 0:09 ` Simon Horman 1 sibling, 1 reply; 10+ messages in thread From: Nishanth Menon @ 2014-09-12 10:20 UTC (permalink / raw) To: Paul Bolle Cc: Mark Brown, Viresh Kumar, Rafael J. Wysocki, Rob Herring, Shawn Guo, Simon Horman, Tony Lindgren, Russell King, Magnus Damm, MyungJoo Ham, Kyungmin Park, linux-omap, linux-arm-kernel@lists.infradead.org, Linux-sh list, linux-pm@vger.kernel.org, lkml On Fri, Sep 12, 2014 at 3:38 AM, Paul Bolle <pebolle@tiscali.nl> wrote: > The Kconfig symbol ARCH_HAS_OPP became redundant in v3.16: commit > 049d595a4db3 ("PM / OPP: Make OPP invisible to users in Kconfig") > removed the only dependency that used it. Setting it had no effect > anymore. > > So commit 78c5e0bb145d ("PM / OPP: Remove ARCH_HAS_OPP") removed it. For > some reason that commit did not remove all select statements for that > symbol. These statements are useless. Remove them too. > > Signed-off-by: Paul Bolle <pebolle@tiscali.nl> > --- > Done on top of next-20140912. Tested with git grep only! > > arch/arm/mach-omap2/Kconfig | 5 ----- there can be conflict here: https://patchwork.kernel.org/patch/4857231/ http://marc.info/?l=linux-omap&m=141047815520894&w=2 > arch/arm/mach-shmobile/Kconfig | 1 - > drivers/devfreq/Kconfig | 1 - > 3 files changed, 7 deletions(-) > > diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig > index 5b103099626d..f138bd33a463 100644 > --- a/arch/arm/mach-omap2/Kconfig > +++ b/arch/arm/mach-omap2/Kconfig > @@ -22,7 +22,6 @@ config ARCH_OMAP4 > bool "TI OMAP4" > depends on ARCH_MULTI_V7 > select ARCH_OMAP2PLUS > - select ARCH_HAS_OPP > select ARCH_NEEDS_CPU_IDLE_COUPLED if SMP > select ARM_CPU_SUSPEND if PM > select ARM_ERRATA_720789 > @@ -41,7 +40,6 @@ config SOC_OMAP5 > bool "TI OMAP5" > depends on ARCH_MULTI_V7 > select ARCH_OMAP2PLUS > - select ARCH_HAS_OPP > select ARM_CPU_SUSPEND if PM > select ARM_GIC > select HAVE_ARM_SCU if SMP > @@ -53,14 +51,12 @@ config SOC_AM33XX > bool "TI AM33XX" > depends on ARCH_MULTI_V7 > select ARCH_OMAP2PLUS > - select ARCH_HAS_OPP > select ARM_CPU_SUSPEND if PM > > config SOC_AM43XX > bool "TI AM43x" > depends on ARCH_MULTI_V7 > select ARCH_OMAP2PLUS > - select ARCH_HAS_OPP > select ARM_GIC > select MACH_OMAP_GENERIC > select MIGHT_HAVE_CACHE_L2X0 > @@ -69,7 +65,6 @@ config SOC_DRA7XX > bool "TI DRA7XX" > depends on ARCH_MULTI_V7 > select ARCH_OMAP2PLUS > - select ARCH_HAS_OPP > select ARM_CPU_SUSPEND if PM > select ARM_GIC > select HAVE_ARM_ARCH_TIMER > diff --git a/arch/arm/mach-shmobile/Kconfig b/arch/arm/mach-shmobile/Kconfig > index 21f457b56c01..f59019dd986e 100644 > --- a/arch/arm/mach-shmobile/Kconfig > +++ b/arch/arm/mach-shmobile/Kconfig > @@ -36,7 +36,6 @@ menuconfig ARCH_SHMOBILE_MULTI > select NO_IOPORT_MAP > select PINCTRL > select ARCH_REQUIRE_GPIOLIB > - select ARCH_HAS_OPP > > if ARCH_SHMOBILE_MULTI > > diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig > index 3dced0a9eae3..2227e9bf3884 100644 > --- a/drivers/devfreq/Kconfig > +++ b/drivers/devfreq/Kconfig > @@ -80,7 +80,6 @@ config ARM_EXYNOS4_BUS_DEVFREQ > config ARM_EXYNOS5_BUS_DEVFREQ > bool "ARM Exynos5250 Bus DEVFREQ Driver" > depends on SOC_EXYNOS5250 > - select ARCH_HAS_OPP > select DEVFREQ_GOV_SIMPLE_ONDEMAND > select PM_OPP > help > -- > 1.9.3 > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-pm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- --- Regards, Nishanth Menon ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] PM / OPP: Remove ARCH_HAS_OPP completely 2014-09-12 10:20 ` Nishanth Menon @ 2014-09-12 10:46 ` Paul Bolle 2014-09-12 11:03 ` Geert Uytterhoeven 0 siblings, 1 reply; 10+ messages in thread From: Paul Bolle @ 2014-09-12 10:46 UTC (permalink / raw) To: Nishanth Menon Cc: Mark Brown, Viresh Kumar, Rafael J. Wysocki, Rob Herring, Shawn Guo, Simon Horman, Tony Lindgren, Russell King, Magnus Damm, MyungJoo Ham, Kyungmin Park, linux-omap, linux-arm-kernel@lists.infradead.org, Linux-sh list, linux-pm@vger.kernel.org, lkml On Fri, 2014-09-12 at 05:20 -0500, Nishanth Menon wrote: > On Fri, Sep 12, 2014 at 3:38 AM, Paul Bolle <pebolle@tiscali.nl> wrote: > > The Kconfig symbol ARCH_HAS_OPP became redundant in v3.16: commit > > 049d595a4db3 ("PM / OPP: Make OPP invisible to users in Kconfig") > > removed the only dependency that used it. Setting it had no effect > > anymore. > > > > So commit 78c5e0bb145d ("PM / OPP: Remove ARCH_HAS_OPP") removed it. For > > some reason that commit did not remove all select statements for that > > symbol. These statements are useless. Remove them too. > > > > Signed-off-by: Paul Bolle <pebolle@tiscali.nl> > > --- > > Done on top of next-20140912. Tested with git grep only! > > > > arch/arm/mach-omap2/Kconfig | 5 ----- > > there can be conflict here: > https://patchwork.kernel.org/patch/4857231/ > > http://marc.info/?l=linux-omap&m=141047815520894&w=2 Thanks. > > arch/arm/mach-shmobile/Kconfig | 1 - > > drivers/devfreq/Kconfig | 1 - Were patches submitted for these two files too? If so, we can probably just drop my patch. Paul Bolle ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] PM / OPP: Remove ARCH_HAS_OPP completely 2014-09-12 10:46 ` Paul Bolle @ 2014-09-12 11:03 ` Geert Uytterhoeven 2014-09-12 11:14 ` Paul Bolle 0 siblings, 1 reply; 10+ messages in thread From: Geert Uytterhoeven @ 2014-09-12 11:03 UTC (permalink / raw) To: Paul Bolle, Rafael J. Wysocki Cc: Nishanth Menon, Mark Brown, Viresh Kumar, Rob Herring, Shawn Guo, Simon Horman, Tony Lindgren, Russell King, Magnus Damm, MyungJoo Ham, Kyungmin Park, linux-omap, linux-arm-kernel@lists.infradead.org, Linux-sh list, linux-pm@vger.kernel.org, lkml Hi Paul, Rafael, On Fri, Sep 12, 2014 at 12:46 PM, Paul Bolle <pebolle@tiscali.nl> wrote: >> > arch/arm/mach-shmobile/Kconfig | 1 - >> > drivers/devfreq/Kconfig | 1 - > > Were patches submitted for these two files too? If so, we can probably > just drop my patch. Rafael said: "I've queued this up for 3.17, thanks!" http://lists.infradead.org/pipermail/linux-arm-kernel/2014-July/274681.html But it's not in -next. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] PM / OPP: Remove ARCH_HAS_OPP completely 2014-09-12 11:03 ` Geert Uytterhoeven @ 2014-09-12 11:14 ` Paul Bolle 0 siblings, 0 replies; 10+ messages in thread From: Paul Bolle @ 2014-09-12 11:14 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Rafael J. Wysocki, Nishanth Menon, Mark Brown, Viresh Kumar, Rob Herring, Shawn Guo, Simon Horman, Tony Lindgren, Russell King, Magnus Damm, MyungJoo Ham, Kyungmin Park, linux-omap, linux-arm-kernel@lists.infradead.org, Linux-sh list, linux-pm@vger.kernel.org, lkml On Fri, 2014-09-12 at 13:03 +0200, Geert Uytterhoeven wrote: > Hi Paul, Rafael, > > On Fri, Sep 12, 2014 at 12:46 PM, Paul Bolle <pebolle@tiscali.nl> wrote: > >> > arch/arm/mach-shmobile/Kconfig | 1 - > >> > drivers/devfreq/Kconfig | 1 - > > > > Were patches submitted for these two files too? If so, we can probably > > just drop my patch. > > Rafael said: "I've queued this up for 3.17, thanks!" > > http://lists.infradead.org/pipermail/linux-arm-kernel/2014-July/274681.html > > But it's not in -next. I think that patch landed as commit 78c5e0bb145d. But for some unknown reason it didn't remove all selects statements for ARCH_HAS_OPP. The odd thing here is that the last select statements I remove in this patch are all to be found in Kconfig files that actually were touched in that commit. Perhaps these select statements were merged back in during conflict resolution. I have no idea. Paul Bolle ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] PM / OPP: Remove ARCH_HAS_OPP completely 2014-09-12 8:38 ` [PATCH] PM / OPP: Remove ARCH_HAS_OPP completely Paul Bolle 2014-09-12 10:20 ` Nishanth Menon @ 2014-09-16 0:09 ` Simon Horman 2014-09-16 0:23 ` Simon Horman 1 sibling, 1 reply; 10+ messages in thread From: Simon Horman @ 2014-09-16 0:09 UTC (permalink / raw) To: Paul Bolle Cc: Mark Brown, Viresh Kumar, Rafael J. Wysocki, Nishanth Menon, Rob Herring, Shawn Guo, Tony Lindgren, Russell King, Magnus Damm, MyungJoo Ham, Kyungmin Park, linux-omap, linux-arm-kernel, linux-sh, linux-pm, linux-kernel On Fri, Sep 12, 2014 at 10:38:31AM +0200, Paul Bolle wrote: > The Kconfig symbol ARCH_HAS_OPP became redundant in v3.16: commit > 049d595a4db3 ("PM / OPP: Make OPP invisible to users in Kconfig") > removed the only dependency that used it. Setting it had no effect > anymore. > > So commit 78c5e0bb145d ("PM / OPP: Remove ARCH_HAS_OPP") removed it. For > some reason that commit did not remove all select statements for that > symbol. These statements are useless. Remove them too. > > Signed-off-by: Paul Bolle <pebolle@tiscali.nl> > --- > Done on top of next-20140912. Tested with git grep only! Hi Paul, could you break the shmobile portion out into a separate patch for me to take through my renesas tree? I am concerned that taking those changes via a different route will result in conflicts as arch/arm/mach-shmobile/Kconfig is often updated. > arch/arm/mach-omap2/Kconfig | 5 ----- > arch/arm/mach-shmobile/Kconfig | 1 - > drivers/devfreq/Kconfig | 1 - > 3 files changed, 7 deletions(-) > > diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig > index 5b103099626d..f138bd33a463 100644 > --- a/arch/arm/mach-omap2/Kconfig > +++ b/arch/arm/mach-omap2/Kconfig > @@ -22,7 +22,6 @@ config ARCH_OMAP4 > bool "TI OMAP4" > depends on ARCH_MULTI_V7 > select ARCH_OMAP2PLUS > - select ARCH_HAS_OPP > select ARCH_NEEDS_CPU_IDLE_COUPLED if SMP > select ARM_CPU_SUSPEND if PM > select ARM_ERRATA_720789 > @@ -41,7 +40,6 @@ config SOC_OMAP5 > bool "TI OMAP5" > depends on ARCH_MULTI_V7 > select ARCH_OMAP2PLUS > - select ARCH_HAS_OPP > select ARM_CPU_SUSPEND if PM > select ARM_GIC > select HAVE_ARM_SCU if SMP > @@ -53,14 +51,12 @@ config SOC_AM33XX > bool "TI AM33XX" > depends on ARCH_MULTI_V7 > select ARCH_OMAP2PLUS > - select ARCH_HAS_OPP > select ARM_CPU_SUSPEND if PM > > config SOC_AM43XX > bool "TI AM43x" > depends on ARCH_MULTI_V7 > select ARCH_OMAP2PLUS > - select ARCH_HAS_OPP > select ARM_GIC > select MACH_OMAP_GENERIC > select MIGHT_HAVE_CACHE_L2X0 > @@ -69,7 +65,6 @@ config SOC_DRA7XX > bool "TI DRA7XX" > depends on ARCH_MULTI_V7 > select ARCH_OMAP2PLUS > - select ARCH_HAS_OPP > select ARM_CPU_SUSPEND if PM > select ARM_GIC > select HAVE_ARM_ARCH_TIMER > diff --git a/arch/arm/mach-shmobile/Kconfig b/arch/arm/mach-shmobile/Kconfig > index 21f457b56c01..f59019dd986e 100644 > --- a/arch/arm/mach-shmobile/Kconfig > +++ b/arch/arm/mach-shmobile/Kconfig > @@ -36,7 +36,6 @@ menuconfig ARCH_SHMOBILE_MULTI > select NO_IOPORT_MAP > select PINCTRL > select ARCH_REQUIRE_GPIOLIB > - select ARCH_HAS_OPP > > if ARCH_SHMOBILE_MULTI > > diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig > index 3dced0a9eae3..2227e9bf3884 100644 > --- a/drivers/devfreq/Kconfig > +++ b/drivers/devfreq/Kconfig > @@ -80,7 +80,6 @@ config ARM_EXYNOS4_BUS_DEVFREQ > config ARM_EXYNOS5_BUS_DEVFREQ > bool "ARM Exynos5250 Bus DEVFREQ Driver" > depends on SOC_EXYNOS5250 > - select ARCH_HAS_OPP > select DEVFREQ_GOV_SIMPLE_ONDEMAND > select PM_OPP > help > -- > 1.9.3 > > ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] PM / OPP: Remove ARCH_HAS_OPP completely 2014-09-16 0:09 ` Simon Horman @ 2014-09-16 0:23 ` Simon Horman 2014-09-23 8:14 ` [PATCH] PM / devfreq: " Paul Bolle 0 siblings, 1 reply; 10+ messages in thread From: Simon Horman @ 2014-09-16 0:23 UTC (permalink / raw) To: Paul Bolle Cc: Mark Brown, Viresh Kumar, Rafael J. Wysocki, Nishanth Menon, Rob Herring, Shawn Guo, Tony Lindgren, Russell King, Magnus Damm, MyungJoo Ham, Kyungmin Park, linux-omap, linux-arm-kernel, linux-sh, linux-pm, linux-kernel On Tue, Sep 16, 2014 at 09:09:17AM +0900, Simon Horman wrote: > On Fri, Sep 12, 2014 at 10:38:31AM +0200, Paul Bolle wrote: > > The Kconfig symbol ARCH_HAS_OPP became redundant in v3.16: commit > > 049d595a4db3 ("PM / OPP: Make OPP invisible to users in Kconfig") > > removed the only dependency that used it. Setting it had no effect > > anymore. > > > > So commit 78c5e0bb145d ("PM / OPP: Remove ARCH_HAS_OPP") removed it. For > > some reason that commit did not remove all select statements for that > > symbol. These statements are useless. Remove them too. > > > > Signed-off-by: Paul Bolle <pebolle@tiscali.nl> > > --- > > Done on top of next-20140912. Tested with git grep only! > > Hi Paul, > > could you break the shmobile portion out into a separate patch > for me to take through my renesas tree? > > I am concerned that taking those changes via a different > route will result in conflicts as arch/arm/mach-shmobile/Kconfig > is often updated. Of course the above comment is redundant if Rafael has already taken this patch. > > > arch/arm/mach-omap2/Kconfig | 5 ----- > > arch/arm/mach-shmobile/Kconfig | 1 - > > drivers/devfreq/Kconfig | 1 - > > 3 files changed, 7 deletions(-) > > > > diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig > > index 5b103099626d..f138bd33a463 100644 > > --- a/arch/arm/mach-omap2/Kconfig > > +++ b/arch/arm/mach-omap2/Kconfig > > @@ -22,7 +22,6 @@ config ARCH_OMAP4 > > bool "TI OMAP4" > > depends on ARCH_MULTI_V7 > > select ARCH_OMAP2PLUS > > - select ARCH_HAS_OPP > > select ARCH_NEEDS_CPU_IDLE_COUPLED if SMP > > select ARM_CPU_SUSPEND if PM > > select ARM_ERRATA_720789 > > @@ -41,7 +40,6 @@ config SOC_OMAP5 > > bool "TI OMAP5" > > depends on ARCH_MULTI_V7 > > select ARCH_OMAP2PLUS > > - select ARCH_HAS_OPP > > select ARM_CPU_SUSPEND if PM > > select ARM_GIC > > select HAVE_ARM_SCU if SMP > > @@ -53,14 +51,12 @@ config SOC_AM33XX > > bool "TI AM33XX" > > depends on ARCH_MULTI_V7 > > select ARCH_OMAP2PLUS > > - select ARCH_HAS_OPP > > select ARM_CPU_SUSPEND if PM > > > > config SOC_AM43XX > > bool "TI AM43x" > > depends on ARCH_MULTI_V7 > > select ARCH_OMAP2PLUS > > - select ARCH_HAS_OPP > > select ARM_GIC > > select MACH_OMAP_GENERIC > > select MIGHT_HAVE_CACHE_L2X0 > > @@ -69,7 +65,6 @@ config SOC_DRA7XX > > bool "TI DRA7XX" > > depends on ARCH_MULTI_V7 > > select ARCH_OMAP2PLUS > > - select ARCH_HAS_OPP > > select ARM_CPU_SUSPEND if PM > > select ARM_GIC > > select HAVE_ARM_ARCH_TIMER > > diff --git a/arch/arm/mach-shmobile/Kconfig b/arch/arm/mach-shmobile/Kconfig > > index 21f457b56c01..f59019dd986e 100644 > > --- a/arch/arm/mach-shmobile/Kconfig > > +++ b/arch/arm/mach-shmobile/Kconfig > > @@ -36,7 +36,6 @@ menuconfig ARCH_SHMOBILE_MULTI > > select NO_IOPORT_MAP > > select PINCTRL > > select ARCH_REQUIRE_GPIOLIB > > - select ARCH_HAS_OPP > > > > if ARCH_SHMOBILE_MULTI > > > > diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig > > index 3dced0a9eae3..2227e9bf3884 100644 > > --- a/drivers/devfreq/Kconfig > > +++ b/drivers/devfreq/Kconfig > > @@ -80,7 +80,6 @@ config ARM_EXYNOS4_BUS_DEVFREQ > > config ARM_EXYNOS5_BUS_DEVFREQ > > bool "ARM Exynos5250 Bus DEVFREQ Driver" > > depends on SOC_EXYNOS5250 > > - select ARCH_HAS_OPP > > select DEVFREQ_GOV_SIMPLE_ONDEMAND > > select PM_OPP > > help > > -- > > 1.9.3 > > > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-sh" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] PM / devfreq: Remove ARCH_HAS_OPP completely 2014-09-16 0:23 ` Simon Horman @ 2014-09-23 8:14 ` Paul Bolle 0 siblings, 0 replies; 10+ messages in thread From: Paul Bolle @ 2014-09-23 8:14 UTC (permalink / raw) To: MyungJoo Ham, Kyungmin Park; +Cc: linux-pm, linux-kernel The Kconfig symbol ARCH_HAS_OPP became redundant in v3.16: commit 049d595a4db3 ("PM / OPP: Make OPP invisible to users in Kconfig") removed the only dependency that used it. Setting it had no effect anymore. So commit 78c5e0bb145d ("PM / OPP: Remove ARCH_HAS_OPP") removed it. For some reason that commit did not remove all select statements for that symbol. These statements are now useless. Remove one from devfreq too. Signed-off-by: Paul Bolle <pebolle@tiscali.nl> --- Sent previously as part of the treewide patch "PM / OPP: Remove ARCH_HAS_OPP completely". But it turns out the changes for omap2 are already queued in omap-for-v3.18/soc (but not in linux-next!). Besides, Simon Horman wanted the shmobile change split off. As a result this change needs to be sent separately. Done on top of next-20140922. Tested by grepping the tree. drivers/devfreq/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig index 3dced0a9eae3..2227e9bf3884 100644 --- a/drivers/devfreq/Kconfig +++ b/drivers/devfreq/Kconfig @@ -80,7 +80,6 @@ config ARM_EXYNOS4_BUS_DEVFREQ config ARM_EXYNOS5_BUS_DEVFREQ bool "ARM Exynos5250 Bus DEVFREQ Driver" depends on SOC_EXYNOS5250 - select ARCH_HAS_OPP select DEVFREQ_GOV_SIMPLE_ONDEMAND select PM_OPP help -- 1.9.3 ^ permalink raw reply related [flat|nested] 10+ messages in thread
end of thread, other threads:[~2014-09-23 8:14 UTC | newest] Thread overview: 10+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-07-28 12:47 PM / OPP: ARCH_HAS_OPP Paul Bolle 2014-07-29 7:03 ` Shawn Guo 2014-09-12 8:38 ` [PATCH] PM / OPP: Remove ARCH_HAS_OPP completely Paul Bolle 2014-09-12 10:20 ` Nishanth Menon 2014-09-12 10:46 ` Paul Bolle 2014-09-12 11:03 ` Geert Uytterhoeven 2014-09-12 11:14 ` Paul Bolle 2014-09-16 0:09 ` Simon Horman 2014-09-16 0:23 ` Simon Horman 2014-09-23 8:14 ` [PATCH] PM / devfreq: " Paul Bolle
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).