From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Russell King <linux@arm.linux.org.uk>,
Dan Williams <dan.j.williams@intel.com>,
Vinod Koul <vinod.koul@intel.com>,
linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org,
Ulf Hansson <ulf.hansson@linaro.org>,
Grant Likely <grant.likely@linaro.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Michal Simek <michal.simek@xilinx.com>,
linux-pm@vger.kernel.org,
Kyungmin Park <kyungmin.park@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [PATCH v3 1/4] PM / Runtime: Add getter for quering the IRQ safe option
Date: Mon, 15 Sep 2014 17:11:33 +0200 [thread overview]
Message-ID: <1410793893.883.4.camel@AMDC1943> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1409151056170.1360-100000@iolanthe.rowland.org>
On pon, 2014-09-15 at 10:57 -0400, Alan Stern wrote:
> On Mon, 15 Sep 2014, Krzysztof Kozlowski wrote:
>
> > Add a simple getter pm_runtime_is_irq_safe() for quering whether runtime
> > PM IRQ safe was set or not.
> >
> > Various bus drivers implementing runtime PM may use choose to suspend
> > differently based on IRQ safeness status of child driver (e.g. do not
> > unprepare the clock if IRQ safe is not set).
> >
> > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> > ---
> > include/linux/pm_runtime.h | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/include/linux/pm_runtime.h b/include/linux/pm_runtime.h
> > index 367f49b9a1c9..44d74f0f182e 100644
> > --- a/include/linux/pm_runtime.h
> > +++ b/include/linux/pm_runtime.h
> > @@ -128,6 +128,11 @@ static inline void pm_runtime_mark_last_busy(struct device *dev)
> > ACCESS_ONCE(dev->power.last_busy) = jiffies;
> > }
> >
> > +static inline bool pm_runtime_is_irq_safe(struct device *dev)
> > +{
> > + return dev->power.irq_safe;
> > +}
> > +
>
> If you add something to the runtime PM API, you must update the
> documentation file (Documentation/power/runtime_pm.txt)
> correspondingly.
Thank you for pointing this out. I'll fix this and re-spin.
Best regards,
Krzysztof
>
> Alan Stern
next prev parent reply other threads:[~2014-09-15 15:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-15 10:13 [PATCH v3 0/4] amba/dma: pl330: add Power Management support Krzysztof Kozlowski
2014-09-15 10:13 ` [PATCH v3 1/4] PM / Runtime: Add getter for quering the IRQ safe option Krzysztof Kozlowski
2014-09-15 14:57 ` Alan Stern
2014-09-15 15:11 ` Krzysztof Kozlowski [this message]
2014-09-15 10:13 ` [PATCH v3 2/4] amba: Add helper macros for (un)preparing AMBA clock Krzysztof Kozlowski
2014-09-15 10:13 ` [PATCH v3 3/4] amba: Don't unprepare the clocks if device driver wants IRQ safe runtime PM Krzysztof Kozlowski
2014-09-15 10:13 ` [PATCH v3 4/4] dma: pl330: add Power Management support Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1410793893.883.4.camel@AMDC1943 \
--to=k.kozlowski@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=kyungmin.park@samsung.com \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=m.szyprowski@samsung.com \
--cc=michal.simek@xilinx.com \
--cc=stern@rowland.harvard.edu \
--cc=ulf.hansson@linaro.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).