From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: Sebastian Reichel <sre@kernel.org>,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH on mfd-regulator-power-v3.17] charger: max14577: Fix build breakage when compiled as module
Date: Wed, 24 Sep 2014 16:38:25 +0200 [thread overview]
Message-ID: <1411569505.32515.0.camel@AMDC1943> (raw)
In-Reply-To: <20140924143519.GJ32069@lee--X1>
On śro, 2014-09-24 at 15:35 +0100, Lee Jones wrote:
> On Wed, 24 Sep 2014, Krzysztof Kozlowski wrote:
>
> > The charger's module device table used the same name as regulator driver
> > causing a build break when charger was compiled as a module:
> >
> > drivers/power/max14577_charger.c:598:1: error: ‘__mod_platform__max14577_regulator_id_device_table’ aliased to undefined symbol ‘max14577_regulator_id’
> > make[2]: *** [drivers/power/max14577_charger.o] Error 1
> >
> > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> > Reported-by: kbuild test robot <fengguang.wu@intel.com>
> > ---
> > drivers/power/max14577_charger.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> I have fixed this up into the original set and re-sent the
> pull-request.
Great, thanks!
Best regards,
Krzysztof
prev parent reply other threads:[~2014-09-24 14:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-24 12:00 [PATCH on mfd-regulator-power-v3.17] charger: max14577: Fix build breakage when compiled as module Krzysztof Kozlowski
2014-09-24 14:35 ` Lee Jones
2014-09-24 14:38 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1411569505.32515.0.camel@AMDC1943 \
--to=k.kozlowski@samsung.com \
--cc=broonie@kernel.org \
--cc=dbaryshkov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).