* [PATCH on mfd-regulator-power-v3.17] charger: max14577: Fix build breakage when compiled as module
@ 2014-09-24 12:00 Krzysztof Kozlowski
2014-09-24 14:35 ` Lee Jones
0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2014-09-24 12:00 UTC (permalink / raw)
To: Sebastian Reichel, Dmitry Eremin-Solenikov, David Woodhouse,
linux-pm, linux-kernel, Lee Jones
Cc: Mark Brown, Krzysztof Kozlowski
The charger's module device table used the same name as regulator driver
causing a build break when charger was compiled as a module:
drivers/power/max14577_charger.c:598:1: error: ‘__mod_platform__max14577_regulator_id_device_table’ aliased to undefined symbol ‘max14577_regulator_id’
make[2]: *** [drivers/power/max14577_charger.o] Error 1
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Reported-by: kbuild test robot <fengguang.wu@intel.com>
---
drivers/power/max14577_charger.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/power/max14577_charger.c b/drivers/power/max14577_charger.c
index c2e87c41d853..0a2bc7277026 100644
--- a/drivers/power/max14577_charger.c
+++ b/drivers/power/max14577_charger.c
@@ -595,7 +595,7 @@ static const struct platform_device_id max14577_charger_id[] = {
{ "max77836-charger", MAXIM_DEVICE_TYPE_MAX77836, },
{ }
};
-MODULE_DEVICE_TABLE(platform, max14577_regulator_id);
+MODULE_DEVICE_TABLE(platform, max14577_charger_id);
static struct platform_driver max14577_charger_driver = {
.driver = {
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH on mfd-regulator-power-v3.17] charger: max14577: Fix build breakage when compiled as module
2014-09-24 12:00 [PATCH on mfd-regulator-power-v3.17] charger: max14577: Fix build breakage when compiled as module Krzysztof Kozlowski
@ 2014-09-24 14:35 ` Lee Jones
2014-09-24 14:38 ` Krzysztof Kozlowski
0 siblings, 1 reply; 3+ messages in thread
From: Lee Jones @ 2014-09-24 14:35 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Sebastian Reichel, Dmitry Eremin-Solenikov, David Woodhouse,
linux-pm, linux-kernel, Mark Brown
On Wed, 24 Sep 2014, Krzysztof Kozlowski wrote:
> The charger's module device table used the same name as regulator driver
> causing a build break when charger was compiled as a module:
>
> drivers/power/max14577_charger.c:598:1: error: ‘__mod_platform__max14577_regulator_id_device_table’ aliased to undefined symbol ‘max14577_regulator_id’
> make[2]: *** [drivers/power/max14577_charger.o] Error 1
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> ---
> drivers/power/max14577_charger.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
I have fixed this up into the original set and re-sent the
pull-request.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH on mfd-regulator-power-v3.17] charger: max14577: Fix build breakage when compiled as module
2014-09-24 14:35 ` Lee Jones
@ 2014-09-24 14:38 ` Krzysztof Kozlowski
0 siblings, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2014-09-24 14:38 UTC (permalink / raw)
To: Lee Jones
Cc: Sebastian Reichel, Dmitry Eremin-Solenikov, David Woodhouse,
linux-pm, linux-kernel, Mark Brown
On śro, 2014-09-24 at 15:35 +0100, Lee Jones wrote:
> On Wed, 24 Sep 2014, Krzysztof Kozlowski wrote:
>
> > The charger's module device table used the same name as regulator driver
> > causing a build break when charger was compiled as a module:
> >
> > drivers/power/max14577_charger.c:598:1: error: ‘__mod_platform__max14577_regulator_id_device_table’ aliased to undefined symbol ‘max14577_regulator_id’
> > make[2]: *** [drivers/power/max14577_charger.o] Error 1
> >
> > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> > Reported-by: kbuild test robot <fengguang.wu@intel.com>
> > ---
> > drivers/power/max14577_charger.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> I have fixed this up into the original set and re-sent the
> pull-request.
Great, thanks!
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-09-24 14:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-24 12:00 [PATCH on mfd-regulator-power-v3.17] charger: max14577: Fix build breakage when compiled as module Krzysztof Kozlowski
2014-09-24 14:35 ` Lee Jones
2014-09-24 14:38 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).