linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert+renesas@glider.be>
To: Simon Horman <horms@verge.net.au>, Magnus Damm <magnus.damm@gmail.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
	linux-sh@vger.kernel.org, linux-pm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Geert Uytterhoeven <geert+renesas@glider.be>
Subject: [PATCH v2 03/11] ARM: shmobile: armadillo800eva legacy: Add missing A3SP pm domain devices
Date: Thu, 25 Sep 2014 18:15:34 +0200	[thread overview]
Message-ID: <1411661742-4767-4-git-send-email-geert+renesas@glider.be> (raw)
In-Reply-To: <1411661742-4767-1-git-send-email-geert+renesas@glider.be>

Commit 802a5639aa7041b2 ("ARM: shmobile: r8a7740: add A3SP pm domain
support") added the A3SP power domain, but forgot to hook up the TPU,
SDHI0/1, and MMCIF hardware blocks.

Note: As the default PM QoS latency constraint for SDHI is only 100 µs
(cfr. commit c419e611c3c59c0e ("tmio_mmc / PM: Use PM QoS latency
constraint"), while DEFAULT_DEV_LATENCY_NS is 250000, suspend fails with
-EBUSY, unless the constraint is increased first to more than 500 µs
using e.g.

    echo 501 > /sys/devices/platform/sh_mobile_sdhi.0/power/pm_qos_resume_latency_us

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v2:
  - Converted FIXME to Note, as this is expected behavior.

 arch/arm/mach-shmobile/board-armadillo800eva.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/arch/arm/mach-shmobile/board-armadillo800eva.c b/arch/arm/mach-shmobile/board-armadillo800eva.c
index f19459a8c3edbb77..64a68450c28a072c 100644
--- a/arch/arm/mach-shmobile/board-armadillo800eva.c
+++ b/arch/arm/mach-shmobile/board-armadillo800eva.c
@@ -1234,8 +1234,11 @@ static void __init eva_init(void)
 	static struct pm_domain_device domain_devices[] __initdata = {
 		{ "A4LC", &lcdc0_device },
 		{ "A4LC", &hdmi_lcdc_device },
+		{ "A3SP", &pwm_device },
+		{ "A3SP", &sdhi0_device },
+		{ "A3SP", &sh_mmcif_device },
 	};
-	struct platform_device *usb = NULL;
+	struct platform_device *usb = NULL, *sdhi1 = NULL;
 
 	regulator_register_always_on(0, "fixed-3.3V", fixed3v3_power_consumers,
 				     ARRAY_SIZE(fixed3v3_power_consumers), 3300000);
@@ -1304,6 +1307,7 @@ static void __init eva_init(void)
 
 		platform_device_register(&vcc_sdhi1);
 		platform_device_register(&sdhi1_device);
+		sdhi1 = &sdhi1_device;
 	}
 
 
@@ -1324,6 +1328,8 @@ static void __init eva_init(void)
 				       ARRAY_SIZE(domain_devices));
 	if (usb)
 		rmobile_add_device_to_domain("A3SP", usb);
+	if (sdhi1)
+		rmobile_add_device_to_domain("A3SP", sdhi1);
 
 	r8a7740_pm_init();
 }
-- 
1.9.1


  parent reply	other threads:[~2014-09-25 16:15 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-25 16:15 [PATCH v2 00/11] ARM: shmobile: r8a7740/armadillo800eva legacy PM domain support Geert Uytterhoeven
2014-09-25 16:15 ` [PATCH v2 01/11] ARM: shmobile: r8a7740: Add missing A3SP pm domain devices Geert Uytterhoeven
2014-09-25 16:15 ` [PATCH v2 02/11] ARM: shmobile: r8a7740: Add missing A4S " Geert Uytterhoeven
2014-09-25 16:15 ` Geert Uytterhoeven [this message]
2014-09-25 16:15 ` [PATCH v2 04/11] ARM: shmobile: armadillo800eva legacy: " Geert Uytterhoeven
2014-09-25 16:15 ` [PATCH v2 05/11] ARM: shmobile: r8a7740: Add A3RV pm domain support Geert Uytterhoeven
2014-09-25 16:15 ` [PATCH v2 06/11] ARM: shmobile: r8a7740: Add A3SG " Geert Uytterhoeven
2014-09-25 16:15 ` [PATCH v2 07/11] ARM: shmobile: r8a7740/armadillo legacy: Add A4MP " Geert Uytterhoeven
2014-09-25 16:15 ` [PATCH v2 08/11] ARM: shmobile: r8a7740: Add D4 " Geert Uytterhoeven
2014-09-25 16:15 ` [PATCH v2 09/11] ARM: shmobile: r8a7740/armadillo legacy: Add A4R " Geert Uytterhoeven
2014-09-25 16:15 ` [PATCH v2 10/11] ARM: shmobile: r8a7740: Add A4SU " Geert Uytterhoeven
2014-09-25 16:15 ` [PATCH v2 11/11] ARM: shmobile: r8a7740: Add A3SM " Geert Uytterhoeven
2014-09-30  4:20 ` [PATCH v2 00/11] ARM: shmobile: r8a7740/armadillo800eva legacy PM " Simon Horman
2014-09-30  7:16   ` Geert Uytterhoeven
2014-09-30  7:22     ` Magnus Damm
2014-09-30  7:28       ` Geert Uytterhoeven
2014-09-30  7:32         ` Magnus Damm
2014-09-30  7:41           ` Geert Uytterhoeven
2014-09-30  8:05             ` Magnus Damm
2014-09-30  8:13             ` Simon Horman
2014-10-03 15:23               ` Geert Uytterhoeven
2014-10-06  1:42                 ` Magnus Damm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1411661742-4767-4-git-send-email-geert+renesas@glider.be \
    --to=geert+renesas@glider.be \
    --cc=horms@verge.net.au \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=rjw@rjwysocki.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).