From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH 0/7] power_supply: Decrement the device reference counter Date: Wed, 15 Oct 2014 14:52:13 +0200 Message-ID: <1413377533.26771.16.camel@AMDC1943> References: <1413290117-13082-1-git-send-email-k.kozlowski@samsung.com> <20141015121841.GA26579@amd> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mailout3.w1.samsung.com ([210.118.77.13]:63294 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751512AbaJOMwS (ORCPT ); Wed, 15 Oct 2014 08:52:18 -0400 In-reply-to: <20141015121841.GA26579@amd> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Pavel Machek Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, Linus Walleij , Samuel Ortiz , Lee Jones , Sebastian Reichel , Dmitry Eremin-Solenikov , David Woodhouse , Konrad Rzeszutek Wilk , "Rafael J. Wysocki" , Lv Zheng , Bjorn Helgaas , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, Anton Vorontsov , Kyungmin Park , Marek Szyprowski , Bartlomiej Zolnierkiewicz On =C5=9Bro, 2014-10-15 at 14:18 +0200, Pavel Machek wrote: > Hi! >=20 > > The reference counter of device allocated for power supply was > > incremented with each call to power_supply_get_by_name() and > > power_supply_get_by_phandle(). > >=20 > > Add a symmetric 'put' operation so the device could be released aft= er > > final put_device() call during supply unregistering. > >=20 > >=20 > > Rebased on next-20141007 + mine [1] patchset. > > Tested on Trats2 board (max77693 + charger manager). > >=20 > > Kindly asking for reviewing/testing other drivers. >=20 > I'm not sure if we should support power_supply_put(NULL), but > otherwise the series looks ok to me. >=20 > Acked-by: Pavel Machek Thanks for reviewing. I'll remove the non-NULL check and resend with your ack. Best regards, Krzysztof